From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9E1AA00BE; Tue, 29 Oct 2019 07:43:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB9B91BEB3; Tue, 29 Oct 2019 07:43:16 +0100 (CET) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 1F8132BA2 for ; Tue, 29 Oct 2019 07:43:15 +0100 (CET) Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 8171DBC8FB1A033D6CAF; Tue, 29 Oct 2019 14:43:12 +0800 (CST) Received: from [127.0.0.1] (10.177.29.98) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.439.0; Tue, 29 Oct 2019 14:43:05 +0800 To: David Marchand , Ziyang Xuan CC: dev , , , , Ferruh Yigit References: From: "Wangxiaoyun (Cloud, Network Chip Application Development Dept)" Message-ID: <0025841e-6db1-480a-77ed-fe5481a67b10@huawei.com> Date: Tue, 29 Oct 2019 14:43:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.177.29.98] X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 00/15] A new net PMD - hinic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David , Thanks for your comments, I check the test-report from dpdk.org(https://mails.dpdk.org/archives/test-report/2019-October/101893.html), which shows hinic pmd driver passed meson build on FreeBSD12-64, also I analysize the building errs, pthread_mutex_consistent is defined in on FreeBSD and we also include this head file, I don't known why it also built failed, is there any changes about the configuration? Best regards Xiaoyun Wang 在 2019/10/26 22:43, David Marchand 写道: > On Thu, Jun 27, 2019 at 4:26 PM Ferruh Yigit wrote: >> On 6/27/2019 9:10 AM, Ziyang Xuan wrote: >>> This patch set adds support of a new net PMD >>> for Huawei Intelligent nic. This patch provides supoort >>> for basic RX/TX and the contorl path needed for it. >>> Later on new features will be added like VLAN, VFs, etc. >>> >>> Basic features: >>> 1. Basic device operations: probe, initialization, start/stop, >>> configure, info get. >>> 2. RX/TX queue operations: setup/release, start/stop. >>> 3. RX/TX. >>> >>> Stats: >>> 1. statistics and extended statistics. >>> >>> --- >>> v2: >>> - Fix arm64 compilation issue. >>> - Fix some checkpatch checks issues >>> - Fix patches thread issue. >>> - Fit to the newest rte_ prefix patch >>> >>> v3: >>> - Remove Rami from hinic pmd maintainers >>> - Remove hinic_logs.* files and move log codes to other files >>> - Remove the C++ guards within hinic pmd codes >>> - Remove variable related errors shields from compilation files >>> - Use lib link statu related functions but selfdefined >>> - Fix x86_64-native-linuxapp-clang compilation errors >>> - Fix i686-native-linuxapp-gcc compilation errors >>> >>> v4: >>> - Update doc hinic.ini and hinic.rst >>> - Remove x86-32, i686, BSD, Power8, ARMv7 compilations >>> - Fit to newest IPV4 and IPV6 uppercase >>> >>> v5: >>> - Update doc hinic.rst and release_19_08.rst >>> - Delete unused codes >>> - Optimize arch of codes and delete unnecessary files >>> - Remove rte_panic >>> - Subdivided patches >>> >>> v6: >>> - Adjust hinic pmd maintainers >>> - Use "CONFIG_RTE_ARCH_X86_64" to determine X86_64 for SSE instruction >>> - Fix "check-git-log.sh" checking errors >>> - Move "hinic_pmd_ethdev.h" to patch 11/15, and >>> "hinic_pmd_rx.h"/"hinic_pmd_tx.h" to patch 12/15 >>> >>> Ziyang Xuan (15): >>> net/hinic/base: add HW registers definition >>> net/hinic/base: add HW interfaces of bar operation >>> net/hinic/base: add API command channel code >>> net/hinic/base: add support for cmdq mechanism >>> net/hinic/base: add eq mechanism function code >>> net/hinic/base: add mgmt module function code >>> net/hinic/base: add code about hardware operation >>> net/hinic/base: add NIC business configurations >>> net/hinic/base: add context and work queue support >>> net/hinic/base: add various headers >>> net/hinic: add hinic PMD build and doc files >>> net/hinic: add device initailization >>> net/hinic: add start stop close queue ops >>> net/hinic: add Rx/Tx package burst >>> net/hinic: add RSS stats promiscuous ops >> For series, >> Reviewed-by: Ferruh Yigit >> >> Series applied to dpdk-next-net/master, thanks. >> >> >> This is first PMD from Huawei, welcome to dpdk, thanks for your efforts. > This driver is explicitely disabled for FreeBSD with the make build framework. > But I am getting a build error with meson on FreeBSD. > > ninja -C build-gcc-static > ninja: Entering directory `build-gcc-static' > [660/1372] Compiling C object > 'drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o'. > FAILED: drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o > ccache gcc -Idrivers/net/hinic/base/12a4447@@hinic_base@sta > -Idrivers/net/hinic/base -I../drivers/net/hinic/base -I. -I../ > -Iconfig -I../config -Ilib/librte_eal/common/include > -I../lib/librte_eal/common/include > -I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common > -I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 > -I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal > -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs > -Ilib/librte_ethdev -I../lib/librte_ethdev -Ilib/librte_net > -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf > -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring > -I../lib/librte_ring -Ilib/librte_meter -I../lib/librte_meter > -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/bsd > -Ilib/librte_pci -I../lib/librte_pci -Ilib/librte_hash > -I../lib/librte_hash -fdiagnostics-color=always -pipe > -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include > rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral > -Wformat-security -Wmissing-declarations -Wmissing-prototypes > -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare > -Wstrict-prototypes -Wundef -Wwrite-strings > -Wno-missing-field-initializers -D_GNU_SOURCE -D__BSD_VISIBLE -fPIC > -march=native -Wno-format-truncation -MD -MQ > 'drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o' > -MF 'drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o.d' > -o 'drivers/net/hinic/base/12a4447@@hinic_base@sta/hinic_pmd_cmdq.c.o' > -c ../drivers/net/hinic/base/hinic_pmd_cmdq.c > In file included from ../drivers/net/hinic/base/hinic_pmd_cmdq.c:5:0: > ../drivers/net/hinic/base/hinic_compat.h: In function 'hinic_mutex_lock': > ../drivers/net/hinic/base/hinic_compat.h:263:9: error: implicit > declaration of function 'pthread_mutex_consistent'; did you mean > 'pthread_mutex_init'? [-Werror=implicit-function-declaration] > (void)pthread_mutex_consistent(pthreadmutex); > ^~~~~~~~~~~~~~~~~~~~~~~~ > pthread_mutex_init > ../drivers/net/hinic/base/hinic_compat.h:263:9: error: nested extern > declaration of 'pthread_mutex_consistent' [-Werror=nested-externs] > cc1: all warnings being treated as errors > > Please fix or disable compilation. > Thanks. >