From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A64DA04B1; Thu, 5 Nov 2020 09:55:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A48A69C8; Thu, 5 Nov 2020 09:55:53 +0100 (CET) Received: from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105]) by dpdk.org (Postfix) with ESMTP id 421C069C8 for ; Thu, 5 Nov 2020 09:55:50 +0100 (CET) X-QQ-mid: bizesmtp9t1604566541tbc9jsd4b Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Thu, 05 Nov 2020 16:55:40 +0800 (CST) X-QQ-SSF: 01400000000000C0C000B00A0000000 X-QQ-FEAT: NSsJ0MoAoiJMxK3wzXTUchz+cL+z8n+slZmdhv5ZONXhpAcY5vwZBqze/NVKt FvciOqfPC3hzgDrMk72nsT3xNrKk542boBY6qSwsnluMPKQTP6Ud+pv1MZ92ZX+RLZZgAYi ZDZ5rsg9cNbeeic0BSphYPjfBGyychdYxtDXRGAeHt/XLdH+zmjWtQkA82bpe+jn6axER3/ VWXrjC8XFuzXb524VGmuXTSou3iaUkNdb81D3n5YobRzIJ2zfFBriYVj2516+I8d0IcIC+0 ETbfbyl/dRPKW0zgOL0FDZQMn7IzoJByTviekdr0N4srq5B7oJGt5t6egLirn7Z0hVk7CCO LHVLoZgS4UM/2bXCPg= X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Ferruh Yigit'" Cc: , , "'Thomas Monjalon'" References: <20201019085415.82207-1-jiawenwu@trustnetic.com> <000301d6ac0a$5be17140$13a453c0$@trustnetic.com> <6e95b6fe-d341-ac17-ff22-57e9b3a8cc2d@intel.com> <6496862.mUQds5VCSJ@thomas> In-Reply-To: Date: Thu, 5 Nov 2020 16:55:40 +0800 Message-ID: <003e01d6b351$709871d0$51c95570$@trustnetic.com>+BA624A85A0F5FAFF MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHa8hVbTdzNZG5niZylkY0c60fr5gIKaqHSAQ02qyADfJ4dKAH4p1zCqWvhXGCAAFKOwA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > 27/10/2020 12:37, Ferruh Yigit: > > >> On 10/27/2020 2:39 AM, Jiawen Wu wrote: > > >>> On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: > > >>>> Series applied to dpdk-next-net/main, thanks. > > >>>> > > >>>> 57/58 & 58/58 has been distributed to the relevant commits = while > > >>>> merging, please double check them in the upstream repo. > > >>>> > > >>>> 56/58 & 53/58 has been dropped while merging. > > >>>> 56/58 needs a new version which can be send individually, > > >>>> 53/58 is adding a deprecated feature, it can't go in as it = is. > > >>>> > > >>>> Also can you please send a patch for the comment mentioned in = 38/58? > > >>> > > >>> I will send two additional patches, one as a new version for > > >>> 56/58, the > > other one to fix 'rte_panic()'. > > > > > > When pulling in the main branch, I see some checkpatches warnings > > > (in order of criticality): > > > Using rte_smp_[r/w]mb > > > Using rte_panic/rte_exit > > > Using compiler attribute directly > > > > > > Please could you fix them (at least first two) before the second = series? > > > > > > > Hi Jiawen, Jian, > > > > I would like to double check if above request is clear, and if it is = OK in your > end? > > > > Thanks, > > ferruh >=20 > Sorry I did not see this message, I will add a patch to fix this = problem today. I saw ' rte_smp_*mb ' is in the deprecation notices, but there is no = function can be an alternative. I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to = replace 'rte_smp_rmb()', is it the correct usage?