From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D3105A0527;
	Mon,  9 Nov 2020 08:32:47 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BB0D758C4;
	Mon,  9 Nov 2020 08:32:45 +0100 (CET)
Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92])
 by dpdk.org (Postfix) with ESMTP id 59E142BF1
 for <dev@dpdk.org>; Mon,  9 Nov 2020 08:32:42 +0100 (CET)
X-QQ-mid: bizesmtp26t1604907145t3ow8agq
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp10.qq.com (ESMTP) with 
 id ; Mon, 09 Nov 2020 15:32:24 +0800 (CST)
X-QQ-SSF: 01400000000000C0C000B00A0000000
X-QQ-FEAT: IVPbyHleAa02rYlOHvWsrUEr9EJ0h7Cg5/xJh0vfgan4ddsXrEf4IBn1iH80N
 qw1haysTmrw1X0S+i9XCA/Oa25WKjiJscNuRpSXnAj07JNDGXEFfDL7K7zT5E3UmCXq3rx9
 7DcqJBDFjU+7xexCNaACnO18guyaPgOqqhHdsHKrSSlEkLr/6v7KSnqOLDppxJ5Cr5F/I2s
 gYikaN5IciXJuTf3WJWWxonadKaD7o0T+L5tDbFw5foeH39hY119IOQJL6t+l7ogEGgE8m3
 kwQKJmz3CCWrBGZO2M0F/ArWVlIhPPh0SL2/gkvNc6YBwpo45s+9RD10k2bPSx2nuw2WmUV
 yyENb0M
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@intel.com>,
	<dev@dpdk.org>
Cc: "'Thomas Monjalon'" <thomas@monjalon.net>
References: <20201106021053.2015777-1-jiawenwu@trustnetic.com>
 <df92cdae-0af5-31e2-9639-93ad612201b2@intel.com>
In-Reply-To: <df92cdae-0af5-31e2-9639-93ad612201b2@intel.com>
Date: Mon, 9 Nov 2020 15:32:24 +0800
Message-ID: <004701d6b66a$78307ac0$68917040$@trustnetic.com>+0E8CB1C4BA2F0792
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHWPwLnOIGRSwAFazJNzqOLSqPnpgKz28m2qapzCOA=
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign7
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH] net/txgbe: remove warning functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Friday, November 6, 2020 8:39 PM, Ferruh Yigit wrote:
> On 11/6/2020 2:10 AM, Jiawen Wu wrote:
> > Remove rte_panic(), and use rte_atomic_thread_fence() instead of
> > rte_smp_[r/w]mb.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied to
> dpdk-next-net/main, thanks.
> 
> 
> The remaining fix is :
> 	Using compiler attribute directly
> 
> I can see two instances are used:
> 1)
> drivers/net/txgbe/base/txgbe_dummy.h
> 10:#define TUP(x) x##_unused __attribute__((unused))
> 
> 2)
> drivers/net/txgbe/base/txgbe_osdep.h
> 152:#define __rte_weak __attribute__((__weak__))
> 
> 
> I think 2) simple can be removed completely, since it is not used at all.
> 
> 
> For 1) can it be moved to osdep.h? like:
> 
> #define TUP(x) x##_unused txgbe_unused
> txgbe_osdep.h: #define txgbe_unused __rte_unused

Thanks Ferruh,

It's a good way to deal with the remaining warning.
There will also be a patch to fix it.