From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A005045501; Wed, 26 Jun 2024 14:21:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E56B4337C; Wed, 26 Jun 2024 14:21:07 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 5741240269 for ; Wed, 26 Jun 2024 14:12:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719403927; x=1750939927; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=8SxfeciDUjnrfjcbMccl+XkHdPzNBM96QotTRbQjJnY=; b=l0ARfhHQvwt35+K+0P26c7WabrAcjbg+XX7yOy4W3PC9Gpjwz0xfwOJ/ Dn3XRLlkaa6TT6QdjrgG1JBZe3q8ED8sqw22XiBK5nQjCW4WTGXfrm8UO e5GDBZ5NsElGzjEGF074yb0K/fQbS18OYOKxe/Mf08nEr1pBYkGANAkCD IHdH5vRx/xn4ub4VjJ3X/Sf8HPHAjcfCR0wOZas7iFkunosOZbZ+HfF+3 8v9b6XPRaQx76KLJ/st0Q8QLeXLNTL4RcNrKLKB1B/DO/vRX+zP2Pdcas TkZAai5eANcCa7XZlg6yldX/17YjF8W3qQFnqTj1FtZt/KlJEUZOsQTR7 A==; X-CSE-ConnectionGUID: yRCJeMZWSGSF5tF+81lctQ== X-CSE-MsgGUID: ET5fToJDQ4uiwe60m/GMhg== X-IronPort-AV: E=McAfee;i="6700,10204,11114"; a="20352286" X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="20352286" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 05:12:06 -0700 X-CSE-ConnectionGUID: SyYZPNbYTNSoCBXd8zDBoA== X-CSE-MsgGUID: CiCFN/T9T6W1eKAFCzsTsQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="67205806" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Jun 2024 05:12:05 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 26 Jun 2024 05:12:04 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 26 Jun 2024 05:12:04 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 26 Jun 2024 05:12:04 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 26 Jun 2024 05:12:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BiejGsi6k2gtgzjiKpG5QYQEFI2CpoiCr6GwsnK086WN6htIFQdiKAJgleTdsChXGwhl0fnPRnnrTBUefKwfqXsKapgg15ahIYdW6Yf6w0J47TZrXwTntsYy/mL+JVVXLF5rdb0LrMnYlsRQAVun2CMvtg5kCAfvKoFSa8MCF2QewanuH5FhvZZI3Ls6QOkuwN1kGzsEw0k5L4ujrsFtBn8MXhyZcYK8VzQ7WPkAE+dJ6Bpqn0i6CjtKZJx5A9XbDqP5cDfX0p4zkbyfzCJYYar1EezKVctDpWnrGIGtCpVTAUgazTrcQS/fpAWS4IKJ+iqcs4ldDs8VncNcMJHBgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tli+T3/+5epfygaoChoXhlL9xAZzeOk1RIBIBOE7GxM=; b=nA4zlj3WT7b1h1c+/DQpAvkr30K2Z7I6gdwbAqciTR8ms/6VuyTN/TPgfMFH8al5HslpxMap9xQcFBrQTav0zJe/xfkXVgLeXxistmqXflelTdPpiAa7PAxdDkeEnGILfNNc0Kq8aoD9Cs8JKjal3iGOcOUUeZEFb43OMrGDpjrvZSN/ZNtF32nn/M+I1VoDwyoB3oYnKL0lVAI7Rzm566y31OQTkqmfkTKa8W2+PaP15mKjszP4is1M/9i5Qq20bb6m7Y1guxSahr9B715LQLJmG3dz2wWH45RoEP5h5JObbATaXbu7lnCDXf1dL5YsxPmE63v749OIqBAO4f03dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CH0PR11MB8190.namprd11.prod.outlook.com (2603:10b6:610:188::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.32; Wed, 26 Jun 2024 12:11:57 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%2]) with mapi id 15.20.7698.032; Wed, 26 Jun 2024 12:11:57 +0000 Message-ID: <0051908f-eba5-4ec2-a3de-952b1528ab53@intel.com> Date: Wed, 26 Jun 2024 14:11:32 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 093/103] net/ice/base: make Tx and Rx vernier offset calibration independent From: "Burakov, Anatoly" To: CC: , References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0244.eurprd04.prod.outlook.com (2603:10a6:10:28e::9) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CH0PR11MB8190:EE_ X-MS-Office365-Filtering-Correlation-Id: b1de5307-8185-448c-6768-08dc95d92182 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230038|376012|1800799022|366014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TFZaQmJBK1oxM3BkUXV4UkRzVHhOOWpFNi95bkZiYjRxcTc1dXBHRnFpbmcw?= =?utf-8?B?eXZOZUt1c3hIRElEQktCVVRZT2U5RERBWjZmb0RGVXpmUHlGTU5hcnhNb3Jv?= =?utf-8?B?S0NWL2FaQWc3Z3M5cHdXVlJ5VkhzcmxScFhheWxkZjRZSzFPaE1JR0RCeEhS?= =?utf-8?B?aTlnWGp5RkZGZDhUaXIwa040aCtFZk9EQkZob3dRQzczT1VaN29RYTJrMzhD?= =?utf-8?B?Zm5zbmJ0d1ZOay9KV1ZPQmhoby96SHcrMnROSm0xN05pdzMvQzdxbXVwU0p0?= =?utf-8?B?NWxUQ3pLY2JnZWdKY3dsWk1BNjhXZG1ONC9wbDg5QjJ6Y2V6bFJXbEpGTXAy?= =?utf-8?B?cDNLZldyZE1GbXJyMGFmQnhpSzUvTk5UZDF6SWpmZ2gwNUt6ZnFDMEZJUC9x?= =?utf-8?B?LzJ5RGVQdkFsSVR5ZVA5dnRqKzAyWmRFQmVYVkVRODZxeGVoVEx3aCtlTHVH?= =?utf-8?B?YmgvTGFXNkp4R00zQm8xdUpsYUNTL3RpRDZtQzUrRjNlcHplMVZSWHpnVTN5?= =?utf-8?B?VnFWa1pHK3lkUXRycHpmZnR3Q25DQWZnbGxiSVp0eTZ6NXR3SlRTdkI3S1RN?= =?utf-8?B?aUZKQnB3cU51SVVBMVpZVjY2UUlNTVJycjh2b3ZDV1hJcnV1blJYREc2dmVq?= =?utf-8?B?cyszQUhDcjZPMEhOayt2NUo2NHM0RjVPbENlUW05b1huQlUzRHlVeEZWVFhl?= =?utf-8?B?aWJuN0hxbDZYNlBOUGlKM3FDbldDdG1qQTNsYmRGM1Ivd1RGaWk5ME9ZNmVJ?= =?utf-8?B?N3BJY1lXVWcwejAxY0prUnFkR0ltYmdOTVBwQmsxaFhqcW9kQjM0MGxvckN2?= =?utf-8?B?TkxLYndYL2U0OHIyYWlIS1IvaGg2bzQyQ1liYXJBV00rOFhUY2pWZWRnL0RK?= =?utf-8?B?WnM5VGkrL2phZkpZU09HUHBTUU5xYWNLMk1pdDNNUlhISjBSOFU1TXNqNVBQ?= =?utf-8?B?a2paSFErMHhyVjl3N3dhcE12a1R4UCtrbE9Fb0VpSUdsUjlIY3lnK3Ryc0Nn?= =?utf-8?B?Y2NGTmVERzFJcU1FMzhFR05ydHZaWXNEUjRjRmpMYTgvWXZkSTNvd2M4SG1Q?= =?utf-8?B?UmdEd2MvNHB5QTlVVkZxdGJnU0IvYkRQUWVqeHAxanBOTkhINXBQZ1NXQnV1?= =?utf-8?B?QTQ3NkRHd00rZG5SS0YySDZpV285LzB0RGk2bzZPdEs3M0hiNENCbCtNa09R?= =?utf-8?B?dlNvTUJ3Q1QvcVdnMGg2ZFpCbldhc1cyOGgxQ3VnTDN1Um1XVUJ6SDFVRFpT?= =?utf-8?B?anlZWERTR3gzWHNRVFZOVHQyclVadzB4MVZhZElDZWVVWEIrWElhZnhoRlVC?= =?utf-8?B?eWNqcTFUWjZUZFI2dVBtRE9Zb0thdUw1Mmd6L1IvbFdSSUNoZ3JaYk1PV21x?= =?utf-8?B?RE5qOGNmaG1oQ250eldOTjlhMnk4VXFTL2N5V2dXNVc3NmU3SE1oSEZFS2t1?= =?utf-8?B?c1NLVWFuTkR3R2NDbUNLTWdzNGhueHNjcUorZE9LRTBveGVZNVltbFBUREda?= =?utf-8?B?WXd0ZEpiTlVHQjV0OFlLNkErRTBrZDhyQnpodkxwT05NK3MzOVB5ck11SmdO?= =?utf-8?B?MCs0WWUvMDM3ZTd4bm4xams5STFpakc5bEtzazVteGZta2tPTVcxYWhuZnhO?= =?utf-8?B?Z2x1djl4THBubWphVmRlTkNIeGx1Z3drblNNZ2tIclpDcjR0aXhsaU1pUlY3?= =?utf-8?B?WFp6VjVyRndndzdyZkxpeTFPZlpYRS95elFacXdLMlFvL0J3VHFlQmJtUGI3?= =?utf-8?Q?vFghtUIp+rFroptK8ElKyA+pSNsWtWE7pXhqCTd?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230038)(376012)(1800799022)(366014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlZsZmg2WWUwZ255WDZlRXk0bnFmdTV0UEh5ejVMOVM1VWpwQmFVQ1VaYlFx?= =?utf-8?B?K3lyRHMyeGVheHRVMmhESERjTXl5alAvaDhQZjVIalE4bFYvY2k1aElsRW1T?= =?utf-8?B?Z0RHeHp6bnpFeFpsVFZnNEZrNWdXQmlDL2Z5R2liaTdHSnRCc1ZNK0J3SGhJ?= =?utf-8?B?SERMOUNqb092d0hVT1JtRTlDSzZjdTY2c0prUUFKT2U3MWs5bWtjWkNMdFBR?= =?utf-8?B?T29ZSy9CSFg0cUNEQjBMaFF4eE9QUVdnY211RTVlNEVRdEIvTHNSZWxkelph?= =?utf-8?B?OVN1RFRmb3g4ZXdOZ3hQSkpLeW5BZ1NrN1dtRjR1MDRkSEtwVUs4YUFmNlY1?= =?utf-8?B?UDRMK1dROExPMHpkMmpOY0hob245YjJ3WDhxOWdZa1JEUURrQ21WWEs0bWtm?= =?utf-8?B?VVU2RnBaeTBVeUc4dDVsV3JtcEJ3RXVsTVRyR1RCNXphc1RFRk1LbDRuTXRz?= =?utf-8?B?NEl3NzkvNXh5Uk1PS3pJNmg1M2c1ejFRcnF2c2VNMGNiL0pDRU1rYzBsNkpv?= =?utf-8?B?UThIRjQreGo0VWdwWnVHWWhrVUZTNFRIbTVLVTNvc1ozVUxPUTF5Z3Y2cDlC?= =?utf-8?B?Zk8vcVg2RkZiMnRhK1Z2NjlSUVFTUGpWcnFpRU45REl4ZTZseU9IcjBkMkk3?= =?utf-8?B?RWc0cWZzNzNVRGNmNTRpUkdpaWZkV0owZXg1Yk1Mb3lZTlk2WVllM1lPT2F0?= =?utf-8?B?TU9Pa2FRaWI3T2VZUmlVV3J4cnRjdnpXWnkrNnM2V2FlNGVidDRqYnVRL2hl?= =?utf-8?B?WG1TbzVpUVE1Rk9EQWdkaEdZeWUvMkw2aFVzYkZ6ejV4SW5mU3Axci9VOUxP?= =?utf-8?B?NWVCdHpWMmtIbHUweXBjOXh2S2dxbVhNVHB6SCtwWEFjYlRESzhVOVJteGdO?= =?utf-8?B?THZwaU1hazdKUnJKOEJCeWpPeDZmUzM3Y0RSZjVPTUJnb3VoUUJ1SU1EWHl2?= =?utf-8?B?NnV4WmI4OWJBZUFPcWh1N0U5c2JJN3gyYUg5V050SG1lcFBPWFZYYThTMERG?= =?utf-8?B?Zko3TSs2UzRHTDFDOXJEd08wZUdySy94dGZGVndjeDlweU9QTUoxa2swRGpE?= =?utf-8?B?MHVtZytEdDZ6aVNyenhOOE9NS1ZuT1RWOVFnZ2xGOSt3YTFCWE90L2tOUmk5?= =?utf-8?B?dFpTSkxsU3lSb1ovRFFIRG1YeEN0U1BNMHlGTWxsMG9jLytHK1hjR2VkY3BV?= =?utf-8?B?SS9PL1dLZjg4dERDQ3JvTXYreXFhZlhYaHFhYVVucjlwU2lIVWFRY3E0RjZW?= =?utf-8?B?NnBlUUF1VW9wcUk3L0k0YXV4eHZGU2xiRldOTnJrb0FvZkI2SDJWU3M5ZDlv?= =?utf-8?B?bUI0M092ZnVRUDlzRDh2SGpmK0NPNkdYUzdiWUVuOEIyOEMyZE9tcUY4d3RO?= =?utf-8?B?dU4rZCtKUXhaV0ZlZmorKzRIM3VIZ1F6RC9vQzJaZUxEUFcreEkvdG9WSTcz?= =?utf-8?B?enhmMXhmSU4xQ0Ztbi8rbXo5QXluNGNjdGVzd3FWL0pYeW8vZDRQd2VpNzZJ?= =?utf-8?B?NXRIcDFldERJTm5VMGNrVnpZUVlsMTZzZ01lQ0IrZ2ZiSVVXaGovMldPaFZa?= =?utf-8?B?a242VXBNdWdlbkZVUVI1aWJVODRoMitZRlBaT3VZM1JBL1ltL0NnV3ZOUTU1?= =?utf-8?B?UCtLSnlmUU91eFcxbVh0STZyMnBUTm1BV3NDaUQvelpWNC9vbVF4YTJXTnBa?= =?utf-8?B?TUd0OFBXNWZWSXRpNkVKb2J2ZHR5d1ZGaHBJaUJjZUNqUm9MWlJlUTZLVTV3?= =?utf-8?B?MHhadG12SHdjYzJLQld3ZnY0OGtscXdrd25FTU9lV0E1anp6S1VSWEFmRXIw?= =?utf-8?B?dTZUeE9pSjJHY0VWT045L1BOMFRBWmxNRW94U04rSDl5eWN5MGNjMGlCNDFD?= =?utf-8?B?ZjlUTlQ4R290UmRzcGFhYnFwczI3N2hrM0VqR2FjaldQUlcvRG1JM3ZnelNt?= =?utf-8?B?anpUdVNvNWo1L2tabHNKZzQ3MndoN0dPazNDekxLZ2EzZWoyb0treVdDU3NM?= =?utf-8?B?bTlyRTc3S1BRaVVvV2pHa3l5Nlp6TmRxUnNPb3E3OVRCM1ZOdk1rK1VvdzFR?= =?utf-8?B?cEx2RnI2VnFVeFkwSm4yUWdDMVFuTDcxaEdrNTN2TXNvcXlhMzI5QXlmSXVj?= =?utf-8?B?dUlzbzcwNkZ2OE56alV1eGdMQzNzc1diN2cxVnZLYmV4ajh3YU5wcUtkaGJx?= =?utf-8?B?Qmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b1de5307-8185-448c-6768-08dc95d92182 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2024 12:11:57.5363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2Dj55+M8lWerubqO/tC7+YpuqXBeYh1MtFpB43EUrRHnVRl7evdOVWC9o26Ex4GTa1rFTfezR9Fu50YFc2SZJAAT5b0XbILKoxGQDLdhnJE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8190 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/26/2024 1:42 PM, Anatoly Burakov wrote: > The Tx and Rx calibration and timestamp generation blocks are independent. It is > not required to wait for both to complete before programming the offsets. > Instead, we can program the offset for each independently as soon as they are > ready. > > Modify the ice_phy_cfg_tx_offset_e822 and ice_phy_cfg_rx_offset_e822 functions > with the following additions: > > a) Check the relevant P_REG_*_OR bit first and do nothing if the offset has > already been programmed > > b) Check the P_REG_*_OV_STATUS bit to determine if the offset status is ready, > meaning that the hardware vernier calibration steps have completed. Return > ICE_ERR_NOT_READY if the offset is not yet read. > > The driver can now simply call ice_phy_cfg_rx_offset_e822 and > ice_phy_cfg_tx_offset_e822 periodically until the offsets have been programmed. > > In this way, the Tx and Rx blocks will be enabled independently without each > waiting on the other block to complete. This can enable faster calibration on > some setups which have a low rate of either Tx or Rx traffic. > > Signed-off-by: Siddaraju DH > Signed-off-by: Jacob Keller > Signed-off-by: Anatoly Burakov > --- The patch has accidentally been submitted with incorrect authorship information, please amend on apply to being authored by Siddaraju DH (from first signoff line). -- Thanks, Anatoly