From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B775043C07; Tue, 27 Feb 2024 11:56:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 921CF4027D; Tue, 27 Feb 2024 11:56:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2A8B840150 for ; Tue, 27 Feb 2024 11:56:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709031404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6v6L3AHwN84La6EYybsTgGJiApV5QvA/PhnzLeAvQ6I=; b=eWXNXMiNLdYqtNd9jOZbuKbQGF/IjTRVeV7TIjLsarZlY1HAw4oRLRGm0yHvn8c5P24VfA tsewFjwWnhAol5QjWp/bjI8sOmr62fupqoUFAmy7cvPmhVIujPy99Q1V0+9hgdw47W+k0a cUvs35nOW9pUzEW0t16e5hUIjlGiGeA= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-LChGRN1uNLil2fhHisrmUQ-1; Tue, 27 Feb 2024 05:56:43 -0500 X-MC-Unique: LChGRN1uNLil2fhHisrmUQ-1 Received: by mail-io1-f72.google.com with SMTP id ca18e2360f4ac-7c784914db2so439581939f.0 for ; Tue, 27 Feb 2024 02:56:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709031402; x=1709636202; h=content-transfer-encoding:in-reply-to:cc:autocrypt:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6v6L3AHwN84La6EYybsTgGJiApV5QvA/PhnzLeAvQ6I=; b=Uon21+YuVBnxHbkEVXxgvjJweBAwXKFVQw4v32k3RNU3l4mazbQXggj4HYfUg+ALgN rbt3DRXA9OpkBOmZRvQ0jGxzeJm3aamVU6Bn8GqvyQbWqiDeehVLfmYinOYpNaIMUa9h ljduCDWDL9pk0vfKwb81Qh010bvwxUCWQfNRuR7H/gmVHotZORvCQtIPYeZ4b1lV1iHI cHXw4Z9n18DvEKTTG92jtxWO6USg00W1RSzBrbbtrJzT1NvGL0qiznVUD0+CovY6o/A1 bJj5PTAKsk2+axlvjrWYQF+tBTBlCYj2vQPsYuwlr81VNQS1NLFTrXUICej4SSoM4oCn eJ5g== X-Gm-Message-State: AOJu0Yz3dDE0nE/1CbzHJfeRu6M/syJfpz9jbOGO8/+rf/ZqbnUDqfr7 TRvgBheiCs+7QAc2cRpEygRRgEy87X4os5J2NGTTq4VAI9NgqwXll25mplF0to/qTL5eF3ADb9o cIAaalvPDRuM5W5n1/u4mC4S/TX5kYqFf87PHxuwxELSHGYMBIFpbnOszrcQcxK4vWTJPU6y8j6 3Y/3XtDHm8Y0Q+wNi1hf7d+1E3 X-Received: by 2002:a05:6602:6015:b0:7c7:b567:3899 with SMTP id fr21-20020a056602601500b007c7b5673899mr11057480iob.8.1709031400993; Tue, 27 Feb 2024 02:56:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnYALewJqDNZLcToC8ZHRl32zIqqnp7JXfcqJq/AbS/69sppR5/XdQJFWGobi7w9mEKqSJpw== X-Received: by 2002:a05:6602:6015:b0:7c7:b567:3899 with SMTP id fr21-20020a056602601500b007c7b5673899mr11057414iob.8.1709031399812; Tue, 27 Feb 2024 02:56:39 -0800 (PST) Received: from [192.168.0.36] ([78.19.96.89]) by smtp.gmail.com with ESMTPSA id d22-20020a5d9516000000b007c7b076f07asm1508285iom.15.2024.02.27.02.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 02:56:39 -0800 (PST) Message-ID: <00597ca5-537f-43be-8f57-a102199b421a@redhat.com> Date: Tue, 27 Feb 2024 10:56:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/ixgbe: increase vf reset timeout To: dev@dpdk.org, "Richardson, Bruce" References: <20240130100027.39466-1-ktraynor@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Cc: Qiming Yang , Wenjun Wu In-Reply-To: <20240130100027.39466-1-ktraynor@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Bruce, I see you are the lucky delegate for this patch :-) https://patchwork.dpdk.org/project/dpdk/patch/20240130100027.39466-1-ktraynor@redhat.com/ Just wondering if any comment and if it's planned for 23.03 or later release ? thanks, Kevin. On 30/01/2024 10:00, Kevin Traynor wrote: > When vf issues a reset to pf there is a 50 msec wait plus an additional > max of 1 msec for the pf to indicate the reset is complete before > timeout. > > In some cases, it is seen that the reset is timing out, in which case > the reset does not complete and an error is returned. > > In order to account for this, continue to wait an initial 50 msecs, > but then allow a max of an additional 50 msecs for the command to > complete. > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Kevin Traynor > --- > drivers/net/ixgbe/base/ixgbe_type.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h > index 1094df5891..35212a561b 100644 > --- a/drivers/net/ixgbe/base/ixgbe_type.h > +++ b/drivers/net/ixgbe/base/ixgbe_type.h > @@ -1801,5 +1801,5 @@ enum { > #define IXGBE_VFRE_ENABLE_ALL 0xFFFFFFFF > > -#define IXGBE_VF_INIT_TIMEOUT 200 /* Number of retries to clear RSTI */ > +#define IXGBE_VF_INIT_TIMEOUT 10000 /* Number of retries to clear RSTI */ > > /* RDHMPN and TDHMPN bitmasks */