From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58E7EA04AC; Tue, 1 Sep 2020 13:59:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60D3C1C0AD; Tue, 1 Sep 2020 13:52:28 +0200 (CEST) Received: from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105]) by dpdk.org (Postfix) with ESMTP id 60EF61C069 for ; Tue, 1 Sep 2020 13:52:26 +0200 (CEST) X-QQ-mid: bizesmtp21t1598961142tabm66fh Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Tue, 01 Sep 2020 19:52:22 +0800 (CST) X-QQ-SSF: 01400000000000B0C000000A0000000 X-QQ-FEAT: eydUYaHeyIS+UBHvPGMiR3XP2OQItcRCy3btlMc90nGQZMCEfLujlQKHapQf7 IbR0Ry8ZC6+LFMjimbHkF2HI9n1nw3nxjPED+KH47tfyKH6JSgf1g+xmNV4AbzUr2bMMgEa 1khIXJANxvqrMbOGPxhfKPTQybEDqRY5FT6k1DPOELkX+4ZJQMAVq80U0AW6VlaAxKyYIvi rheF4ga1ActcTul2P/Xd4i8wF4z02DrsAQMuQd3eVSsgm8AZFO9R7avwL+krKX1w/3QtLVp plvPjlLr6tTIrrBKfiATrdjMrxf9H3SBdi1pQcWZ50OftDSVW48oY4gc8QKfVjGdKYwbSG8 cTna/MLYq8Ai5n3gxjt4+8eJ+dzgw4CLzHQgVey X-QQ-GoodBg: 2 From: To: "'Ferruh Yigit'" , References: <20200820030231.1382984-1-jiawenwu@trustnetic.com> In-Reply-To: Date: Tue, 1 Sep 2020 19:52:22 +0800 Message-ID: <006401d68056$5a761840$0f6248c0$@trustnetic.com>+65476EF2A6967850 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEqtWxXPBV0hptEKj6a/MU381+bjAHE40K8qosv5GCAEeKlUA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, Since this patch is too large, it needs to be split into so many small = patches, which takes a lot of time. Therefore, I first created a part of patches to contribute. And if there = is a review problem with these patches, please let me know as soon. And I will complete the remaining patches in the next 3~4 days. Thanks. -----Original Message----- From: jiawenwu@trustnetic.com =20 Sent: Friday, August 21, 2020 10:22 AM To: 'Ferruh Yigit' ; 'dev@dpdk.org' = Cc: 'jianwang@trustnetic.com' ; = 'yuhongzhang@trustnetic.com' Subject: RE: [PATCH] net: add a new network PMD named txgbe Hi Ferruh, Thanks for your suggestion. I'll split the patch into a patchset as soon = as possible. -----Original Message----- From: Ferruh Yigit =20 Sent: Thursday, August 20, 2020 7:49 PM To: Jiawen Wu ; dev@dpdk.org Cc: jianwang@trustnetic.com; yuhongzhang@trustnetic.com Subject: Re: [PATCH] net: add a new network PMD named txgbe On 8/20/2020 4:02 AM, Jiawen Wu wrote: > This is a new network PMD named txgbe provides poll mode driver = support for Wangxun 10Gb Ethernet NICs. >=20 > Beijing WangXun Technology Co., Ltd. is a high-tech company = specializing in the design of high-end integrated circuit chips and = providing independent innovation solutions for enterprise network and = storage products. Founded in May 2014, the company is headquartered in = Beijing YuQuanHuiGu Science and Technology Park, with branches in = Hangzhou City. Welcome to reach us on website https://www.net-swift.com. >=20 > This patch is created base on the main branch in main repository. Our = goal is to validate and commit txgbe driver into the 20.11 official = release, and then continue the development and maintenance in community. >=20 > Waiting for your reviews sincerely. >=20 > Signed-off-by: Jiawen Wu Hi Jiawen, Thanks for the patch. Without looking into any detail, a very high level comment is, it is = very hard to review a new PMD (40K+ loc) as a single patch. Can you please split the patch into multiple patches, which gradually = build the PMD by adding a feature with each patch, starting from an = empty skeleton. Last as few upstreamed PMDs as example: ionic: https://patches.dpdk.org/project/dpdk/list/?series=3D8206&state=3D%2A&arc= hive=3Dboth pfe: https://patches.dpdk.org/project/dpdk/list/?series=3D6777&state=3D%2A&arc= hive=3Dboth octeontx2 (one of the good samples I suggest checking): https://patches.dpdk.org/project/dpdk/list/?series=3D5302&state=3D%2A&arc= hive=3Dboth Also you can skip all Makefile build system related changes, since it = will be removed in this release, no need to spend time for it. Thanks, ferruh