Re: [dpdk-dev] [PATCH v3 02/14] bbdev: expose device HARQ buffer size at device level

[Dave Burley <dave.burley@accelercomm.com>]

Acked-by: Dave Burley <dave.burley@accelercomm.com>

On 04/03/2020 18:54, Nicolas Chautru wrote:
> From: Nic Chautru <nicolas.chautru@intel.com>
>
> This exposes the HARQ buffer size at the device driver level
> instead of using the capability of a specific operation.
>
> This is currently not yet used by a device until
> future commit.
>
> Signed-off-by: Nic Chautru <nicolas.chautru@intel.com>
> ---
>   drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +-
>   lib/librte_bbdev/rte_bbdev.h                     | 2 ++
>   lib/librte_bbdev/rte_bbdev_op.h                  | 2 --
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> index f2fe7a2..6d5e080 100644
> --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> @@ -219,7 +219,6 @@ struct turbo_sw_queue {
>   					RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE,
>   			.llr_size = 8,
>   			.llr_decimals = 2,
> -			.harq_memory_size = 0,
>   			.num_buffers_src =
>   					RTE_BBDEV_LDPC_MAX_CODE_BLOCKS,
>   			.num_buffers_hard_out =
> @@ -251,6 +250,7 @@ struct turbo_sw_queue {
>   	dev_info->default_queue_conf = default_queue_conf;
>   	dev_info->capabilities = bbdev_capabilities;
>   	dev_info->min_alignment = 64;
> +	dev_info->harq_buffer_size = 0;
>   
>   	rte_bbdev_log_debug("got device info from %u\n", dev->data->dev_id);
>   }
> diff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h
> index b2da190..38d9d50 100644
> --- a/lib/librte_bbdev/rte_bbdev.h
> +++ b/lib/librte_bbdev/rte_bbdev.h
> @@ -307,6 +307,8 @@ struct rte_bbdev_driver_info {
>   	bool queue_intr_supported;
>   	/** Minimum alignment of buffers, in bytes */
>   	uint16_t min_alignment;
> +	/** HARQ memory available in kB */
> +	uint32_t harq_buffer_size;
>   	/** Default queue configuration used if none is supplied  */
>   	struct rte_bbdev_queue_conf default_queue_conf;
>   	/** Device operation capabilities */
> diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h
> index 062f9ff..8122089 100644
> --- a/lib/librte_bbdev/rte_bbdev_op.h
> +++ b/lib/librte_bbdev/rte_bbdev_op.h
> @@ -712,8 +712,6 @@ struct rte_bbdev_op_cap_ldpc_dec {
>   	int8_t llr_size;
>   	/** LLR numbers of decimals bit for arithmetic representation */
>   	int8_t llr_decimals;
> -	/** Amount of memory for HARQ in external DDR in MB */
> -	uint16_t harq_memory_size;
>   	/** Num input code block buffers */
>   	uint16_t num_buffers_src;
>   	/** Num hard output code block buffers */