From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B668A0567; Fri, 13 Mar 2020 11:47:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A7211BFA5; Fri, 13 Mar 2020 11:47:10 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 5D7881BF97 for ; Fri, 13 Mar 2020 11:47:08 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id a132so9388038wme.1 for ; Fri, 13 Mar 2020 03:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=accelercomm-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=AMM15H6JjOFElbnxTgmGX3rlzOj1/by+eFASc1hrh9Q=; b=NX/gOpoVCviPWP6lykTv4W62eEElDuH+cXxM/rDfNIZo7BXkS57tpDQ5uBUI/2Qly3 OKYvLK5Pku5T4NYiyySsZJFwAUpluUPTKOCJhCxpkiWeHBBXG5mwa4otuUu+FYErb5yf ePLr1yMqiXF0NtrKHAhayEXE/OEytGZ+NGNRzk4+HprzckiT6ZjfL+nbvIql51XivG6o OOFtUDRPXDTUrXNahwGNyThHmEuRDMFJ5ZYsbiw7I67+S3Zgo44LXir4oHLTq/p/F0Ux 6JSxRf1THElewUEEwjAziMFnR9hgQn+4TUgUfUEIxUWVPrWQ6cQcEuv2oM8MhoRBdWSR Hapg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=AMM15H6JjOFElbnxTgmGX3rlzOj1/by+eFASc1hrh9Q=; b=omWVh9iGb/0T8IFGFKct4pWt4qJekmcw9nPBs/TaEOjYdornbDGnFSz3id+yd2vaNu xyrco1hyHprHeEbZoqIuUbMfOzjFJYkb5Fhc05PtoI3ouhVgsfYkZaucGTFtn+Csmx+0 rWPXOcuml/3uoNGLk6Ii2KWi817iMxVvWT3JjeveM1sWNsc7KiFh4aM9YOZF6sSjhjio o74JBXnCTRhQ/J2yCYRTXDTerCDfr6wOxIjTKGNzfshSguiFT1p4e1sS7zm7Fft4Wemq klw7ncHeECPuvg37KLKPnnBwiBlib6YKj/NkftwAmwZ18V8f0WkQ26SphWGi3Fe+/FqT tneA== X-Gm-Message-State: ANhLgQ1ZA2tQngE420gxeHdm56g17skTPYhHGGL8vPQJlz0d5TzVA92E UVMgu9kpLj8QgTeGznak99WoUjcgh3Q= X-Google-Smtp-Source: ADFU+vtPqaQm7xhFC2huZ2zs1uV98PFCgXj9FS4lCO3SoSZpikXhbdwkSekVZsDEuPnSaR/gOc+cIw== X-Received: by 2002:a1c:7508:: with SMTP id o8mr6221768wmc.141.1584096427669; Fri, 13 Mar 2020 03:47:07 -0700 (PDT) Received: from [192.168.1.189] ([89.21.231.54]) by smtp.gmail.com with ESMTPSA id n1sm34690258wrj.77.2020.03.13.03.47.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2020 03:47:07 -0700 (PDT) To: dev@dpdk.org References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-1-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-3-git-send-email-nicolas.chautru@intel.com> From: Dave Burley Message-ID: <0065dbf2-6312-60be-ca81-fb114ffd81be@accelercomm.com> Date: Fri, 13 Mar 2020 10:47:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1583348102-13253-3-git-send-email-nicolas.chautru@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 02/14] bbdev: expose device HARQ buffer size at device level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: > From: Nic Chautru > > This exposes the HARQ buffer size at the device driver level > instead of using the capability of a specific operation. > > This is currently not yet used by a device until > future commit. > > Signed-off-by: Nic Chautru > --- > drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +- > lib/librte_bbdev/rte_bbdev.h | 2 ++ > lib/librte_bbdev/rte_bbdev_op.h | 2 -- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > index f2fe7a2..6d5e080 100644 > --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c > +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > @@ -219,7 +219,6 @@ struct turbo_sw_queue { > RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE, > .llr_size = 8, > .llr_decimals = 2, > - .harq_memory_size = 0, > .num_buffers_src = > RTE_BBDEV_LDPC_MAX_CODE_BLOCKS, > .num_buffers_hard_out = > @@ -251,6 +250,7 @@ struct turbo_sw_queue { > dev_info->default_queue_conf = default_queue_conf; > dev_info->capabilities = bbdev_capabilities; > dev_info->min_alignment = 64; > + dev_info->harq_buffer_size = 0; > > rte_bbdev_log_debug("got device info from %u\n", dev->data->dev_id); > } > diff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h > index b2da190..38d9d50 100644 > --- a/lib/librte_bbdev/rte_bbdev.h > +++ b/lib/librte_bbdev/rte_bbdev.h > @@ -307,6 +307,8 @@ struct rte_bbdev_driver_info { > bool queue_intr_supported; > /** Minimum alignment of buffers, in bytes */ > uint16_t min_alignment; > + /** HARQ memory available in kB */ > + uint32_t harq_buffer_size; > /** Default queue configuration used if none is supplied */ > struct rte_bbdev_queue_conf default_queue_conf; > /** Device operation capabilities */ > diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h > index 062f9ff..8122089 100644 > --- a/lib/librte_bbdev/rte_bbdev_op.h > +++ b/lib/librte_bbdev/rte_bbdev_op.h > @@ -712,8 +712,6 @@ struct rte_bbdev_op_cap_ldpc_dec { > int8_t llr_size; > /** LLR numbers of decimals bit for arithmetic representation */ > int8_t llr_decimals; > - /** Amount of memory for HARQ in external DDR in MB */ > - uint16_t harq_memory_size; > /** Num input code block buffers */ > uint16_t num_buffers_src; > /** Num hard output code block buffers */