From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 2436F2C10
 for <dev@dpdk.org>; Fri, 18 Nov 2016 16:27:01 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga103.jf.intel.com with ESMTP; 18 Nov 2016 07:27:00 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,510,1473145200"; d="scan'208";a="32854498"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57])
 ([10.237.220.57])
 by orsmga005.jf.intel.com with ESMTP; 18 Nov 2016 07:27:00 -0800
To: Alejandro Lucero <alejandro.lucero@netronome.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>, dev <dev@dpdk.org>
References: <1479481467-29431-1-git-send-email-alejandro.lucero@netronome.com>
 <20161118150433.AD575558B@dpdk.org>
 <CAD+H9919z+wvjdP31kivhNy+tkPCOHULfNBO=Ae0xSdCGAVA8g@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <00696ef7-6fb5-9bb8-5d77-a04d3253f138@intel.com>
Date: Fri, 18 Nov 2016 15:26:59 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAD+H9919z+wvjdP31kivhNy+tkPCOHULfNBO=Ae0xSdCGAVA8g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using
 hardware info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Nov 2016 15:27:02 -0000

On 11/18/2016 3:10 PM, Alejandro Lucero wrote:
> Hi Thomas,
> 
> I got this email when sending a patch some minutes ago.
> 
> The point is I trusted script/checkpatches.sh which did not report those
> warnings.
> Am I doing anything wrong when using checkpatches.sh?
> 
> 
> ---------- Forwarded message ----------
> From: <checkpatch@dpdk.org>
> Date: Fri, Nov 18, 2016 at 3:04 PM
> Subject: |WARNING| [PATCH] nfp: report link speed using hardware info
> To: test-report@dpdk.org
> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
> 
> 
> Test-Label: checkpatch
> Test-Status: WARNING
> http://dpdk.org/patch/17091
> 
> _coding style issues_
> 
> 
> CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible side-effects?
> #53: FILE: drivers/net/nfp/nfp_net.c:806:
> +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))

btw, you can benefit from RTE_DIM:

lib/librte_eal/common/include/rte_common.h:352:
	#define  RTE_DIM(a)      (sizeof (a) / sizeof ((a)[0]))

> 
> CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
> #91: FILE: drivers/net/nfp/nfp_net.c:856:
> +       else {
> +
> 
> total: 0 errors, 0 warnings, 2 checks, 68 lines checked
>