From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54ABF460ED; Wed, 22 Jan 2025 17:16:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21A8D402D5; Wed, 22 Jan 2025 17:16:21 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 8674B402BC for ; Wed, 22 Jan 2025 17:16:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737562580; x=1769098580; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=4K8cO3a6dHPHFIiRjSyPe4hbbTvQhVelBfhQ0wCIlLo=; b=Dx/wzClxjb2gh+8DlXrgm8NHcSYLbMCbmSCKLPy2prJF2GxkiOcsVGgC VE/hD+SRkeoNkOd25gU3QszfMZovgNyeDQPl2/iG0wumHlMZo6+pD9spk zrO9mL2Llh8wDjC/fctBAz/UjMJxvMkzu//FKqMjdr1KnOhIqnsznzqJv PyubYyYTLfrO6YimhU3vCsmKgpp3pfxLfXxrDE/7TvgzNVJg/PnZ8HnQV WKsbbO1y7nhGUUPxgKpNYEOIDJIpeFl/noMKGAL3YF/Rpo6StLxCd/oWi k2Ao5ZYRGEk5e+PKQp4KptmvXVqiQXWmuFdMEIHbHXbTwdhARQ1l+dzNP A==; X-CSE-ConnectionGUID: ttPC/OKrQG2g9MqAp6hf0g== X-CSE-MsgGUID: 0XxT+zmITRGESg/LZ9gG4Q== X-IronPort-AV: E=McAfee;i="6700,10204,11323"; a="37727117" X-IronPort-AV: E=Sophos;i="6.13,225,1732608000"; d="scan'208";a="37727117" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2025 08:16:16 -0800 X-CSE-ConnectionGUID: 6+n//RCnR4myPFZzVG6HQQ== X-CSE-MsgGUID: hXZiXeuEQsiLEfEEfhbegg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,225,1732608000"; d="scan'208";a="107787621" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jan 2025 08:16:09 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Wed, 22 Jan 2025 08:16:08 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Wed, 22 Jan 2025 08:16:08 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Wed, 22 Jan 2025 08:16:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ANXICiODRFJxdI5/GJZyn7FwhTgw+gnGmbwDPfbYmIlixVgsB59gh0Hv45r9RvtF18kGvghnWCdZL4DYK/Ei9WkwjPsTl2m7/KGNhDI+m49cqHbDqVOiprZRMHtZm29KJvlCcjc8A1Ej+PuRq4754ijDcVO1p7L3b6eqMg7DSiWb/l6KvCxVT8omfC3TDfLQ2HHBoLgu9n9OZb9L1fIpqqnGlT2YDCVKLTkHL0kborKsuNHUCV1FZZ9PNMIFnPlfvhDkhH3a8wIkuRvukfRGYoF9x2kyjYlWac/D2JkWLtgChfENHVJuDt+/LQLSPOTfo0YJG47w+0LxV/Vm+vmRiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OMdOmZ8zeuHEbkqZEx//S83vvBipz9eQL0zRIlKo5Dg=; b=FUHYQ5OiF/doeFiXUHxiWkbMdBzFkjxH+CHp+ixBErfmDgBCXlsE7SwLJb97ILFekKtWa9F+gK3BW3TXrgI6Dotfaeb2nLk1eeb1MdYWCAaLX2ZtJEDC4TpoTiU22Dt7Qs2aj0WX1/3ZgNr7cFICO7JTI1uxbrIcSnrbu/qRbZSY7kQK1N7y0zEmPualhAsxgUoTF8Rm3VGB/WekzgDlyOPAoZAZ0c3TAkbjD39b6VTnnhh3NNR6AQ+FkmDCLtkKD4/XZjbc+z/tijtTei1/AFBaMxx2A7jdHkZGbgiwYp6VGZ0PfgDVxKWtMhlizTQ+r5TVek2K1ddk+oUDtFshHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by MW4PR11MB6838.namprd11.prod.outlook.com (2603:10b6:303:213::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.16; Wed, 22 Jan 2025 16:15:22 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b%5]) with mapi id 15.20.8356.020; Wed, 22 Jan 2025 16:15:22 +0000 Message-ID: <006d07d8-7c4a-441b-a1d1-d8aa6002b0bc@intel.com> Date: Wed, 22 Jan 2025 16:15:17 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number To: Andre Muezerie , Yipeng Wang , Sameh Gobriel , "Bruce Richardson" CC: References: <1732758837-6350-1-git-send-email-andremue@linux.microsoft.com> <1732758837-6350-2-git-send-email-andremue@linux.microsoft.com> Content-Language: en-US From: "Medvedkin, Vladimir" In-Reply-To: <1732758837-6350-2-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0265.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::15) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|MW4PR11MB6838:EE_ X-MS-Office365-Filtering-Correlation-Id: a6af4543-6b24-47bb-92dc-08dd3afff8fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MWpyWCttdi9rQmdtbUhLaWxKY3JsMEQ5bWlIVEdiM0xUTmZqSjRCU0QyR3lD?= =?utf-8?B?VC9PREZVazlWWitGQlZZRk9vTXZ5Ylhya2JiR3VMaUsrd29lY2Y1VzNTVHlk?= =?utf-8?B?UWF2YXJ4OWtIK2VlV2pReE5HYTFmUnZWbnF3NGhNclhrQ05Fd0p2OThRNkhC?= =?utf-8?B?V055MDlSc0t2MnAraXhreVZwMmVXVlJhNlE3cHJGaDJ1eFE3TTlsMG9PY3M4?= =?utf-8?B?bFU5SXgzUUhCc3hkenQ1SWs1NjNYbEQ2ZmpDTXA1Q00rbmgxWDRRTVpmaVQ2?= =?utf-8?B?RjArelNNN00vNmxzdnNEYjF0aU1FNmQ3VTA1eFp5TXVZamhueXp6ejFNOW5D?= =?utf-8?B?c3NFYXN0SG1GOCsrRVVMaUdsejRzRjM0QUVYeWFLSDFKUWxuY1pEb3M5U090?= =?utf-8?B?WWEwOFVRUzcxc0NmclZFK2p5YSs3eEVaM0xZeUNrZkVmOWlBLzcyNWs0UjNP?= =?utf-8?B?VTZYMUl1SEFxZ3prTVVNZUovSUR2UzBBT1RMYU9IOWtGR1E5ZFVyS3MwTUpY?= =?utf-8?B?MFozbjVxRUM1THNnYnNwUEduL0RKVitMQlk4K3FPSDd1bzJPOGhBRFlwbE5r?= =?utf-8?B?WjRDYWx5YXpIZUxHTThUcGU5em9HWUJzZWtOa3RaZXZnMkFFYU5xZHZSdThm?= =?utf-8?B?ODhVTndWU1hDd09FR1B4UVlHd3FyR2JEV0lkSVVDeTROck1vbGVKOHNqbnJZ?= =?utf-8?B?K3NNQUZ1UEFxaUlzQS9XQ2VhOXJXeXE4aDJzQ0lWVmtQOUZjUVJQdGh3dVJQ?= =?utf-8?B?a0U2UHVXN0JBVGQrYXN3OFYxWnJoMlhwbWVUREl5ZTQ0V0VsMVJwa0dTN1do?= =?utf-8?B?RFlaR3U4a3RmSEVLUktWNG5OeDBzT3Y2OWpLZlU3bGJmaHZTY3JHVUVoZGxa?= =?utf-8?B?T01hYnNJUGF3Z3dLWGhyL3J0dy9FeENkZWRKZ1J0Q1hCTnJiQmZLRUlpb3Rz?= =?utf-8?B?UVRTK3hxK0hKeU9UV1JkMDBxZW1yOFExZlMwTEZsYXlzSkVQLzhtZ0dwUXls?= =?utf-8?B?QXAxaWkwcm9hcGYzeW1xWWZMd0JYbFAweS9uQ1MxdkhsZ1VPVnpOVml4aXVn?= =?utf-8?B?V2xBZXlvZHdxRGpnbzB0R3ZhakE1eTlqMDVvUllLU2d4T0NrU245TzR1cWZ6?= =?utf-8?B?WEJTTWtJZkZVV2czNjJsTVNOeEYxdk8vQ0JGVExSZDBYcDJDQjJKTW5BV3lN?= =?utf-8?B?MVdnT0w2aGI2TzVXYUJmVG5ZOGlqdmYweUVhWVI5amhXUUo1TEFNRnVqSkJT?= =?utf-8?B?U2MrN2l3UVNHT1cyTVdzUm5aSzYvbzh4R0cxdHV4THlGdFNwaU5Mb2lKMjdJ?= =?utf-8?B?RFd2N0hIN2dTS09MeTZ4RXlGWEVWT0cyN1ZkVURQc1FwVnBTWVdJQnkxSXNZ?= =?utf-8?B?TXBJd05jcExtZGU5cnIvOEZRaUpZTUsyc3pPKzNpYTdvR0lLWUN0Y0hoWGs5?= =?utf-8?B?RC9nV3RVbm1ZZ0lLTVBHUnBkNkEyOHF6c2dHZ2Jsbmt1UUQrMEZpNjJKaXY3?= =?utf-8?B?Mk5RNTN1cWgvaDkwZ3hYcDdUUGJsQmp2RElxWlp5YkJ6ZFpJSnFhZ3Q4SS9m?= =?utf-8?B?bGp4eldqVEUvOFdBUkdjT2VxZEdRem1hZjc3a3YwdjVZMDlzSCs0eVZreDVO?= =?utf-8?B?bVlvcTRadHcyTnkwRExKMHc3VGN6eTQwdm81WmtHcFh6bFQyajY4eHVqT2lq?= =?utf-8?B?dkVLaEM5S2FsaGRDSExzNVN2RkZPNmdGY2pFa2Y1UWNpZXR5UGt3ZktGWVpm?= =?utf-8?B?VnNRQkNpWUFyTjFRWUJIS2hoMmZXbEl3M09JZWlMU2FSQXdUckdreEVQK3ZF?= =?utf-8?B?dHczTmc2REZyd0VyU2lwM3hrTmRKZ1VVQ3VWS0Q1WWpyVWJURGZKbDZPUEoy?= =?utf-8?Q?zvxfXz0nmpokv?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXd1UWV2azhnWFcvbXVhY0hra1N0K3lWUVdkcG5IUmR2azIrMFpnVlFxM2l4?= =?utf-8?B?Q3NUSDZHN3pDVDg3TlVUQjljODdTSkVSRWpHVEUycGU1ZUpSRXZxdFZLRU1M?= =?utf-8?B?SERoL09kbkdETFZpQ2RXUmRqT1hEOW13UHZJQ2swcGlmbmpQRXI0aks3cUk0?= =?utf-8?B?dUpCOW8rZFFVUUE5N1Bpc2JoY1QvZUMxbXJibW5rMklMdTdRT2U0WnFrdzVj?= =?utf-8?B?SFFCUTB5ZWpyU0pPckR6UFN4RTRjSllDQ0t2WFNEZUtlU3FOSWJjU2pObU9W?= =?utf-8?B?ZHFNaThSNk1ULzE4dENrLzc0bGh2SWVobWxsd2lBTnFzRFRnaXIxSnFKamxj?= =?utf-8?B?TUs1cEVSRS9iTEtRWjBmMTBZM012K0lISFcrZGhBWThFY0h2UHFTcmVIOTgr?= =?utf-8?B?V2Y0U3dkaWpqaXpvdFB6cElHRmswZ0pkbXBwZVdUTmUzMGxXYWdBNmR2KzRU?= =?utf-8?B?TUVvNVpkQ1grL3BybUdvaFR1aTZDbkdzMFpyTWZ1VlhkeUFuSkY1THEvMmRy?= =?utf-8?B?dHVvbVlldG1jRHJQYkp3eVdxaUNGNUs0QmlrNHhoS1RPV3FRT3RLZlhNSXlu?= =?utf-8?B?d04wMHpmVURwYmtLV1k1TEgvMGozRzdaNXJPVTFSUGdUNi9aMjV2Tm9TTS9F?= =?utf-8?B?Y1dUTm94VnkxTDJBdjNUSFF6UEp3Y2dpa1RJTll6L2FOODNWUTdMT0hXek1N?= =?utf-8?B?RDdiVnlLTmJYWFVkeUMwSjVBckFyeFVjcTdFT3N6MEkyL0RNMjJxZUhzR09h?= =?utf-8?B?MTYwZERHT0oyQkwzby9haklQbDM0WTlnbklCeUl0OEpoZ1NaV1Rmam1FZ0gy?= =?utf-8?B?MWd2ekhrVE44dUtDNHZVOFl3aFNuQ0IvcXJ4SDFFVUpySkZLRG4wdGFFSk5C?= =?utf-8?B?N2hycm10RVhBV0ZTdzFEaHB3SThaRmhKcEI3MnA0eWFTL2NGd2s2WXcwR2hG?= =?utf-8?B?RGlWU1FmWkZybTd1Mno0a040Yi9JSlFjQ0xZNnBWZFNmempIbnBacWZtR0RT?= =?utf-8?B?dGU0QUpDUHNEU043RXRKOU80SVRnT3VITEtYL2I5a0lETnFoQVE2ZHRWbmlR?= =?utf-8?B?b0k0N1FLRStkdnhMNWNPNEJBZGdaNXhWdm1CL25OSGJSRzFRLy9HRXhuQ3FT?= =?utf-8?B?T2FOYTVoeVZHMFRKOXFkeWd1eExzQTlSaWtEWHNsbGFGS20ydnZhblV6alF6?= =?utf-8?B?SXpraXVqdXU0RWpCeVpoMXd5SVBPVDZNRUxFU2JBZmxpSzErZGRmMk5jTjNB?= =?utf-8?B?RzBsTXpCUytpSGpIVTNnRmNGYnloN2N2Y1gxcXhaTnBJRmQ3a2NZRTVvVjQv?= =?utf-8?B?UFdtci94SkRtYUlSdTVyQ3k5emJlTWV3WVZHdjBkUnNnNUU3bjdON084cVk5?= =?utf-8?B?SFBsemJzbUpZMGhYRkNpd0JGZVBZTExKYUl4bjhwdlcweUpsU1pVaG94ZFBQ?= =?utf-8?B?d3BBYUozR1UwaTdNS3AxQ2FsQW1zdjNnaUlqUHEvakdFYU9PU0ppdk1WMjBi?= =?utf-8?B?VTRnNUNpb2hNSlFuUWJUZmlicTZFcUJlTEhlSFhPV0NGcCs1VStmWmpldmlK?= =?utf-8?B?WnF3UXp2c0ZxY1BiQm1GajhKVS81OURBcUlJTjkrYVhLTEpmZlNlU2g0dHA5?= =?utf-8?B?UFlScXJOV09sNEJmelNubS9RSTRHZmpCZFBMNEZocG1waGh4UktIQnhHcDZ4?= =?utf-8?B?L09STHRQTUVtMS9jNVZlNGlzemd6c1BZTldNWlIvQXM4cWx6UjVSdzlvQzZL?= =?utf-8?B?Q3p1VjBIMnlhOGI1WkVnWUF5ckxlS3o0ZVg3a215aHZQVjRlYXEzekdlVWpQ?= =?utf-8?B?eFptVjhrLzlRbjZ4QUFaUktMVFliYk9UdnZIcXlYUXNxVWZvRE15eUczUm9W?= =?utf-8?B?dElRQnVMV3BucU05ZHFtd1IrbmFiMkNZL2R6dUR0QzZkMzNsdmEvNGVlMlhj?= =?utf-8?B?c3FTTXZoRmNmVHhtNUpVSjdOV3UrUUFxaEhJQk9tb21QU2wrc0NhQVpFYnZ5?= =?utf-8?B?Y1V0b2hvbW01Rm4rS0pJWTR2UzV1ajdzWEtVRUhCYjVmTXQzYThCNWlBcGQ5?= =?utf-8?B?SUQxb0VKRTRPbWduN2RMSXNLWTIxdzhLaFVXMzlUTkVhald3TC9nbWh4U2sz?= =?utf-8?B?d1d1YzhMWll5czlzODl3aVlQMURMampKYXpIejlKU2lYYjc2SFE3OVl6ZjhW?= =?utf-8?B?WlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a6af4543-6b24-47bb-92dc-08dd3afff8fe X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2025 16:15:22.7400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6V3VB01sZXzKMwWcRf04bxwGFYKKIFXrzWrUHc6V755/AcErbpUTwoOMN29TACUpLb6TeIy7qAgj7nYWiLd6VEwHnrsWnkH9F/WzBMp8gIU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6838 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Vladimir Medvedkin On 28/11/2024 01:53, Andre Muezerie wrote: > MSVC issues the warnings below: > > 1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > The code would be better off by using 64 bit numbers to begin with. > That eliminates the need for a conversion to 64 bits later. > > 2) ../lib/hash/rte_thash.c(568): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > 1ULL should be used as the result of the bit shift gets multiplied > by sizeof(uint32_t). > > Signed-off-by: Andre Muezerie > --- > lib/hash/rte_thash.c | 2 +- > lib/hash/rte_thash_gf2_poly_math.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > -- Regards, Vladimir