From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BBE493572 for ; Wed, 3 Oct 2018 10:02:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 01:02:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,335,1534834800"; d="scan'208";a="78308791" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga008.jf.intel.com with ESMTP; 03 Oct 2018 01:02:01 -0700 To: Jerin Jacob , Andrew Rybchenko Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Olivier Matz , dev@dpdk.org, shahafs@mellanox.com References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-2-jerin.jacob@caviumnetworks.com> <20181003075823.GB2003@jerin> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <0079b011-100f-1699-356f-80648abcb36f@intel.com> Date: Wed, 3 Oct 2018 09:02:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181003075823.GB2003@jerin> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 08:02:25 -0000 On 10/3/2018 8:58 AM, Jerin Jacob wrote: > -----Original Message----- >> Date: Wed, 3 Oct 2018 10:41:33 +0300 >> From: Andrew Rybchenko >> To: Jerin Jacob , Wenzhuo Lu >> , Jingjing Wu , Bernard >> Iremonger , John McNamara >> , Marko Kovacevic , >> Thomas Monjalon , Ferruh Yigit >> , Olivier Matz >> CC: dev@dpdk.org, shahafs@mellanox.com >> Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP >> checksum definition >> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 >> Thunderbird/60.0 >> >> External Email >> >> On 10/2/18 10:24 PM, Jerin Jacob wrote: >> >> Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and >> PKT_TX_OUTER_TCP_CKSUM mbuf ol_flags to enable Tx outer UDP >> checksum offload. >> >> PKT_TX_OUTER_UDP_CKSUM, not TCP > > OK > >> >> >> >> >> To use hardware Tx outer UDP checksum offload, the user needs to, >> >> - enable following in mbuff: >> >> >> mbuf > > > OK > >> >> >> a) fill outer_l2_len and outer_l3_len in mbuf >> b) set the PKT_TX_OUTER_UDP_CKSUM flag >> c) set the flag PKT_TX_OUTER_IPV4 or PKT_TX_OUTER_IPV6 >> >> - configure DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slow path >> >> Signed-off-by: Jerin Jacob >> >> The question about mbuf and ethdev changes separation is applicable here as >> well. I have no strong opinion, but I think it would be good to follow. > > I don't have strong opinion on this. If there are no other objection, I > will split the patch further as mbuf and ethdev as you pointed out. Since they are logically related, it make sense to have them together to me.