From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEC5941D9E; Tue, 28 Feb 2023 17:27:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A74EC40EE6; Tue, 28 Feb 2023 17:27:44 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2056.outbound.protection.outlook.com [40.107.92.56]) by mails.dpdk.org (Postfix) with ESMTP id 43D744021F for ; Tue, 28 Feb 2023 17:27:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zqu/3KyT/TAS7IRrc/wYLAyr5zx1SEsJz/NlxxrcT3NprFQtxBJ4nAYapbGMVAqzboW48v+hjGJGrmGQMYF2AEjE6yo1k0pJLNsdqtKE1AbLa0df0m1VJLdAm408VNIk1i9c14cPnW7MURpIgNAiFQBsQhAw97WCPX6l4Fxww5umrVDrfotmCg9qFBL9+VPzHB06tISpOKiiNP0M+QG2nTAWT6FA8XZskK2Hxdt4rkcRjd5fPUAcW5mSEkfKfHHkrapcTDcW5MFEN6tSKYU5DycWGo8UI9Svh3BgDASlB7MmBByRkSgUQw5Op++JkUBnbaNCgzQQoHO+3mMHiistqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mhQmfHUxzJd8me8pe/wd5rlwdP7fV8mTbGFMRkhvR94=; b=U4de8vQTdgg6Whg1sr+j9ks+F5KZhpyQrIGEqGSMyz/kHUwf+/vdv3SXRKhkl+Uol6GIxIANA4FAsaH78gaO2BRFnQ1SoH+FGL8jBOW8eW2w3kyFYCURihY2bv2/AG2xf0uMr5eDSc5msx5sOaE80kvPPcpGxtwUz6EsXIUGLd0FseH+lvN3fRU06b2d0Z5V3V5sNGefinKDg9sE+lloBaeH64UlEwnYviTqI94nJlw6KUWnNGwAUCAMwI94gIKTnLu2QJDo5lp+0YaWbMutwP2hbHgkmRV8Og/bABeHKYzvHCMx8DpdpSu62pOLbdUtXKoGzsluIaJOUg6pVjJpWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mhQmfHUxzJd8me8pe/wd5rlwdP7fV8mTbGFMRkhvR94=; b=d21oFoS773dmUlWUFNS+TjGOCbdW5E81hKWT/LN4yWNPZkCBIpAq9Fao+rMjQZQ8fE9XSjits8q1aK/81YjD8PucclhF/u/4S7MAYJLoy0iNAD1F7ZyTgNEjp1aJAdQjuB/G70QyjnhydzYJ5cVmKUMZkaKH/js+FJRBwO2rpMc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by IA1PR12MB8553.namprd12.prod.outlook.com (2603:10b6:208:44e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 16:27:41 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7%9]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 16:27:41 +0000 Message-ID: <008678c6-580c-af82-3696-23726b225861@amd.com> Date: Tue, 28 Feb 2023 16:27:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [EXT] Re: [PATCH v1 1/2] ethdev: fix null pointer dereference Content-Language: en-US To: Ankur Dwivedi , "dev@dpdk.org" Cc: Jerin Jacob Kollanukkaran References: <20230223123029.2117781-1-adwivedi@marvell.com> <20230223123029.2117781-2-adwivedi@marvell.com> <5b714a8e-1851-d204-18bc-6fe9cd5d5afd@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0025.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::6) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|IA1PR12MB8553:EE_ X-MS-Office365-Filtering-Correlation-Id: 733ccda3-c1d1-4040-b40d-08db19a8b6b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gs10+X+KmvINj71k2aR36pl+JxEG4grn8MwLSG9fCCPmtw3omeuczI0hIDCHB6YOnptOCB1uWqKRe2i5LEV4nyYbQH85LIF7p7ixCzdEiOx1xmB213O/0VrvqVwHJpv/6IkSHLA2ucPcck3pKWOsaJcx91Tj+cJlOIZ+9XnpKyL/WvGVukc+HpqXjQNhul+Ks/gT14XbkNPgSOOz7y48+Rpt4fR1TIfB78Mo4OnqkAMX6LteOv1l3lkBcrVcU2jLYZn4WxDO/PxEd2MwaIlVRtMTMnU4Ggc19vILs9f17AmQR+OrTkV6j1tyYwACzR6s7eQrUTNqjukcUdsjjM2/3gu+YnMSf3g62l92ghDJ/X55D49s36TirY+mSTcNtwWrCICL7Z9AMOPiwcZ7aBkJoxgCxpUZ0xc/3+h57aIcWNunNVbJm22yBED2LIsHmpOJgqs1jIEnw+LkwMapHh4+A0UGBzIyeuamJSsZ3/SPSc5R2Av2bNcMO+PN0WV/i1fKV1SIK7Z1u9vSYlRWlq1P6+XDgB5tmk4tmOuikHjjwg6iNyeR27FCod3d0yZVfKRHkfzqBRpZ7g1njK8nli0W23FcPLzGEnaqRml7GEQSULX2KCW83bJBEH32QAG3byAPasl6Jy6MJLwf/sBxWBPiaH5iqU5lSN+Hk22oKiPeQEe3kustZenoHDBzUQbefxXOjsChpqnlOstjPICG6udNU9jTPFagfxO9eTl4MYV8vQU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(451199018)(31686004)(8936002)(44832011)(5660300002)(31696002)(186003)(26005)(316002)(66556008)(66476007)(8676002)(66946007)(41300700001)(4326008)(2906002)(36756003)(83380400001)(6486002)(110136005)(478600001)(86362001)(6666004)(6506007)(6512007)(53546011)(2616005)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2IzTlc1R3hWUjlFd1lEeTdTbGQzSWtOVTBrSkpDcHErYVk0VkV1WUYrcU83?= =?utf-8?B?VkIvR0E2OUo5Vnh3K0FMS3JRZnRReTdacGVDT0w1aXFUcG5wdEZtWW80NXJW?= =?utf-8?B?akxjNUF4QllNMk5UL2xpU29ab1pUdFBJT3RGY08xNkozRzJpZjRTaFE5N0lu?= =?utf-8?B?akNsc2lDbDBDRmhUN2crclZFT1ZCZGFvQlliczJKQUgvYjFHeHJtMGt1N3l5?= =?utf-8?B?bUMvcFF6VFFnSk9RZHdpUnEyckZTRDhaL0VmZjZVK1FZZXpmTjh2czZyRGVF?= =?utf-8?B?eHNKcnNQS0JDRzRQRzByL0ZkQndEN2lVdnpPcjF2Rk1INEtiVThOY085NHdK?= =?utf-8?B?YWloMEpCdmdpM04xWHRLVTdGRHNhZ0JwcnZQYm1WRDNmNjhWcmx5SGQyK0N4?= =?utf-8?B?UDlkZ09oZzBXNk8zQU0xeVFPdDVwRGNkbTlhSXZuZG5SUDI2THFYclVzbW9F?= =?utf-8?B?MjlVTG1CbXdvMW5kbzlUNXRUWlViSVhacURKeW56QVk3VFNBNkNUZWovNHN1?= =?utf-8?B?L2Q1NmEreFpYbG4reWZvdHkvbGNDWmhiTVVQNENnWkNhY2orVTE5WTlreFlV?= =?utf-8?B?YlRkT1hKZVZHNEVPczAreFdoZTQ1NUVsajdCQmE5V0hCS0tDS1lTTHBVUDJr?= =?utf-8?B?d0lNUTUwMmdkMlNvYmNjR21hWldxaVQ4SFVvTERwZ0FNSHgrWEhPdEs4cHE2?= =?utf-8?B?bkFCeDlFSVFtUG9wSy85d2tBK2swVGlsNUJxY0NCajAydkp4Q1VVa0dFVWQz?= =?utf-8?B?OVY4SHgyUDhobDhSUnAxUW81YjRWK003RTlpS3I1LzFEOXhFVVQ5SEI5SWxm?= =?utf-8?B?WUFFUERtSXZzY2RpaVAreXp4Q2ZTK0J2ODlzd3NMRDlVcFFpSHJ2UmtRZmZp?= =?utf-8?B?VU1MbEZkWkVQdjFxbzJWU3dBaXlmTDhTaHhBVzEwR0dEaVFpMCthaUVvZWtx?= =?utf-8?B?bXZXYmJZeFc1Z3psYUs5MnVxRTlDcjcyV3g5cmNHbnlOek43YTRNMzUwRjRW?= =?utf-8?B?UTNFNmwxaXJxNXVtaDQwQmNla3E4b1kzU2cwRUZGWjZrWHNOaklzeklDdGpz?= =?utf-8?B?SVFVTzVyRmFzV3I5M1BlYWtxK1kyN3VuMkRyRkhmL05oUUJEbyt2TEoyWndu?= =?utf-8?B?Rmg5WktEdlE5SDBkZ2ZoZTU3dzFROGo3RnVrYkc4aXd0SThUaUttNFVFU1hR?= =?utf-8?B?QmEyK2MrbDgrNFRaSXF6ZGV0dFEyYXJ2bGJ2T0FNWXVkaENBMHFlR2UvYi96?= =?utf-8?B?OGY0V1ZjRU42bGJ5VzFNV2F0OVpzL01YSGFMRnlDcUJNWEdNUVJIMnlXaGFC?= =?utf-8?B?ODd5TXFObHhKUEJGQUFJTlhYS0IrTDl2Z1lHbHdYK0wvanljcHJwT3grT2RH?= =?utf-8?B?L2dIVnFheWlGek1iaFVxOGRTUGd2UGRKbCtaRFRLOXdwVXl1cm50bit3OS9H?= =?utf-8?B?SmFja3hHT2h6amUzN1hqM0I2ZkZUOGVQelhqMU9MMVkvSHpHTmY3bDcyZDkx?= =?utf-8?B?WTdWMmdNQWs4RWRId01zcUJOVHkyUDRGcFlzNjBYZXYxWGZkRE5xcDVGR1po?= =?utf-8?B?czcvMkp4QzVLR3NBVnVXMG9pRWZvYnRyNG52RVJuSVFEaTZ3ZGx4SWcyd09r?= =?utf-8?B?eVpxRGRIRkJ2U042R1g5aVQ1NHppZUVsNXhFNWxhdkhreFVudmNZNm5yZE1X?= =?utf-8?B?MFBzSGRtL1BqMDRIUFUzS0JmWnc0N2U1dHJISWh3WGxVZ0pqOEtkL3NQRUZE?= =?utf-8?B?ZG84QnB3RFExYmt5WHROcmRHNUo4cjgxZWM3cFFUdjgwK3M3TUloRldueUpo?= =?utf-8?B?Z2U0YmFWT29WL1NEYm5PNERzdDNsKzlIK0lZSDdYeWFzYmRVNWVHRUtkeGNB?= =?utf-8?B?V29vT1ovRkZMYkVCSndOeE1qUVhaTktnUy80U1FUZVZoQW1pandraUdZd1l3?= =?utf-8?B?QlI5Zm9ad0tZOXRUTE84YkpXUklVNUFrVHhWV05wSUlldUVpU2xmOXhjbHRY?= =?utf-8?B?REVOUUs0LzRyNXpuSGxTdEZPVTk1MUdYV29yQm53NWt0dnBVcEROZm1OSmk4?= =?utf-8?B?bXdCaGxEdUtLRUZsYjk4YVNzRkdVSXNueFZGUmtHYTF5bk1nNWYyblNZYXlD?= =?utf-8?Q?ESMD4PZ0lxHL4AqQ0bcRMeAIH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 733ccda3-c1d1-4040-b40d-08db19a8b6b8 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:27:41.5377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tYL3Hl0f8MIFf0KFHk27rDw6UdE9xnzCF7Y1F57iqbnaDnEGsDqDdbQI+XDG0fCn X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8553 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/28/2023 3:40 PM, Ankur Dwivedi wrote: >> ---------------------------------------------------------------------- >> On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: >>> The speed_fec_capa pointer can be null. So dereferencing the pointer >>> is removed and only the pointer is captured in trace function. >>> Fixed few more trace functions in which null pointer can be dereferenced. >>> >>> Coverity issue: 383238 >>> Bugzilla ID: 1162 >>> Fixes: 6679cf21d608 ("ethdev: add trace points") >>> Fixes: ed04fd4072e9 ("ethdev: add trace points for flow") >>> >> >> In below changes, pointers can be NULL at runtime, so agree on to the change, >> with minor comments please see below. >> >> >> But I don't think this is a fix for Bug 1162, which is an ASan reported error, can >> you please drop that tag unless it is verified. > The asan error reported in 1162 was because of capturing rte_trace_point_emit_string(parent->bus_info); in > rte_eth_trace_find_next_of. I could not find the exact reason for the asan error with parent->bus_info. > > But I think parent pointer can be NULL in rte_eth_find_next_of, so I removed the pointer reference. This resolved the asan error in 1162 as a side effect. > > - rte_trace_point_emit_string(parent->name); > - rte_trace_point_emit_string(parent->bus_info); > - rte_trace_point_emit_int(parent->numa_node); > + rte_trace_point_emit_ptr(parent); > > I will check if I can add an if condition to check if a pointer is NULL inside the trace function. If that works I will update this patch. >> >> <...> >> >>> @@ -2308,8 +2300,7 @@ RTE_TRACE_POINT_FP( >>> int ret), >>> rte_trace_point_emit_u16(port_id); >>> rte_trace_point_emit_ptr(flow); >>> - rte_trace_point_emit_int(action->type); >>> - rte_trace_point_emit_ptr(action->conf); >>> + rte_trace_point_emit_ptr(action); >>> rte_trace_point_emit_ptr(data); >>> rte_trace_point_emit_int(ret); >> >> I think 'rte_flow_trace_create()' is missed, rest looks OK. >> >> Can you please double check 'rte_flow_trace_create()' too? > Yes. Will add rte_flow_trace_create. Can you please check 'rte_eth_trace_read_clock()' too, it has: RTE_TRACE_POINT_ARGS(..., const uint64_t *clk, ...) uint64_t clk_v = *clk; >> >>> ) >>> @@ -2349,14 +2340,8 @@ RTE_TRACE_POINT_FP( >>> const struct rte_flow_indir_action_conf *conf, >>> const struct rte_flow_action *action, >>> const struct rte_flow_action_handle *handle), >>> - uint8_t ingress = conf->ingress; >>> - uint8_t egress = conf->egress; >>> - uint8_t transfer = conf->transfer; >>> - >>> rte_trace_point_emit_u16(port_id); >>> - rte_trace_point_emit_u8(ingress); >>> - rte_trace_point_emit_u8(egress); >>> - rte_trace_point_emit_u8(transfer); >>> + rte_trace_point_emit_ptr(conf); >>> rte_trace_point_emit_ptr(action); >>> rte_trace_point_emit_ptr(handle); >>> ) >> >> This change is different than others, this is removing bitfield related local >> variable assignment. >> >> According to bug 1167 that is causing a crash. So we need a separate patch to >> either remove or fix bitfield related issues, for now I am OK to remove (as >> done above). >> >> But can you please make another patch for bitfield issue and move above >> change to that patch? > > Yes, will move this change to fix bitfield patch. >> >> Thanks, >> ferruh >