From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7504BA04AC; Mon, 24 Aug 2020 09:35:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA31B1C0C2; Mon, 24 Aug 2020 09:34:34 +0200 (CEST) Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) by dpdk.org (Postfix) with ESMTP id D78575F69 for ; Fri, 21 Aug 2020 04:21:53 +0200 (CEST) X-QQ-mid: bizesmtp25t1597976505tl7i1sfx Received: from jiawenwu (unknown [183.129.236.74]) by esmtp10.qq.com (ESMTP) with id ; Fri, 21 Aug 2020 10:21:45 +0800 (CST) X-QQ-SSF: 01400000002000B0C000B00A0000000 X-QQ-FEAT: ttxN9vkG2OS/aTThF1gx2JQKA9ESiUGFdHwRJqK6MXd4hMdmgn6swZpMKgj3w d8JRy24l0iFyaHd6Ye1fJ8EMWMpo8n1msUnXvdn3CrvNkxRxjQdvebPlGZ1yNZNCdefI2ev +0V1ms/3vzJfcva5HZh4roAtpem1i6VHsJXIMKWSazq2PEc7M3/aYIGH1iqndmz7Tj49wOY eR6hMUUja2IhS3xdtRHRugkGkwDCGHGO8ieYv2DfqKLOBdIWjU7e6KE85rgYeJNdzpnY4G6 pNgqsDBTpE+GnvfTHX8ZComzNmKQbKy1om9tKkWUee6Ij/jitFT7gbsgeOf4M4SOM0GrNSQ dfKtqee68ZpL87wWB4= X-QQ-GoodBg: 2 From: To: "'Ferruh Yigit'" , Cc: , References: <20200820030231.1382984-1-jiawenwu@trustnetic.com> In-Reply-To: Date: Fri, 21 Aug 2020 10:21:44 +0800 Message-ID: <008b01d67761$d110cac0$73326040$@trustnetic.com>+5CE999B26764F961 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEqtWxXPBV0hptEKj6a/MU381+bjAHE40K8qosv5GA= Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 X-Mailman-Approved-At: Mon, 24 Aug 2020 09:34:27 +0200 Subject: Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, Thanks for your suggestion. I'll split the patch into a patchset as soon = as possible. -----Original Message----- From: Ferruh Yigit =20 Sent: Thursday, August 20, 2020 7:49 PM To: Jiawen Wu ; dev@dpdk.org Cc: jianwang@trustnetic.com; yuhongzhang@trustnetic.com Subject: Re: [PATCH] net: add a new network PMD named txgbe On 8/20/2020 4:02 AM, Jiawen Wu wrote: > This is a new network PMD named txgbe provides poll mode driver = support for Wangxun 10Gb Ethernet NICs. >=20 > Beijing WangXun Technology Co., Ltd. is a high-tech company = specializing in the design of high-end integrated circuit chips and = providing independent innovation solutions for enterprise network and = storage products. Founded in May 2014, the company is headquartered in = Beijing YuQuanHuiGu Science and Technology Park, with branches in = Hangzhou City. Welcome to reach us on website https://www.net-swift.com. >=20 > This patch is created base on the main branch in main repository. Our = goal is to validate and commit txgbe driver into the 20.11 official = release, and then continue the development and maintenance in community. >=20 > Waiting for your reviews sincerely. >=20 > Signed-off-by: Jiawen Wu Hi Jiawen, Thanks for the patch. Without looking into any detail, a very high level comment is, it is = very hard to review a new PMD (40K+ loc) as a single patch. Can you please split the patch into multiple patches, which gradually = build the PMD by adding a feature with each patch, starting from an = empty skeleton. Last as few upstreamed PMDs as example: ionic: https://patches.dpdk.org/project/dpdk/list/?series=3D8206&state=3D%2A&arc= hive=3Dboth pfe: https://patches.dpdk.org/project/dpdk/list/?series=3D6777&state=3D%2A&arc= hive=3Dboth octeontx2 (one of the good samples I suggest checking): https://patches.dpdk.org/project/dpdk/list/?series=3D5302&state=3D%2A&arc= hive=3Dboth Also you can skip all Makefile build system related changes, since it = will be removed in this release, no need to spend time for it. Thanks, ferruh