From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 72DFAA0A0C;
	Fri,  2 Jul 2021 04:08:15 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 234D940141;
	Fri,  2 Jul 2021 04:08:15 +0200 (CEST)
Received: from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102])
 by mails.dpdk.org (Postfix) with ESMTP id 8B8644003E
 for <dev@dpdk.org>; Fri,  2 Jul 2021 04:08:11 +0200 (CEST)
X-QQ-mid: bizesmtp32t1625191687t0rgedfy
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Fri, 02 Jul 2021 10:08:06 +0800 (CST)
X-QQ-SSF: 01400000002000D0E000B00A0000000
X-QQ-FEAT: vCa7dv7JIu7z8dZyUpxPTwTJuB4zSeszc2Kk/LxqneeUcOx2IjYi3GymTXJ5B
 b6uiCnmNm5GwDftu55hniIsxc8S16X0Jd/NOGU1nSL98jxDFQdoEDTFRh8bZEIdPC3+o6C1
 QaSJFJbnP1mRXJwQZsiJLbzZcqL7qeSz3sHWnOgQ3ucnPgF2zfNeVP2z/F7YW3KH+5yl6LY
 P3mkAfGSLDJgZtMMbgslLZ/M345A3O3mwU6GrOg3x+Sb0vVRktMloZgiFtQpsc5ag2uo5WA
 yhp40W75DZU33sow9k33HJBMlN0svTKvC4UYk+At/CGZKIc5lrDSGyzwXQKahsKDPz1O39l
 IfTkWyCKAFfWBIFEWE=
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'David Marchand'" <david.marchand@redhat.com>
Cc: "'dev'" <dev@dpdk.org>
References: <20210602094108.1575640-1-jiawenwu@trustnetic.com>
 <20210602094108.1575640-6-jiawenwu@trustnetic.com>
 <CAJFAV8wkoJrk=yphKw3Y0t=W=ZEsrxQt6AO_LN4hRbAsNf5Kng@mail.gmail.com>
In-Reply-To: <CAJFAV8wkoJrk=yphKw3Y0t=W=ZEsrxQt6AO_LN4hRbAsNf5Kng@mail.gmail.com>
Date: Fri, 2 Jul 2021 10:08:06 +0800
Message-ID: <009401d76ee7$1931bdf0$4b9539d0$@trustnetic.com>+EA2AD72930ADE975
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQL8bWR0+7rAB5h3oc26F7ZoPPQu9gKc7PwzAKvEABCoyqUP4A==
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign2
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH v5 05/24] net/ngbe: add log type and error
 type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On July 1, 2021 9:57 PM, David Marchand wrote:
> Hello,
>=20
> Currently looking at new drivers posted on the ml.
>=20
>=20
> On Wed, Jun 2, 2021 at 11:40 AM Jiawen Wu <jiawenwu@trustnetic.com>
> wrote:
> > @@ -124,3 +131,12 @@ RTE_PMD_REGISTER_PCI(net_ngbe,
> rte_ngbe_pmd);
> > RTE_PMD_REGISTER_PCI_TABLE(net_ngbe, pci_id_ngbe_map);
> > RTE_PMD_REGISTER_KMOD_DEP(net_ngbe, "* igb_uio | uio_pci_generic |
> > vfio-pci");
> >
> > +RTE_LOG_REGISTER(ngbe_logtype_init, pmd.net.ngbe.init, NOTICE);
> > +RTE_LOG_REGISTER(ngbe_logtype_driver, pmd.net.ngbe.driver, NOTICE);
>=20
> Please use helpers added recently:
> =
https://git.dpdk.org/dpdk/commit/?id=3Deeded2044af5bbe88220120b14933536c
> bb3edb6
>=20
> Converting this patch should be quick:
> RTE_LOG_REGISTER_SUFFIX(ngbe_logtype_init, init, NOTICE)
> RTE_LOG_REGISTER_SUFFIX(ngbe_logtype_driver, driver, NOTICE);
>=20
> etc...
>=20
> > +
> > +#ifdef RTE_ETHDEV_DEBUG_RX
> > +       RTE_LOG_REGISTER(ngbe_logtype_rx, pmd.net.ngbe.rx, DEBUG);
> > +#endif #ifdef RTE_ETHDEV_DEBUG_TX
> > +       RTE_LOG_REGISTER(ngbe_logtype_tx, pmd.net.ngbe.tx, DEBUG);
> > +#endif
>=20
>=20
>=20
> --
> David Marchand

Thanks David,
I'd like to convert it in the patch set v6. And are there any comments =
on other patches?