From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9B56A0C4B; Tue, 15 Jun 2021 09:13:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A88714067A; Tue, 15 Jun 2021 09:13:56 +0200 (CEST) Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by mails.dpdk.org (Postfix) with ESMTP id DBB5140140 for ; Tue, 15 Jun 2021 09:13:54 +0200 (CEST) X-QQ-mid: bizesmtp34t1623741230t7lo1gyp Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Tue, 15 Jun 2021 15:13:49 +0800 (CST) X-QQ-SSF: 01400000000000D0E000B00A0000000 X-QQ-FEAT: g9nl15ZGxlh6lT1Q9VfAdwM0WaFKSCUYzAP53NOQsH+2IuAoppv83DDCj0CD5 sSP8WJZDJjObMBctEQsvEnkHgSF0Zk0DxXm4BFr4g22nhfLp/rY05GFW4kC3isFplVac/Ox Up3Tv+puBA2Hx2wtXxGnB4J6wxk0pE9dZiiYC4ohSJicB/G7wkwThm00/UJxLEHLgFLLOt6 tO+lXNS3HtVZwY2DyVLxMCALHMdH968pqFMhgiwtNidD3trGKYc731Ge/CtT44Qi1+k1Dn4 Xd07nlm/x98PwGEAp/y93aqJE0T5edV4koh6r29Z3CS8TTVu/s45HIpn+YHuXePcPkPCvjF HalpR1+0EgQQVZvoFKzPVRX8BynGA6ErX3LRfFB X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Andrew Rybchenko'" , References: <20210602094108.1575640-1-jiawenwu@trustnetic.com> <20210602094108.1575640-6-jiawenwu@trustnetic.com> <3fb089b1-47c0-0be3-d941-31131b27e597@oktetlabs.ru> In-Reply-To: <3fb089b1-47c0-0be3-d941-31131b27e597@oktetlabs.ru> Date: Tue, 15 Jun 2021 15:13:49 +0800 Message-ID: <009601d761b5$fd650570$f82f1050$@trustnetic.com>+343F174634937FD2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQL8bWR0+7rAB5h3oc26F7ZoPPQu9gKc7PwzAg57/WmopTEmwA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign7 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v5 05/24] net/ngbe: add log type and error type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday, June 15, 2021 1:55 AM, Andrew Rybchenko wrote: > On 6/2/21 12:40 PM, Jiawen Wu wrote: > > Add log type and error type to trace functions. > > > > Signed-off-by: Jiawen Wu > > --- > > doc/guides/nics/ngbe.rst | 20 +++++ > > drivers/net/ngbe/base/ngbe_status.h | 125 > ++++++++++++++++++++++++++++ > > drivers/net/ngbe/base/ngbe_type.h | 1 + > > drivers/net/ngbe/ngbe_ethdev.c | 16 ++++ > > drivers/net/ngbe/ngbe_logs.h | 46 ++++++++++ > > 5 files changed, 208 insertions(+) > > create mode 100644 drivers/net/ngbe/base/ngbe_status.h > > create mode 100644 drivers/net/ngbe/ngbe_logs.h > > > > diff --git a/doc/guides/nics/ngbe.rst b/doc/guides/nics/ngbe.rst = index > > 4ec2623a05..c274a15aab 100644 > > --- a/doc/guides/nics/ngbe.rst > > +++ b/doc/guides/nics/ngbe.rst > > @@ -15,6 +15,26 @@ Prerequisites > > > > - Follow the DPDK :ref:`Getting Started Guide for Linux = ` to > setup the basic DPDK environment. > > >=20 > It should be two empty lines before section start. >=20 > > +Pre-Installation Configuration > > +------------------------------ > > + > > +Dynamic Logging Parameters > > +~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +One may leverage EAL option "--log-level" to change default levels > > +for the log types supported by the driver. The option is used with = an > > +argument typically consisting of two parts separated by a colon. > > + > > +NGBE PMD provides the following log types available for control: > > + > > +- ``pmd.net.ngbe.driver`` (default level is **notice**) > > + > > + Affects driver-wide messages unrelated to any particular devices. > > + > > +- ``pmd.net.ngbe.init`` (default level is **notice**) > > + > > + Extra logging of the messages during PMD initialization. > > + >=20 > Same here. >=20 > > Driver compilation and testing > > ------------------------------ > > > > diff --git a/drivers/net/ngbe/base/ngbe_status.h > > b/drivers/net/ngbe/base/ngbe_status.h > > new file mode 100644 > > index 0000000000..b1836c6479 > > --- /dev/null > > +++ b/drivers/net/ngbe/base/ngbe_status.h > > @@ -0,0 +1,125 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2018-2020 Beijing WangXun Technology Co., Ltd. > > + * Copyright(c) 2010-2017 Intel Corporation */ > > + > > +#ifndef _NGBE_STATUS_H_ > > +#define _NGBE_STATUS_H_ > > + > > +/* Error Codes: > > + * common error > > + * module error(simple) > > + * module error(detailed) > > + * > > + * (-256, 256): reserved for non-ngbe defined error code */ = #define > > +TERR_BASE (0x100) enum ngbe_error { > > + TERR_NULL =3D TERR_BASE, > > + TERR_ANY, > > + TERR_NOSUPP, > > + TERR_NOIMPL, > > + TERR_NOMEM, > > + TERR_NOSPACE, > > + TERR_NOENTRY, > > + TERR_CONFIG, > > + TERR_ARGS, > > + TERR_PARAM, > > + TERR_INVALID, > > + TERR_TIMEOUT, > > + TERR_VERSION, > > + TERR_REGISTER, > > + TERR_FEATURE, > > + TERR_RESET, > > + TERR_AUTONEG, > > + TERR_MBX, > > + TERR_I2C, > > + TERR_FC, > > + TERR_FLASH, > > + TERR_DEVICE, > > + TERR_HOSTIF, > > + TERR_SRAM, > > + TERR_EEPROM, > > + TERR_EEPROM_CHECKSUM, > > + TERR_EEPROM_PROTECT, > > + TERR_EEPROM_VERSION, > > + TERR_MAC, > > + TERR_MAC_ADDR, > > + TERR_SFP, > > + TERR_SFP_INITSEQ, > > + TERR_SFP_PRESENT, > > + TERR_SFP_SUPPORT, > > + TERR_SFP_SETUP, > > + TERR_PHY, > > + TERR_PHY_ADDR, > > + TERR_PHY_INIT, > > + TERR_FDIR_CMD, > > + TERR_FDIR_REINIT, > > + TERR_SWFW_SYNC, > > + TERR_SWFW_COMMAND, > > + TERR_FC_CFG, > > + TERR_FC_NEGO, > > + TERR_LINK_SETUP, > > + TERR_PCIE_PENDING, > > + TERR_PBA_SECTION, > > + TERR_OVERTEMP, > > + TERR_UNDERTEMP, > > + TERR_XPCS_POWERUP, > > +}; > > + > > +/* WARNING: just for legacy compatibility */ #define > > +NGBE_NOT_IMPLEMENTED 0x7FFFFFFF > > +#define NGBE_ERR_OPS_DUMMY 0x3FFFFFFF > > + > > +/* Error Codes */ > > +#define NGBE_ERR_EEPROM -(TERR_BASE + 1) > > +#define NGBE_ERR_EEPROM_CHECKSUM -(TERR_BASE + 2) > > +#define NGBE_ERR_PHY -(TERR_BASE + 3) > > +#define NGBE_ERR_CONFIG -(TERR_BASE + 4) > > +#define NGBE_ERR_PARAM -(TERR_BASE + 5) > > +#define NGBE_ERR_MAC_TYPE -(TERR_BASE + 6) > > +#define NGBE_ERR_UNKNOWN_PHY -(TERR_BASE + 7) > > +#define NGBE_ERR_LINK_SETUP -(TERR_BASE + 8) > > +#define NGBE_ERR_ADAPTER_STOPPED -(TERR_BASE + 9) > > +#define NGBE_ERR_INVALID_MAC_ADDR -(TERR_BASE + 10) > > +#define NGBE_ERR_DEVICE_NOT_SUPPORTED -(TERR_BASE + 11) > > +#define NGBE_ERR_MASTER_REQUESTS_PENDING -(TERR_BASE + 12) > > +#define NGBE_ERR_INVALID_LINK_SETTINGS -(TERR_BASE + 13) > > +#define NGBE_ERR_AUTONEG_NOT_COMPLETE -(TERR_BASE + 14) > > +#define NGBE_ERR_RESET_FAILED -(TERR_BASE + 15) > > +#define NGBE_ERR_SWFW_SYNC -(TERR_BASE + 16) > > +#define NGBE_ERR_PHY_ADDR_INVALID -(TERR_BASE + 17) > > +#define NGBE_ERR_I2C -(TERR_BASE + 18) > > +#define NGBE_ERR_SFP_NOT_SUPPORTED -(TERR_BASE + 19) > > +#define NGBE_ERR_SFP_NOT_PRESENT -(TERR_BASE + 20) > > +#define NGBE_ERR_SFP_NO_INIT_SEQ_PRESENT -(TERR_BASE + 21) > > +#define NGBE_ERR_NO_SAN_ADDR_PTR -(TERR_BASE + 22) > > +#define NGBE_ERR_FDIR_REINIT_FAILED -(TERR_BASE + 23) > > +#define NGBE_ERR_EEPROM_VERSION -(TERR_BASE + 24) > > +#define NGBE_ERR_NO_SPACE -(TERR_BASE + 25) > > +#define NGBE_ERR_OVERTEMP -(TERR_BASE + 26) > > +#define NGBE_ERR_FC_NOT_NEGOTIATED -(TERR_BASE + 27) > > +#define NGBE_ERR_FC_NOT_SUPPORTED -(TERR_BASE + 28) > > +#define NGBE_ERR_SFP_SETUP_NOT_COMPLETE -(TERR_BASE + 30) > > +#define NGBE_ERR_PBA_SECTION -(TERR_BASE + 31) > > +#define NGBE_ERR_INVALID_ARGUMENT -(TERR_BASE + 32) > > +#define NGBE_ERR_HOST_INTERFACE_COMMAND -(TERR_BASE + 33) > > +#define NGBE_ERR_OUT_OF_MEM -(TERR_BASE + 34) > > +#define NGBE_ERR_FEATURE_NOT_SUPPORTED -(TERR_BASE + 36) > > +#define NGBE_ERR_EEPROM_PROTECTED_REGION -(TERR_BASE + 37) > > +#define NGBE_ERR_FDIR_CMD_INCOMPLETE -(TERR_BASE + 38) > > +#define NGBE_ERR_FW_RESP_INVALID -(TERR_BASE + 39) > > +#define NGBE_ERR_TOKEN_RETRY -(TERR_BASE + 40) > > +#define NGBE_ERR_FLASH_LOADING_FAILED -(TERR_BASE + 41) > > + > > +#define NGBE_ERR_NOSUPP -(TERR_BASE + 42) > > +#define NGBE_ERR_UNDERTEMP -(TERR_BASE + 43) > > +#define NGBE_ERR_XPCS_POWER_UP_FAILED -(TERR_BASE + 44) > > +#define NGBE_ERR_PHY_INIT_NOT_DONE -(TERR_BASE + 45) > > +#define NGBE_ERR_TIMEOUT -(TERR_BASE + 46) > > +#define NGBE_ERR_REGISTER -(TERR_BASE + 47) > > +#define NGBE_ERR_MNG_ACCESS_FAILED -(TERR_BASE + 49) > > +#define NGBE_ERR_PHY_TYPE -(TERR_BASE + 50) > > +#define NGBE_ERR_PHY_TIMEOUT -(TERR_BASE + 51) >=20 > Not sure that I understand how above define are related to logging. Above redundant code was not handled properly in the early. I'll remove enum ngbe_error, and use above macro defines to return = different errors.