From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8E21CA0C49;
	Tue, 15 Jun 2021 09:50:52 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4E0954067A;
	Tue, 15 Jun 2021 09:50:52 +0200 (CEST)
Received: from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102])
 by mails.dpdk.org (Postfix) with ESMTP id B73EC40140
 for <dev@dpdk.org>; Tue, 15 Jun 2021 09:50:50 +0200 (CEST)
X-QQ-mid: bizesmtp42t1623743445t5j5yi05
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Tue, 15 Jun 2021 15:50:45 +0800 (CST)
X-QQ-SSF: 01400000000000D0E000B00A0000000
X-QQ-FEAT: O9RHVi+JMbJ8r4n0i20oSf83gz5Uj81DFm8aV0EmBAKqC+TyKfD+k3Q8mcAfE
 U2t+pEm9AzuCcBOlfyWqKfM0K2coAMiEpmgRSsslvO1wE1dnuQhBDErZ3HW5OhpYKvA9RXv
 Kw+bh/wBSaJWT61JZ/d6JFtQY3M/zn/z8Lp2anXYh7qoTZV6GZUjc2J0qzVg5eUrv8lVcd5
 41nN4bfGEwbCxsJJ16Ts52RNMUF0qimDwOAdQ4cvT1uBbKvU3AtLvD1I96FxycfCB44y851
 mSWhcOTHFshasJo3jhDwBKwOn4OaF/3xjNHOx79HWCDSAZ87ZY92tUoogI3pAxGKzW7d4V6
 gsOr9X8k/0ddNOzQG7tdxKHKxT7ow==
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Rybchenko'" <andrew.rybchenko@oktetlabs.ru>,
	<dev@dpdk.org>
References: <20210602094108.1575640-1-jiawenwu@trustnetic.com>
 <20210602094108.1575640-16-jiawenwu@trustnetic.com>
 <fd388ca4-cd12-17f6-6e27-e6feaa01df52@oktetlabs.ru>
In-Reply-To: <fd388ca4-cd12-17f6-6e27-e6feaa01df52@oktetlabs.ru>
Date: Tue, 15 Jun 2021 15:50:44 +0800
Message-ID: <009701d761bb$26284170$7278c450$@trustnetic.com>+FB6D4C9603E03422
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQL8bWR0+7rAB5h3oc26F7ZoPPQu9gHTtsWWAus5o12opKGicA==
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH v5 15/24] net/ngbe: add Rx queue setup and
 release
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tuesday, June 15, 2021 2:53 AM, Andrew Rybchenko wrote:
> On 6/2/21 12:40 PM, Jiawen Wu wrote:
> > Setup device Rx queue and release Rx queue.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > ---
> >   drivers/net/ngbe/ngbe_ethdev.c |   9 +
> >   drivers/net/ngbe/ngbe_ethdev.h |   8 +
> >   drivers/net/ngbe/ngbe_rxtx.c   | 305
> +++++++++++++++++++++++++++++++++
> >   drivers/net/ngbe/ngbe_rxtx.h   |  90 ++++++++++
> >   4 files changed, 412 insertions(+)
> >
> > diff --git a/drivers/net/ngbe/ngbe_rxtx.h
> > b/drivers/net/ngbe/ngbe_rxtx.h index 39011ee286..e1676a53b4 100644
> > --- a/drivers/net/ngbe/ngbe_rxtx.h
> > +++ b/drivers/net/ngbe/ngbe_rxtx.h
> > @@ -6,7 +6,97 @@
> >   #ifndef _NGBE_RXTX_H_
> >   #define _NGBE_RXTX_H_
> >
> > =
+/***********************************************************************=
******
> > + * Receive Descriptor
> > + =
*************************************************************************=
****/
> > +struct ngbe_rx_desc {
> > +	struct {
> > +		union {
> > +			__le32 dw0;
>=20
> rte_* types shuld be used

I don't quite understand, should '__le32' be changed to 'rte_*' type?

>=20
> > +			struct {
> > +				__le16 pkt;
> > +				__le16 hdr;
> > +			} lo;
> > +		};
> > +		union {
> > +			__le32 dw1;
> > +			struct {
> > +				__le16 ipid;
> > +				__le16 csum;
> > +			} hi;
> > +		};
> > +	} qw0; /* also as r.pkt_addr */
> > +	struct {
> > +		union {
> > +			__le32 dw2;
> > +			struct {
> > +				__le32 status;
> > +			} lo;
> > +		};
> > +		union {
> > +			__le32 dw3;
> > +			struct {
> > +				__le16 len;
> > +				__le16 tag;
> > +			} hi;
> > +		};
> > +	} qw1; /* also as r.hdr_addr */
> > +};
> > +