From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6A511A0547;
	Thu, 29 Apr 2021 12:52:30 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 21DFE41194;
	Thu, 29 Apr 2021 12:52:30 +0200 (CEST)
Received: from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105])
 by mails.dpdk.org (Postfix) with ESMTP id DB45441125
 for <dev@dpdk.org>; Thu, 29 Apr 2021 12:52:27 +0200 (CEST)
X-QQ-mid: bizesmtp14t1619693543tbf43u5f
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Thu, 29 Apr 2021 18:52:22 +0800 (CST)
X-QQ-SSF: 01400000000000D0E000000A0000000
X-QQ-FEAT: 8oHFcAoL8WMOSKqln/zZnEul5FHsYoq7ZhfbIL8KtNmGK8bgiIQi9mY3R8qIs
 pqYl58lDBMKRr+Pl7bMBdIvzQFzH3VMqODtDMyhLUmC43P5ymy8ZKf7mUqWGYGsqag9ctuf
 5QOuhF+DPKGALDLZ9QkXsycjUBIerlrItI6x9J1pfHBqBP+O6Bx5xbwkPaaVl6ZDVNHv1qe
 fXdxGKQYn7lnbdtKsl2/z7OSguoJM7XzNrtfpM7xPImBXWTYXix06GpAN3c4otwBvxETtwb
 1ZfxvdvLCr5T9gn6qth86rKk/oc6ituwtMJjZwbCClfkddo25QNiMZKFAG7u6m7+msoyO7j
 1SYMcfpHPFC2aRorGQ=
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@intel.com>,
	<dev@dpdk.org>
References: <20210406093048.2923172-1-jiawenwu@trustnetic.com>
 <4aa70553-97bd-94a0-883f-5c1ce99e7ea8@intel.com>
In-Reply-To: <4aa70553-97bd-94a0-883f-5c1ce99e7ea8@intel.com>
Date: Thu, 29 Apr 2021 18:52:22 +0800
Message-ID: <009f01d73ce5$bc3694f0$34a3bed0$@trustnetic.com>+218CEA0BD2AB8BFD
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQJMBoPAcLWHkqHF0bHoLcUjgSza5QHMxuLFqb0hecA=
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH v4 0/6] net: ngbe PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Friday, April 9, 2021 10:47 PM, Ferruh Yigit wrote:
> On 4/6/2021 10:30 AM, Jiawen Wu wrote:
> > This patch set provides a skeleton of ngbe PMD, which adapted to
> > Wangxun WX1860 series NICs.
> >
> > v4:
> > - Fix compile error.
> >
> > v3:
> > - Use rte_ether functions to define marcos.
> >
> > v2:
> > - Correct some clerical errors.
> > - Use ethdev debug flags instead of driver own.
> >
> > Jiawen Wu (6):
> >    net/ngbe: add build and doc infrastructure
> >    net/ngbe: add device IDs
> >    net/ngbe: support probe and remove
> >    net/ngbe: add device init and uninit
> >    net/ngbe: add log type and error type
> >    net/ngbe: define registers
> >
>=20
> Hi Jiawen,
>=20
> I put some comments on some patches, but as far as I can see the =
device is not
> functional yet after this set, I assume rest of the support will be =
submitted
> later.
> But I think the device should have at least bare minimum functionality =
when it
> is upstreamed, like proper device initialization and primitive Rx/Tx, =
also it would
> be good to have basic control functions.
> More control and datapath functionality can be added gradually later.
>=20
> What do you think extending this set to have base minimum =
functionality?
>=20
> Thanks,
> ferruh

Hi Ferruh,

Unfortunately, this driver may not be merged in 21.05, to follow the =
roadmap.
There is not enough time for me to improve the patches, because I was =
busy with other works in these weeks.

I'll try my best to submit the driver in this release cycle, and hope it =
will be merged nicely in next release.

Thanks.