From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E7F2A04B8; Tue, 12 Nov 2019 09:03:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E07AD2BF3; Tue, 12 Nov 2019 09:03:12 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6D4C02BF1 for ; Tue, 12 Nov 2019 09:03:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 00:03:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,295,1569308400"; d="scan'208";a="287469785" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 12 Nov 2019 00:03:08 -0800 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 00:03:08 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 00:03:08 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Tue, 12 Nov 2019 16:03:06 +0800 From: "Wang, ShougangX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Yang, Qiming" , "Xing, Beilei" Thread-Topic: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile Thread-Index: AQHVmShJODAkRa1MWEKDWP46tUWucKeGo08AgACJK/A= Date: Tue, 12 Nov 2019 08:03:05 +0000 Message-ID: <00A8E5A1740DFA49A87AFFAC34B8EDEA3BFB45@SHSMSX101.ccr.corp.intel.com> References: <20191107022217.41046-1-shougangx.wang@intel.com> <20191112005056.30805-1-shougangx.wang@intel.com> <20191112005056.30805-3-shougangx.wang@intel.com> <039ED4275CED7440929022BC67E7061153DC82FF@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153DC82FF@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Qi > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, November 12, 2019 3:51 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Yang, Qiming ; Xing, Beilei > ; Wang, ShougangX > Subject: RE: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profi= le >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Wang ShougangX > > Sent: Tuesday, November 12, 2019 8:51 AM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Xing, Beilei > > ; Wang, ShougangX > > Subject: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR > > profile > > > > The removal of FDIR profile should start from > > ICE_FLTR_PTYPE_NONF_IPV4_UDP. > > > > Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") > > > > Signed-off-by: Wang ShougangX > > --- > > drivers/net/ice/ice_fdir_filter.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ice/ice_fdir_filter.c > > b/drivers/net/ice/ice_fdir_filter.c > > index a89c506c0..f728b9062 100644 > > --- a/drivers/net/ice/ice_fdir_filter.c > > +++ b/drivers/net/ice/ice_fdir_filter.c > > @@ -571,7 +571,7 @@ ice_fdir_prof_rm_all(struct ice_pf *pf) { > > enum ice_fltr_ptype ptype; > > > > - for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE; > > + for (ptype =3D ICE_FLTR_PTYPE_NONF_IPV4_UDP; >=20 > Is "ptype =3D ICE_FLTR_PTYPE_NONF_NONE + 1" better?, so we don't need to > worry profile be re-ordered or new one be inserted in future. yes, it is better. I will change it in next version. Thank you very much. >=20 >=20 > > ptype < ICE_FLTR_PTYPE_MAX; > > ptype++) { > > ice_fdir_prof_rm(pf, ptype, false); > > -- > > 2.17.1 Thanks. Shougang