From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E02FFA04C7; Thu, 21 Nov 2019 06:43:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0635B2BA2; Thu, 21 Nov 2019 06:43:11 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1C12C271 for ; Thu, 21 Nov 2019 06:43:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 21:43:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="381619626" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 20 Nov 2019 21:43:08 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 21:43:08 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 21:43:08 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 13:43:06 +0800 From: "Wang, ShougangX" To: "Ye, Xiaolong" , "Sun, GuinanX" CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Yang, Qiming" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix qos sched sample app performance drop Thread-Index: AQHVn4Bhh99I0tXc3Ui7CBi9RtVkWaeTohKAgAF1LSA= Date: Thu, 21 Nov 2019 05:43:06 +0000 Message-ID: <00A8E5A1740DFA49A87AFFAC34B8EDEA3C2414@SHSMSX101.ccr.corp.intel.com> References: <20191120080743.26405-1-shougangx.wang@intel.com> <20191120150257.GE103671@intel.com> In-Reply-To: <20191120150257.GE103671@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix qos sched sample app performance drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xiaolong > -----Original Message----- [snip] > >+static void ixgbe_dev_macsec_init(struct rte_eth_dev *dev); > >+ > > /* > > * Define VF Stats MACRO for Non "cleared on read" register > > */ > >@@ -1095,6 +1097,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, > >void *init_params __rte_unused) > > > > PMD_INIT_FUNC_TRACE(); > > > >+ ixgbe_dev_macsec_init(eth_dev); >=20 > This is not needed as dev_private is allocated by rte_zmalloc_socket. >=20 OK, I will remove it. > >+ > > eth_dev->dev_ops =3D &ixgbe_eth_dev_ops; > > eth_dev->rx_pkt_burst =3D &ixgbe_recv_pkts; > > eth_dev->tx_pkt_burst =3D &ixgbe_xmit_pkts; @@ -2545,7 +2549,7 @@ > >ixgbe_dev_start(struct rte_eth_dev *dev) > > uint32_t *link_speeds; > > struct ixgbe_tm_conf *tm_conf =3D > > IXGBE_DEV_PRIVATE_TO_TM_CONF(dev->data->dev_private); > >- struct ixgbe_macsec_setting *macsec_ctrl =3D > >+ struct ixgbe_macsec_setting *macsec_setting =3D > > IXGBE_DEV_PRIVATE_TO_MACSEC_SETTING(dev->data- > >dev_private); > > > > PMD_INIT_FUNC_TRACE(); > >@@ -2799,9 +2803,11 @@ ixgbe_dev_start(struct rte_eth_dev *dev) > > */ > > ixgbe_dev_link_update(dev, 0); > > > >- /* setup the macsec ctrl register */ > >- ixgbe_dev_macsec_register_enable(dev, macsec_ctrl); > >- > >+ /* setup the macsec setting register */ > >+ if (macsec_setting->encrypt_en !=3D 0 || > >+ macsec_setting->replayprotect_en !=3D 0) { > >+ ixgbe_dev_macsec_register_enable(dev, macsec_setting); > >+ } >=20 > Can we safely assume that if encrypt_en and replayprotect_en equals zero, > then we don't need to call ixgbe_dev_macsec_register_enable at all? Since= this > enable routine is more about just encrypt_en/replayprotect_en, is that an= y > usercase when user set macsec offload with both encrypt_en and > replayprotect_en are 0? >=20 As you said, this is a problem. I will fix it. Thanks a lot. Thanks. Shougang=20