From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BB9E0A0A0C;
	Mon,  5 Jul 2021 04:53:00 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6640940686;
	Mon,  5 Jul 2021 04:53:00 +0200 (CEST)
Received: from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102])
 by mails.dpdk.org (Postfix) with ESMTP id CFCED40141
 for <dev@dpdk.org>; Mon,  5 Jul 2021 04:52:57 +0200 (CEST)
X-QQ-mid: bizesmtp38t1625453570tkejcq0n
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Mon, 05 Jul 2021 10:52:50 +0800 (CST)
X-QQ-SSF: 01400000000000D0E000B00A0000000
X-QQ-FEAT: yN/ROybvCA5tERg8s0U5CBTZC0/mh1UnspzHjnQnoipUecLFz4vRNaZ7tyobq
 JfAfpK9P70rtjz+q0LbaN5Sy7xeuwwM1U/56+h0rRNrAeq561Z/6PhtCHrC9D0qPAG8sX+N
 xgBZ5TytkzLe+newb0MT9Dmzs6F+ZtwqiQusqoqJZiNm1Idjt5EHkFCfv0FzhG8D3aAO81y
 Ei5IZ/oyWRl/5UFnbk2aAMHOs2tJrLoG1n8ADeWnoQ2PAODxQoHCoybrwLD/4nxlk96+Bo1
 PpcwHnkzWBuDTg84rL4k/Tss6aub/NeduNj4IShOQ1AGI/4KzcIoPBAkP1pezxev+HvWO3s
 YICECtS
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Rybchenko'" <andrew.rybchenko@oktetlabs.ru>,
	<dev@dpdk.org>
References: <20210617110005.4132926-1-jiawenwu@trustnetic.com>
 <20210617110005.4132926-2-jiawenwu@trustnetic.com>
 <6f16fa58-5f1f-d27a-4550-6d79634123c1@oktetlabs.ru>
In-Reply-To: <6f16fa58-5f1f-d27a-4550-6d79634123c1@oktetlabs.ru>
Date: Mon, 5 Jul 2021 10:52:49 +0800
Message-ID: <00a301d77148$d81d1e90$88575bb0$@trustnetic.com>+9EC7D1C1E7A07C3B
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQEx9tyhu8851cQlQUtl5PIyQvroAQLHHRKWAsXfJNKsUjVoMA==
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign7
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH v6 01/19] net/ngbe: add build and doc
 infrastructure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On July 2, 2021 9:08 PM, Andrew Rybchenko wrote:
> On 6/17/21 1:59 PM, Jiawen Wu wrote:
> > Adding bare minimum PMD library and doc build infrastructure and claim
> > the maintainership for ngbe PMD.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> 
> Just one nit below.
> 
> [snip]
> 
> > diff --git a/drivers/net/ngbe/ngbe_ethdev.c
> > b/drivers/net/ngbe/ngbe_ethdev.c new file mode 100644 index
> > 0000000000..f8e19066de
> > --- /dev/null
> > +++ b/drivers/net/ngbe/ngbe_ethdev.c
> > @@ -0,0 +1,29 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(c) 2018-2020 Beijing WangXun Technology Co., Ltd.
> > + * Copyright(c) 2010-2017 Intel Corporation  */
> > +
> > +#include <errno.h>
> > +#include <rte_common.h>
> > +#include <ethdev_pci.h>
> > +
> > +static int
> > +eth_ngbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
> > +		struct rte_pci_device *pci_dev)
> > +{
> > +	RTE_SET_USED(pci_dev);
> > +	return -EINVAL;
> > +}
> > +
> > +static int eth_ngbe_pci_remove(struct rte_pci_device *pci_dev) {
> > +	RTE_SET_USED(pci_dev);
> > +	return -EINVAL;
> > +}
> 
> Why is different style of unused suppression is used
> above: __rte_unused vs RTE_SET_USED'?
> 
> [snip]

I guess, 'pci_drv' will not be used in future implement the probe function.
So I just gave '__rte_unused' when I separated the patches.
Does this have to be corrected?