From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: fix potential out of bounds read
Date: Fri, 19 Apr 2019 10:43:58 +0100 [thread overview]
Message-ID: <00a34b29-eedb-cef4-3035-03a615125935@intel.com> (raw)
In-Reply-To: <cd164cff-35df-d58c-cb5b-73d50c3c9fe8@gmail.com>
On 4/18/2019 11:57 PM, Chas Williams wrote:
>
>
> On 4/18/19 2:41 PM, Ferruh Yigit wrote:
>> On 4/17/2019 3:36 PM, Radu Nicolau wrote:
>>> Add validation to pointer constructed from the IPv4 header length
>>> in order to prevent malformed packets from generating a potential
>>> out of bounds memory read.
>>>
>>> Fixes: 09150784a776 ("net/bonding: burst mode hash calculation")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>>
>> Hi Chas,
>>
>> Do you have any objection on the patch?
>> Functionally looks correct to me, but additional checks in datapath perhaps can
>> be a concern, if not I am for getting the patch.
>
> I don't think the calculation is a huge concern.
>
> Acked-by: Chas Williams <chas3@att.com>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2019-04-19 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 9:27 [dpdk-dev] [PATCH] " Radu Nicolau
2019-04-15 9:27 ` Radu Nicolau
2019-04-16 16:07 ` Ferruh Yigit
2019-04-16 16:07 ` Ferruh Yigit
2019-04-17 9:33 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2019-04-17 9:33 ` Radu Nicolau
2019-04-17 14:25 ` Ferruh Yigit
2019-04-17 14:25 ` Ferruh Yigit
2019-04-17 14:36 ` [dpdk-dev] [PATCH v3] " Radu Nicolau
2019-04-17 14:36 ` Radu Nicolau
2019-04-18 18:41 ` Ferruh Yigit
2019-04-18 18:41 ` Ferruh Yigit
2019-04-18 22:57 ` Chas Williams
2019-04-18 22:57 ` Chas Williams
2019-04-19 9:43 ` Ferruh Yigit [this message]
2019-04-19 9:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00a34b29-eedb-cef4-3035-03a615125935@intel.com \
--to=ferruh.yigit@intel.com \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).