From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BAC1C271 for ; Mon, 11 Dec 2017 11:48:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 02:48:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="1833739" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.36]) ([10.237.220.36]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2017 02:48:40 -0800 To: Marko Kovacevic , dev@dpdk.org References: <20171128132203.43181-1-marko.kovacevic@intel.com> <20171128132203.43181-4-marko.kovacevic@intel.com> From: "Hunt, David" Message-ID: <00a8ba24-cff4-f88b-f5a7-bcb02d744c5e@intel.com> Date: Mon, 11 Dec 2017 10:48:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171128132203.43181-4-marko.kovacevic@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 4/4] power: clean up of power common header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 10:48:43 -0000 Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: > Signed-off-by: Marko Kovacevic > --- > lib/librte_power/power_acpi_cpufreq.c | 2 +- > lib/librte_power/{rte_power_common.h => power_common.h} | 6 +++--- > lib/librte_power/rte_power.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > rename lib/librte_power/{rte_power_common.h => power_common.h} (95%) > > diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c > index 165ec97..fd1931f 100644 > --- a/lib/librte_power/power_acpi_cpufreq.c > +++ b/lib/librte_power/power_acpi_cpufreq.c > @@ -45,7 +45,7 @@ > #include > > #include "power_acpi_cpufreq.h" > -#include "rte_power_common.h" > +#include "power_common.h" > > #ifdef RTE_LIBRTE_POWER_DEBUG > #define POWER_DEBUG_TRACE(fmt, args...) do { \ > diff --git a/lib/librte_power/rte_power_common.h b/lib/librte_power/power_common.h > similarity index 95% > rename from lib/librte_power/rte_power_common.h > rename to lib/librte_power/power_common.h > --snip-- Could I suggest adding the following into the commit message? "Rename private header file rte_power_common.h to power_common.h to prevent private functions from leaking into the documentation." Apart from that, if you make those changes, you can include my Ack in the next revision. Series-Acked-By: David Hunt