From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C43AA052A; Tue, 26 Jan 2021 16:41:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9BCB140DE5; Tue, 26 Jan 2021 16:41:33 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id DAB46140DE3 for ; Tue, 26 Jan 2021 16:41:32 +0100 (CET) IronPort-SDR: hRSrP0REyOvx0PL7fxHeYPmIfHLOxiUzUqt05uu7oJ1GjShjwjuwqJqdIZ+7Qh+PlYgEvwIhg9 zEeMVk2LJHwA== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="176409701" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="176409701" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 07:41:31 -0800 IronPort-SDR: BEqyBDQ3HaPOkmOVKNafekq5kzdX6p9TZYqZsA55PM6SyL1/RQ8v9fnqRZWafvxZbH32pUIf5h CAoz8BaQJAaw== X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="362025040" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.53]) ([10.213.227.53]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 07:41:29 -0800 To: Nalla Pradeep , Thomas Monjalon , Radha Mohan Chintakuntla , Veerasenareddy Burru , Ray Kinsella , Neil Horman Cc: jerinj@marvell.com, dev@dpdk.org, sburla@marvell.com References: <20210118093602.5449-1-pnalla@marvell.com> From: Ferruh Yigit Message-ID: <00d0820f-b73d-5f48-afd6-ce80c560efab@intel.com> Date: Tue, 26 Jan 2021 15:41:26 +0000 MIME-Version: 1.0 In-Reply-To: <20210118093602.5449-1-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 01/11] net/octeontx_ep: add build and doc infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/18/2021 9:35 AM, Nalla Pradeep wrote: > Adding bare minimum PMD library and doc build infrastructure > and claim the maintainership for octeontx end point PMD. > > Signed-off-by: Nalla Pradeep For the series, First of all sorry for the late review, I put some comments on some patches. Overall the set looks clean, there seems no major issue, I hope changes can be done on time for -rc2. If there is a timing concern for updates, I am OK to postpone some parts to -rc3 as long as they are committed to be completed for -rc3, let say like for adding dynamic logging support etc... Please be aware of the 32bit build error, details in the relative patch. Thanks, ferruh