From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBAB6A0032; Tue, 12 Jul 2022 14:40:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8406941109; Tue, 12 Jul 2022 14:40:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BD1F2400D4 for ; Tue, 12 Jul 2022 14:40:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657629631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A4iqpcrveQv5h5p0RCUxI5gmHBcDH4DdgOLRkEfJGpY=; b=Vmhklnt+YD6VSoSPy82LMfp/2DIeEPK/l+LFp134JABwZTUVGUV4/7O8yAsA1eICXFGTgO sJmoQnd/H1Ea5gPgJV/qYfECrP6+Sd9EsCpc5DThvmfpG+yUZfDOFOTLQdRd3VpVs9L10s eeQg/9IlUXMuMPcAr0VaApBuvkd2Q0A= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-669-rF3tLUcHMEyOYchiloBhSg-1; Tue, 12 Jul 2022 08:40:28 -0400 X-MC-Unique: rF3tLUcHMEyOYchiloBhSg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 689993C11720; Tue, 12 Jul 2022 12:40:27 +0000 (UTC) Received: from [10.39.208.27] (unknown [10.39.208.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B4051121314; Tue, 12 Jul 2022 12:40:25 +0000 (UTC) Message-ID: <00e57c01-cb10-e3cc-c703-88976944d1c9@redhat.com> Date: Tue, 12 Jul 2022 14:40:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] doc: announce transition to vDPA port close function To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@amd.com, david.marchand@redhat.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, chenbo.xia@intel.com, ktraynor@redhat.com, Ray Kinsella , xuemingl@nvidia.com, matan@nvidia.com References: <20210518073441.2749096-1-thomas@monjalon.net> <1022991b-c3e5-1b1f-f713-f4769e6ca4e5@redhat.com> <3424161.GA8KThiCzi@thomas> <3553248.ZuhQCC13oI@thomas> From: Maxime Coquelin In-Reply-To: <3553248.ZuhQCC13oI@thomas> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/12/22 14:28, Thomas Monjalon wrote: > 12/07/2022 14:26, Thomas Monjalon: >> 12/07/2022 11:16, Maxime Coquelin: >>> >>> On 5/18/21 09:34, Thomas Monjalon wrote: >>>> There is a layer violation in the vDPA API which encourages to destroy >>>> a full device with rte_dev_remove() instead of just closing the port. >>>> The plan is to introduce a new function in 21.08, promote in 21.11, >>>> and deprecate rte_vdpa_get_rte_device() in 21.11. >> [...] >>>> +* vdpa: The vDPA API should not try to manipulate or export >>>> + any ``rte_device`` object, which belongs to the bus layer. >>>> + The function ``rte_vdpa_get_rte_device()`` will be deprecated in 21.11, >>>> + when its usage will be replaced with a function ``rte_vdpa_close()``. >>>> + The new function should enter in 21.08 and get promoted to stable in 21.11. >>>> + A port close function will allow to close a single port without destroying >>>> + the rest of the device. >>> >>> Maybe there was some changes since you posted the announce, but I don't >>> see why rte_vdpa_close() would be needed. It seems the only user of >>> rte_vdpa_get_rte_device() is the internal vDPA example, and it only use >>> it to get and print the device name. >> >> You're right, it was an oversight. >> So we need only to get the rte_device name. >> >> I propose to replace >> struct rte_device *rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev); >> with >> const char *rte_vdpa_get_name(void); > > sorry, I missed a parameter :) > It would be: > const char *rte_vdpa_get_name(struct rte_vdpa_device *vdpa_dev); > > Or do you prefer "rte_vdpa_get_device_name"? > > > rte_vdpa_get_device_name may be prefered to avoid confusion with the socket name. Thanks, Maxime