From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
(mail-co1nam03on0068.outbound.protection.outlook.com [104.47.40.68])
by dpdk.org (Postfix) with ESMTP id D2FB0F983
for <dev@dpdk.org>; Wed, 18 Jan 2017 11:37:48 +0100 (CET)
Received: from BLUPR0301CA0025.namprd03.prod.outlook.com (10.162.113.163) by
BN1PR0301MB0740.namprd03.prod.outlook.com (10.160.78.147) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
15.1.845.12; Wed, 18 Jan 2017 10:37:47 +0000
Received: from BN1BFFO11FD002.protection.gbl (2a01:111:f400:7c10::1:111) by
BLUPR0301CA0025.outlook.office365.com (2a01:111:e400:5259::35) with Microsoft
SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via
Frontend Transport; Wed, 18 Jan 2017 10:37:46 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed)
header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com;
client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
BN1BFFO11FD002.mail.protection.outlook.com (10.58.144.65) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8
via Frontend Transport; Wed, 18 Jan 2017 10:37:45 +0000
Received: from [10.232.14.39] ([10.232.14.39])
by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0IAbhcV005348;
Wed, 18 Jan 2017 03:37:44 -0700
To: <thomas.monjalon@6wind.com>
References: <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com>
<1484735880-17178-1-git-send-email-shreyansh.jain@nxp.com>
<1484735880-17178-5-git-send-email-shreyansh.jain@nxp.com>
CC: <david.marchand@6wind.com>, <dev@dpdk.org>
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <00e9bfae-0c24-8e63-e3ef-821e0951a2a5@nxp.com>
Date: Wed, 18 Jan 2017 16:11:12 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <1484735880-17178-5-git-send-email-shreyansh.jain@nxp.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131292094657953737;
(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
SFV:NSPM;
SFS:(10009020)(6009001)(336005)(7916002)(39400400002)(39410400002)(39850400002)(39450400003)(39840400002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(377454003)(24454002)(199003)(189002)(356003)(31686004)(4326007)(2906002)(23746002)(189998001)(81166006)(86362001)(38730400001)(54906002)(65956001)(65806001)(4001350100001)(47776003)(305945005)(77096006)(229853002)(230700001)(105606002)(2351001)(50986999)(54356999)(8676002)(76176999)(68736007)(8936002)(5660300001)(104016004)(626004)(81156014)(6916009)(106466001)(64126003)(83506001)(92566002)(6666003)(2950100002)(31696002)(33646002)(65826007)(53936002)(50466002)(85426001)(110136003)(97736004)(36756003);
DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0301MB0740; H:tx30smr01.am.freescale.net;
FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD002;
1:xNbVrzOihtfgeHUGltVnMs4TicvQCL1jNt2Zvj9BH3SFrjKtwuEJ98mY+Hc1aoh38GUcVaReznx1BZYEKw1GRqfSIY7o3y3GzrQWgvTROHanEuGhhrUkj6G7dWaNn3PUsgIg7DNH9xiwrcitdRQcVm3rA8ZNolRz4SmtwE4Qba7pnE2WXOpk1klNfyg+Zpm0+tDJ/USVlJDbhe0J9/eCBdho24qk1x4Uym9s7iTGg0+WfxkARdiAyW5dI8VliY9MMo0HD81ji7E4vt1p/DcMaUnRrpn5dbJOoGC8468N13j5A2a4xM2xJeOIXjbDuY3EUOd2kRSaYXSvcQQ9tFyyiz9sMDyH7z+XoYbx3pAgflymkqcbLo9R+Jw2oDymsQpW+AaX/3+ccbnE1S3/HLq1hPFr3PqDHPK1TFxMtzcbgIGxn/sdRxhvmdFfIGDp+UwP62NDZaGslTzNaZ3HBUmJwfI6akz0jTL1SFXvO8lPSQ0DLPzsXcwN5qi8p9w5VPug2UFaiWp8vKPW3Ynl9eSF25r7atwoAZPeuju0wRxg41uai4xvpWogHt8xogSV08US
X-MS-Office365-Filtering-Correlation-Id: 5590b067-8903-4c32-1e6d-08d43f8e0a5c
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001);
SRVR:BN1PR0301MB0740;
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740;
3:SuoaN+eAapn45pwXz43XC1jmFpyCSyk8s/2kyUhZ0csV7Q0+KzM4PlvtuCb2mhN93gAY5RMzMh7Yp8AOAOBleBcOeeF0LsOD+eegnSByYPZzk1SuJAIARwQU3or+n5CdQvJrixm7TmeofCpcPeVq3NyJqeyWYck7WylPPBXVMsj+wReMz56SJMOdhCQ4dL9p/iy+mJehdaxBsCbLRUjQiO1maW/7NXgQpnSAHFGRlrojZIftg0gCBNWCT9jPvvrZo8C95480IDynKBjZzcj0eSPSqYPE2C1nzIKF2tOOPToI3Q+ycT1ijLopx5Ql3nmohprakCcu+sr+FWM/GTaBxrZfg/0xrL8K8tgit5VJ0lDgzXopCKh8yuCkzCoNaujj;
25:UfA5NbW6J7UNz2rEcY0kUMi9wgocQ0jSePx+N3yHnmRw+R+nCr5zj91CtVg+i0EABRR8jTzR/r7tuRykNLUEL6fIyH9xkMnKIGdbL9BvYI2OWRvGdFxhCc0FjaS6Rrv+ItPPMnvkGT4vz62GGupGYdwgY5mfFK6R7cuuCNKuoP4irInSQdX577ECB4ljmSgxDK4XaBkfYJc6czNx5JCqnzsa5ravg9piY2e57OsP4ScjRUYTPVwLsM+rzqqEK7RSFTDASp0ZApxB863klUEBsLUH7BfjeWvvTYPn481FICYHZIFItBmDz0d+wCf6gNAP2Sd8arWxUzH4vN4aHIcR/BoIlpqLx8DOM0fAyYb5jQxqZrVxsoszyBKm97ySxTaV97OU0gwuwSrZEaS0assJbr4tMxk4j+NvUnpQydI58UEQHgCzHggrr8LsIoV43eFiO5o8RXMIhyPAJ0qndVBwdg==
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740;
31:CyIExCY2puzJzThWo1y3uxmH7E30JaG2x+aK0sN6C5+NQ34An21zIeA4kVXh/I2xwUrYhSOHgVsZxkcVvQEW3Mr2l9cEXrThfeNCoAnkdcpQLz7rtJetqzUVO4/89DuA/ldg/JnrhkzyElfzYoPRNpr5Ea+rk/FGcO8fKsAqSxg8D5aX11CVe0wMAZmK+QsAR1NjIo6NDRlMA8Tcz1M4dnq4Mvy2tcDatAJQwSI3qb4qy+nU8ltmAkJK0RHgfyW+/tvzccKgloSrlqgjyMhiaO3g65J91sN2YzW2GAGJpQw=
X-Microsoft-Antispam-PRVS: <BN1PR0301MB07401BC92DC3037D68F52B44907F0@BN1PR0301MB0740.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6095060)(601004)(2401047)(13015025)(13024025)(13023025)(13018025)(13017025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123563025)(20161123556025)(20161123561025)(20161123559025);
SRVR:BN1PR0301MB0740; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR0301MB0740;
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740;
4:REDYknjVPbB+YMCrzOYZf7mN9zZtvYuyGY88r2nIT8sxUtdgqyF5pUI45kLRDL2mXP+mg72aaRAiFBUsQ5cUTwSyj1W0n/hrwJsRJr1ASYQYFSsDe0d8CXXIXUX+yUc7cCdgXqSmf5oK08SbWn4CsR+OA4Fj2cV5hP70MSw18T9zAcfUxXbyWZQACGl7KJ6Syi+4J6AdlR358sQF/FI2Cy2EyGejxXv0od0aZZxKkYflfG6OT9XkVH//CgP1NcerYKWNNZKCEl+xzP8A+uHnpYyLvM1MR4yrGymRbZdS8QKZ7SljQ+Mc+1lOnvqKTVc4rRuCbGFaO7c9I7xv0z/nolAqAfqAtFmBDIKvkhZOE6LXbdHTslDxhR3+WkltZrQiLZavzWOpTto8AXA52ptERce1MXX6zdcDY8P/uJblfaTNUGer8dheijHGz/6QQrjTkLXOR1YuJonYj6UmIj4q2Mkws4HkAs6KsP8NqZXIGUpfR9e0bzYdngme0cA216XDfpW6va9EaCZiHPVMX86OQf1DZ1sE3HrA9SAmSZkwlDfZTTXg/kUg73+u0BMvqOqCZZh6tJumI4bGmLomOZxhElgMm3VBJLLmErflOLMNijobnI7+C0r1spofptKsbWhJ4S+XQXj65fCd6tf+d6SZMQ6+2Zr29OH10isUDyObySRkaKPiD7VQLM8Y1zrp8Co3n0Cq6R2SUd9/sOeEhRtXFQ==
X-Forefront-PRVS: 01917B1794
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN1PR0301MB0740;
23:4JTdHDnbTVqjUwNTtQzObj+mgx2+x853N6Q?=
=?Windows-1252?Q?Y09gXG7PZfz+Lyy8vLkdE5B0npXlQ5IT97gLHZUOzG+hiuyLrcRXFOE9?=
=?Windows-1252?Q?MIoa4FzK2j8pWMQKUfA+rIqjpKynI3E6QVoCarPwMaaS6m+57ESAss+b?=
=?Windows-1252?Q?nzEMD1ZrLt+5ma9SjmHc3XPlc+vzcLqqMynTD22+cWcafUSbV6P3QT6I?=
=?Windows-1252?Q?8XhKZibQDSoXA4Qy0Y6NUSTJvbqHdi7wh6QI9JNcKA79eYW/89LA3r2h?=
=?Windows-1252?Q?nfZldYsF2uO48El4/BBUsEElrNRp4brSAbHIv7s+smTUuH5NMHvFfN7F?=
=?Windows-1252?Q?GQNvQw2jMleVeqvCl805PsSvYEw0OkdQSNVh3ZrofpAc5jUu8uFckoiF?=
=?Windows-1252?Q?W1jjf7eYETk9YBzwXhYfxKBOO7NAkZNDhh+cFK4ZhR9FK5gJ9xxbI0xI?=
=?Windows-1252?Q?FZvzs5sBGkgkzjbAWu3jYFCVq3Fsod+gvgwsDlsvB4nPL/vDGpViA8ve?=
=?Windows-1252?Q?h7ADa55PackkqGUOZhsa/K/yq0x5QTwTaQJOv6+EYkpj21pzhRmzHH6+?=
=?Windows-1252?Q?P/hgmHVORh7YM7aSOLm18Ab3HaRwTCOddKOi8v3T2sZQM6qOcCz1E00Q?=
=?Windows-1252?Q?xPMTtIa39ya0x3/zWkCQjgAlD7F1im2KlWi3r2/pP/EtEdf7TbEZkdgt?=
=?Windows-1252?Q?A4jWIFHcymqAb5kAUukpOGgtwop44Sw7KVGnKfjf7Z8sPqJFWYAIgsAC?=
=?Windows-1252?Q?1F8mBoRZOBI9fwXHfPWuQPhQWkx/ro6B6hBcFKQAeQuSfmMBQ9kSSx6d?=
=?Windows-1252?Q?0oKX5mn6BaZ5qCdjROjGI1SxZRibzFteEhZSoAU2rZ/9kynFQLy0zANH?=
=?Windows-1252?Q?eJjoX5fDBuLyCT35Nbrufi8mBmoOnt1V2zjdcRkT0f90Yx+n1fv2riEH?=
=?Windows-1252?Q?7C/PmzP7CS2VsVickXc8w3QO8kXlM4VV8OfVjx3YfXgHFU4JVUBqkX4X?=
=?Windows-1252?Q?vQ5qG5KhH37wBI3td5SSoHUCy6Rgv/UloBpseKlNi9OCThGJtVyoCgJQ?=
=?Windows-1252?Q?wVzAjZ6XBzO86uoPalw3REflZnf+NNe6//hQH/WSOHEO1+dZIJhAg3gO?=
=?Windows-1252?Q?L6GJ5NauPM2iN7DFYU6HKpntLENA1H/PcP+y+5xhhBNGYcHw+BKrDbhc?=
=?Windows-1252?Q?IPA1YC6nPemiJF7/kwqjlFZo6MjRjeqhQb3QggycDethLP9Y5khnhcur?=
=?Windows-1252?Q?oNsHaMzdnlal8tpgSBX03jNkvvjnpGIUUHfq2El05zxEV3in7Re3h/IF?=
=?Windows-1252?Q?S3Xfwxx04nllgq7Dp1xKKizBfjUnzvB9ML4RBxc83ymViSEa7BDXhuBH?=
=?Windows-1252?Q?/pgNX+nxFT0HPAdZtzLQRgtRxhZ2s7HVUUeFK8vbkn3SWhm0W1Pakj5K?=
=?Windows-1252?Q?CViXGnGMu7FIzyKzaWee91apDnI5CGo/U6SZ/rILLpMNs4Sw/Z0BoOAE?=
=?Windows-1252?Q?Gb7lkdVL+WQUfBnCWKtUJzuIXNE9tYlIMfaMYhEKj3hQym0JBYbwA7T4?=
=?Windows-1252?Q?bRlwR7MzscnSnHLM6Ne0hcEhuktVvfPNFqdkyNZNl6myq9nK37Sy1Xof?=
=?Windows-1252?Q?vbRA+yQas9TOpF2EzjqvbK0bIyDnE4XC67QDXKFf6PIFj?=
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740;
6:4ePUXC8x82GK1sjgc2bUxRnwlGjMafFVOsTfKD0QnoYlfIwLC1K/4dofHEkxwZ/D7BsTUcDwpthezrXT+Nyb1Y0AXxYWrx0XBcclhojS0H41DOi7T4dLW405zg58F9kbOEkluU7y53jENoi6VhZyQFQcNGzLAW/Nwi7xWN2tcqAnxsb/qYSGjqB/QUi0ZN4VSIzcsBWG6qiCvDa2actXpAutkt5W1QINcMYeNnVjec6shYj8v65eN4sAINFghs1L521OumpjoYLpraTZ+OlbUwmGTn7KYXfyJUELJP/rKZfYU224FI86mkuNGjelxf0F5geSmzFSJRvS9SJ7Joitg2h5t26l4QHYZfnN+rEXnC4Ea9paxq7lMBLRrYl6eeQSAsRnlI33LCz7tOV8WGGEXAgkTPYkpvSm+Je8wgXa2ldhqC1afMmmNvz3FeLAqLZb;
5:SqjyPrVshcDrP/jHiLU5jumKfuqpCw7Eyu61KCImq5kvolCXMwx0FZu4an1eclxFXPm36uVWM3UzUt0Huv/MIgBUQAmFiT8eD5O3UFp0v5kfwhcP9XTsAw0G/Auk5tY0ZIU8nhYXJYlLMmaPG8PZNQb1TY5uUl1IX+SYJ/9aDazj0NceA2JFJhr/JB1UQQgR;
24:R4cZgn1Ch9eSq4UxhP0AjfFKNIOEO/rbJqGtPzer415qvA7PmzcyBIodef3Zl99khOHyGHLW8gGQsnFW3dJsYYFVR1Lgx3cn7IO+rI1fq5M=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0740;
7:T4k6Bj29M41JtVG8h2APBFncv5BxFlpSUOzyv/gVoLKUgD7KeCjkH8hY6dc+B4wr+Cxbm79SHgcxE9lxclfeXaI1KaoxXim9xIcP1voNTE8WjmBBqFud+FDM87r24YGXdIx83Yf9/cuTFuN4Nvn/mqFuwbbyMN54/kf8BoXttPfSEdQp/Wof3PM0KXeC8cjBKViVt1BVbhpNGF+4UnD5wFdUUv1LRMUvXBxdhE+A73pOJ2/A0KdXRcgeErZUvzQfLaNTlTcJMzClP//0OUgsdrcIvT1oouwp5Py9oTZEmzeO50ubRIpPI+tRNDsBHj4dYSrHCsto1YMQzqOryAwXgzLApq2AaXm2SvoG3MjE0HXmcPO45TMU7RrEhoI/93JagyjhbzVOcKc1uP79r/NqouwVPn8KNkkWTc1byFow8nJaRi4UmZ94Op8fehCDFsAP75+ne+TD7fmRITBtS2gPfQ==
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2017 10:37:45.6081 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0740
Subject: Re: [dpdk-dev] [PATCH v9 04/12] eal: remove loop over drivers in
device detach
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jan 2017 10:37:49 -0000
Thomas,
On Wednesday 18 January 2017 04:07 PM, Shreyansh Jain wrote:
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 4f155c6..7548ab0 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -259,15 +259,17 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr,
> * driver.
> */
> static int
> -rte_eal_pci_detach_dev(struct rte_pci_driver *dr,
> - struct rte_pci_device *dev)
> +rte_eal_pci_detach_dev(struct rte_pci_device *dev)
> {
> int ret;
> struct rte_pci_addr *loc;
> + struct rte_pci_driver *dr;
>
> - if ((dr == NULL) || (dev == NULL))
> + if ((dev == NULL))
There is a checkpatch warning here which missed my check (double
paranthesis). Let me know if you want me to send v10 for this.
Or, if there is anything major, I will send it along with that.
> return -EINVAL;
>
> + dr = dev->driver;
> +
> ret = rte_pci_match(dr, dev);
> if (ret) {
-
Shreyansh