From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FF65A0A0E; Wed, 3 Feb 2021 08:49:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FA7D240473; Wed, 3 Feb 2021 08:49:07 +0100 (CET) Received: from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22]) by mails.dpdk.org (Postfix) with ESMTP id A4C8624045F for ; Wed, 3 Feb 2021 08:49:05 +0100 (CET) X-QQ-mid: bizesmtp15t1612338539tikfh0kn Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Wed, 03 Feb 2021 15:48:58 +0800 (CST) X-QQ-SSF: 01400000002000C0D000000A0000000 X-QQ-FEAT: Nmsx8r67kEsPgTSzCu7MNnOS2bqcR2VYCsl348E2wVlreqlTY1Bvz6uBrx2Hz QceSreaq99juJj1swPsHDsmog+5Zbelw9Y7TvLDw57VYaJgN6nj3eKtLQZasxmgLr/pshbv fZcUsNdbJsrlJuoEvrwjq91QmL1+ihd3hfUZs39F7jeFUDEvrnKkgWKbpeJGoQRbGa3fMeR CLGl0mCu70PyC95g0jtM/nXAQ1lbgMVCqoZEtQGVS3lzk+3FMVEh8A5a5YeH6kPDvoStFdc sDGLRXvMCtFsWb1ne3jlT6iA+80PPdTVyCWCXtUulf7WzXmBBN4I3vnBnO8EGd1zheGVIun 2/qFSLOkEScW9n+LxfgTV4iCHQDUA== X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Ferruh Yigit'" , Cc: "'Thomas Monjalon'" , "'David Marchand'" References: <20210122094800.197748-1-jiawenwu@trustnetic.com> <703a35e7-9b88-8fe6-8789-4e1f5e15462f@intel.com> In-Reply-To: <703a35e7-9b88-8fe6-8789-4e1f5e15462f@intel.com> Date: Wed, 3 Feb 2021 15:48:58 +0800 Message-ID: <00fb01d6fa01$08064bf0$1812e3d0$@trustnetic.com>+5C5F6269CC8273FA MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEhvvf5XUmdO86XAdbl+2hGQpA1fAG3Ydw2q6LBRaA= Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v1 00/20] net/txgbe: add VF driver support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On February 3, 2021 2:08 AM, Ferruh Yigit wrote: > On 1/22/2021 9:47 AM, Jiawen Wu wrote: > > This patch adds txgbevf PMD as a part of txgbe PMD. > > > > Jiawen Wu (20): > > net/txgbe: add ethdev probe and remove for VF device > > net/txgbe: add base code for VF driver > > net/txgbe: support add and remove VF device MAC address > > net/txgbe: get VF device information > > net/txgbe: add interrupt operation for VF device > > net/txgbe: get link status of VF device > > net/txgbe: add Rx and Tx unit init for VF device > > net/txgbe: add VF device stats and xstats get operation > > net/txgbe: add VLAN handle support to VF driver > > net/txgbe: add RSS support for VF device > > net/txgbe: add VF device promiscuous and allmulticast mode > > net/txgbe: support multicast MAC filter for VF driver > > net/txgbe: support to update MTU on VF device > > net/txgbe: support register dump on VF device > > net/txgbe: start and stop VF device > > net/txgbe: add some supports as PF driver implemented > > net/txgbe: support VF representor > > net/txgbe: hardware support for VF representor > > net/txgbe: support VLAN filter for VF representor > > doc: update release note for txgbe > > >=20 > Hi Jiawen, >=20 > I put some comments on some patches, can you please send a new version > with updates? >=20 > And I want to note that it is specially hard to review this PMD = because it is > clone of complete and complex ixgbe driver. > So most of the code is already ready, we are tying to structure it = logically for > upstreaming it but it is not possible to review the details of this = much feature in > this short time. >=20 > For those feature we are relying on the Wangxun to test all these = features, and > to confirm this, can it be possible for Wangxun to send some test = results for > this release? > Hi Ferruh, Should I provide test results of PF part applied to the main repo, and = VF part with some modifications? I mean, the latest version that I format the = patches. > Similar to those reports: > https://patches.dpdk.org/patch/84436/ > https://patches.dpdk.org/patch/84500/ > https://patches.dpdk.org/patch/84517/ >=20 Those reports show the NICs supported platforms. All features in dts = report don't to be needed, do they? >=20 > Also quick test results for the -rc2 & -rc3 can be very helpful, if = you can provide, > like: > http://inbox.dpdk.org/dev/c2bd98a6da8d4955b19b8838c9bf60b7@intel.com/# > t > = http://inbox.dpdk.org/dev/92ce632a-dc21-f50c-d4d6-85e7961b6e3b@linux.vne > t.ibm.com/#t >=20 > Thanks, > ferruh