From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77B0C45D3A; Tue, 19 Nov 2024 03:02:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B722402BC; Tue, 19 Nov 2024 03:02:36 +0100 (CET) Received: from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22]) by mails.dpdk.org (Postfix) with ESMTP id 526734025F for ; Tue, 19 Nov 2024 03:02:32 +0100 (CET) X-QQ-mid: Yeas4t1731981744t507t43055 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [115.206.160.172]) X-QQ-SSF: 0000000000000000000000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 8655496705373165827 To: "'Ferruh Yigit'" , References: <20241115083336.1195101-1-jiawenwu@trustnetic.com> In-Reply-To: Subject: RE: [PATCH] net/txgbe: fix a mass of interrupts Date: Tue, 19 Nov 2024 10:02:23 +0800 Message-ID: <010301db3a27$130f31a0$392d94e0$@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQH3lHx+VB6Ce15n329vNcxxLWY6UgHZil6isnZTpdA= X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: NGHdgOcrWZQ9fPj4SZGl2aKqLD04TzcXvwGcpzmhl5UzgWi+TB6ZZmxt 0t7coeB4XITUmGNfQNj1TNG5l5cRrkF7L0/9i2P9dYQpnS8Ck+B3zTut5ydxkXNudIJbU6g EjTgs4jbhn8bVHQdXWg7DOiy8pRnuMLV8LVV3GVVniQNvM1EIW8azwjnU4hJ00e8Jg+EEkR rUz23LIA/Nf2UBNMg2iSPOryPvWLwuSeapCWQAcU6nqqzYKHKfk6XkXs/R7fO+Ye0kM+bel WhjqPIzHBVmLuznaZQhRCfPvo9+ztOI5YSCR0kmOWDoAy9rRFjhHDVe0YJ9/khlSy9Osr/g ZyTVWTQvzqedfid32ux6N+nCCv1TFZe66pd+J18KhAA1BzXRednyudaUgmxDSP/cX61g41C zhWahIt4DSCt+Len+wgsQll+KICaCvBMGqSC1PaTp2u0qIjaEJE/+oqIiIBJTO+VO7Vx3TJ cNe8IRICKOHNpJxLboEr0gFLpI3ZpGxKsD0fcHtBFGpB1V0nfLTywwaJFMX0YgDCip/5Dov n4ka7zob0ToiQfHGw1jvZadqmfbJiolKlafp8m/OP8NUHh58YSbpr/EXI5vXLVH35odN8zx igDDsX4f1gxJoEjRKhmddlocAJvQahGmxJk3bIWvelw98nMRVoS5NM95uf0gJstvVThcLMD 1sCZZKFzBclLAtfMulAURLODbmRNJnN4gBNr0lOzDY9OWQQjqKIAL1b5up9swqoK1a/RI5e baJm8DmZQrdNzYAmwSs9MENb3FtQIRLK67+4IFJG+mofKYKccb8yL7RTZi7Nikborkr0mVz WU7m/OiH8bNgWdqtaHMECXu6H6sjVu5yP9zXmFc2iBGnr5VDJf6ouH9QLr1flHhfIoHBpbQ LMP4XhTtwcjON5QOZDoLmd5Ex0jSEk8xhN2LLnXeY1R2YM6nK6aPPioy7U1C3mG105xLkAI vtA/fJdpnx12BgdLaGlCX4qYYFReO/QIuzn39ctSDwXHQiwYiILpO1HXE X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= X-QQ-RECHKSPAM: 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 19, 2024 3:59 AM, Ferruh Yigit wrote: > On 11/15/2024 8:33 AM, Jiawen Wu wrote: > > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by > > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity > > is set to 0xd by default too, which means these interrupts are rising-edge > > sensitive. > > > > So when unplug the SFP module, GPIO line 0 'tx_fault' is 0 -> 1 triggers > > the interrupt. However, the interrupt is not cleared. And GPIO interrupt > > mask is enabled and disabled to trigger the MISC interrupt repeatedly. > > > > Since this 'tx_fault' interrupt does not make much sense, simply clear it > > to fix the issue. > > > > Signed-off-by: Jiawen Wu > > > > Hi Jiawen, > > Can you please provide a fixes tag? > Also I believe you would like to backport this fix, if so please add the > stable tag as well. I have thought about it. But there are two changes based on two commits: 1. d3bb4a04eac1 ("net/txgbe: add SFP hotplug identification") 2. 12011b11a3d6 ("net/txgbe: adapt to MNG veto bit setting") Should I split the patch and add fixes tags separately?