From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB0B2A034F; Tue, 22 Feb 2022 03:03:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAEE240DF6; Tue, 22 Feb 2022 03:03:57 +0100 (CET) Received: from smtpbg501.qq.com (smtpbg501.qq.com [203.205.250.101]) by mails.dpdk.org (Postfix) with ESMTP id 811AB40E64 for ; Tue, 22 Feb 2022 03:03:54 +0100 (CET) X-QQ-mid: bizesmtp82t1645495427t1mrn14a Received: from jiawenwu (unknown [183.129.236.74]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 22 Feb 2022 10:03:46 +0800 (CST) X-QQ-SSF: 01400000000000F0M000B00A0000000 X-QQ-FEAT: NFbnPP6/4uIE5fObh1rT03nkmE7McZtANoUCHz7YN4jrqYicPdCeuqd/QfJKY 5sT27lKI66TaY5hCKMgX0QgRaZ2mILml/Fl054jZqX3mcumVZe4DbAphowL2YKQJa7wbxj+ NAm12TAizwuGNq3n7nfi5hKka85HlY5EE1xC6lniOw/kBpJhn0vi/Eni1N/JBqogpuXTr2m p+TAnjuxXnhfYimjXkngRvi4MUrfMyGwPQy+rJLKGxixtWLSlEka7cecrbANLx5JOU0tTEQ XgvTqya9ZORpVwye3SsR8IyyQNtec5+vY30K9BvF/FPbR5pt752tD9aoRnZhdGV9UxU32FW 9FrlI30dhh7G75w0/8= X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Ferruh Yigit'" , Cc: References: <20220221092121.2145802-1-jiawenwu@trustnetic.com> <20220221092121.2145802-3-jiawenwu@trustnetic.com> In-Reply-To: Subject: RE: [PATCH 2/2] net/txgbe: fix debug log Date: Tue, 22 Feb 2022 10:03:46 +0800 Message-ID: <010501d82790$6dd3ca80$497b5f80$@trustnetic.com>+0BFEB4E10BC55980 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQEfidqIPjpbDmp+UQn1WZ+CB7umDQF8q0f1AnF5m/Kt8JpdkA== X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign1 X-QQ-Bgrelay: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ferruh Yigit > Sent: Monday, February 21, 2022 9:10 PM > To: Jiawen Wu ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: Re: [PATCH 2/2] net/txgbe: fix debug log >=20 > On 2/21/2022 9:21 AM, Jiawen Wu wrote: > > diff --git a/drivers/net/txgbe/txgbe_logs.h > > b/drivers/net/txgbe/txgbe_logs.h index 67e9bfb3af..38c5d05984 100644 > > --- a/drivers/net/txgbe/txgbe_logs.h > > +++ b/drivers/net/txgbe/txgbe_logs.h > > @@ -48,11 +48,8 @@ extern int txgbe_logtype_tx_free; > > #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0) > > #endif > > > > -#define TLOG_DEBUG(fmt, args...) PMD_DRV_LOG(DEBUG, fmt, ##args) > > - > > -#define DEBUGOUT(fmt, args...) TLOG_DEBUG(fmt, ##args) > > -#define PMD_INIT_FUNC_TRACE() TLOG_DEBUG(" >>") > > -#define DEBUGFUNC(fmt) TLOG_DEBUG(fmt) > > +#define DEBUGOUT(fmt, args...) PMD_DRV_LOG(fmt, ##args) > > +#define PMD_INIT_FUNC_TRACE() PMD_DRV_LOG(" >>") > > >=20 > Hi Jiawen, >=20 > This won't work, macros are missing the log type. > I guess intention is to change as done in ngbe patch [1]. >=20 > I wonder if you send the patches even without compiling them? > Expectation is authors test the patches before sending them out! >=20 >=20 > [1] > PMD_DRV_LOG(DEBUG, fmt, ##args) I'm so sorry. I compiled and tested it, found and fixed the bug, but maybe I got the = file location wrong when merging the codes.