From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add namespace
Date: Mon, 1 Nov 2021 17:23:51 +0800 [thread overview]
Message-ID: <011301d7cf02$2f53bc20$8dfb3460$@trustnetic.com> (raw)
In-Reply-To: <20211022110314.470843-1-ferruh.yigit@intel.com>
On October 22, 2021 7:03 PM, Ferruh Yigit wrote:
>
> diff --git a/drivers/net/txgbe/txgbe_ethdev.c
> b/drivers/net/txgbe/txgbe_ethdev.c
> index 7b46ffb68635..0b0f9db7cb2a 100644
> --- a/drivers/net/txgbe/txgbe_ethdev.c
> +++ b/drivers/net/txgbe/txgbe_ethdev.c
> @@ -2695,11 +2695,11 @@ txgbe_dev_link_update_share(struct rte_eth_dev
> *dev,
> int wait = 1;
>
> memset(&link, 0, sizeof(link));
> - link.link_status = ETH_LINK_DOWN;
> - link.link_speed = ETH_SPEED_NUM_NONE;
> - link.link_duplex = ETH_LINK_HALF_DUPLEX;
> + link.link_status = RTE_ETH_LINK_DOWN;
> + link.link_speed = RTE_ETH_SPEED_NUM_NONE;
> + link.link_duplex = RTE_ETH_LINK_HALF_DUPLEX;
> link.link_autoneg = !(dev->data->dev_conf.link_speeds &
> - ETH_LINK_SPEED_FIXED);
> + RTE_ETH_LINK_AUTONEG);
>
Hi Ferruh,
Is there some wrong that 'ETH_LINK_SPEED_FIXED' is changed to
auto-negotiation?
> hw->mac.get_link_status = true;
>
next prev parent reply other threads:[~2021-11-01 9:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 13:46 [dpdk-dev] [PATCH] " Ferruh Yigit
2021-06-29 15:02 ` Tyler Retzlaff
2021-06-30 6:29 ` David Marchand
2021-06-30 9:08 ` Ferruh Yigit
2021-08-27 1:19 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-08-27 7:59 ` Andrew Rybchenko
2021-08-27 20:24 ` Ferruh Yigit
2021-08-28 14:26 ` Ajit Khaparde
2021-08-29 7:47 ` Jerin Jacob
2021-08-29 8:17 ` Wisam Monther
2021-08-30 2:13 ` Xu, Rosen
2021-08-30 5:27 ` Xia, Chenbo
2021-08-30 6:24 ` Hemant Agrawal
2021-08-30 9:41 ` David Marchand
2021-08-30 17:01 ` Ferruh Yigit
2021-08-30 17:19 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2021-08-31 7:59 ` Thomas Monjalon
2021-10-18 15:43 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2021-10-20 19:23 ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2021-10-22 2:02 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-10-22 6:44 ` Andrew Rybchenko
2021-10-22 8:25 ` Ferruh Yigit
2021-10-22 9:48 ` Pattan, Reshma
2021-10-22 11:03 ` [dpdk-dev] [PATCH v7] " Ferruh Yigit
2021-10-22 11:28 ` Andrew Rybchenko
2021-10-22 12:29 ` Somnath Kotur
2021-10-22 16:26 ` Ferruh Yigit
2021-10-22 13:02 ` Ferruh Yigit
2021-11-01 9:23 ` Jiawen Wu [this message]
2021-11-01 12:39 ` Ferruh Yigit
2021-11-01 12:48 ` Ferruh Yigit
2021-11-01 13:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011301d7cf02$2f53bc20$8dfb3460$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).