From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 61492A0C57;
	Mon,  1 Nov 2021 10:24:02 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DA83040DF6;
	Mon,  1 Nov 2021 10:24:01 +0100 (CET)
Received: from smtpbg511.qq.com (smtpbg511.qq.com [203.205.250.109])
 by mails.dpdk.org (Postfix) with ESMTP id 155D040040
 for <dev@dpdk.org>; Mon,  1 Nov 2021 10:23:59 +0100 (CET)
X-QQ-mid: bizesmtp41t1635758632tpg6kxr5
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Mon, 01 Nov 2021 17:23:51 +0800 (CST)
X-QQ-SSF: 01400000000000E0I000000A0000000
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>
References: <20211022020243.2932559-1-ferruh.yigit@intel.com>
 <20211022110314.470843-1-ferruh.yigit@intel.com>
In-Reply-To: <20211022110314.470843-1-ferruh.yigit@intel.com>
Date: Mon, 1 Nov 2021 17:23:51 +0800
Message-ID: <011301d7cf02$2f53bc20$8dfb3460$@trustnetic.com>+83C72ED5F8FE7ED6
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGNILYsVA3ZC1rEZb0Ca/LKWxdjCAHhJXj4rHS1PMA=
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign2
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add namespace
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On October 22, 2021 7:03 PM, Ferruh Yigit wrote:
> 
> diff --git a/drivers/net/txgbe/txgbe_ethdev.c
> b/drivers/net/txgbe/txgbe_ethdev.c
> index 7b46ffb68635..0b0f9db7cb2a 100644
> --- a/drivers/net/txgbe/txgbe_ethdev.c
> +++ b/drivers/net/txgbe/txgbe_ethdev.c
> @@ -2695,11 +2695,11 @@ txgbe_dev_link_update_share(struct rte_eth_dev
> *dev,
>  	int wait = 1;
> 
>  	memset(&link, 0, sizeof(link));
> -	link.link_status = ETH_LINK_DOWN;
> -	link.link_speed = ETH_SPEED_NUM_NONE;
> -	link.link_duplex = ETH_LINK_HALF_DUPLEX;
> +	link.link_status = RTE_ETH_LINK_DOWN;
> +	link.link_speed = RTE_ETH_SPEED_NUM_NONE;
> +	link.link_duplex = RTE_ETH_LINK_HALF_DUPLEX;
>  	link.link_autoneg = !(dev->data->dev_conf.link_speeds &
> -			ETH_LINK_SPEED_FIXED);
> +			RTE_ETH_LINK_AUTONEG);
> 

Hi Ferruh,
Is there some wrong that 'ETH_LINK_SPEED_FIXED' is changed to
auto-negotiation?

>  	hw->mac.get_link_status = true;
>