From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0076.outbound.protection.outlook.com [104.47.0.76]) by dpdk.org (Postfix) with ESMTP id 3E1295F20 for ; Mon, 12 Mar 2018 13:02:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HG8NtpQM1vLZaPuE+nipd25fRaZDXDEAki4uNLehhTE=; b=g2cOK/KnA8j2ItqbOF8Df70m4HQudxJnexsRVfFg40UazxlxIunalmPy2bJFVY3sHNg+WoTePr9gSjGvB0PqVKPH9csTQqa/4X8EeMGGIv6dPp1C2KewJQdx3vl3Jz4SCVR/DyRHt9xeDvKZdnrkO6O+/fJ3O//yeiuknC93s88= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [192.168.43.68] (106.210.85.166) by HE1PR0402MB2778.eurprd04.prod.outlook.com (2603:10a6:3:d4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Mon, 12 Mar 2018 12:02:03 +0000 To: Ferruh Yigit Cc: dev@dpdk.org, hemant.agrawal@nxp.com, akhil.goyal@nxp.com, nipun.gupta@nxp.com References: <20180312092547.18472-1-shreyansh.jain@nxp.com> <20180312092547.18472-4-shreyansh.jain@nxp.com> From: Shreyansh Jain Message-ID: <013ee451-9e4e-4d88-ae77-bc6a316575f0@nxp.com> Date: Mon, 12 Mar 2018 17:31:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [106.210.85.166] X-ClientProxiedBy: PN1PR01CA0096.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::12) To HE1PR0402MB2778.eurprd04.prod.outlook.com (2603:10a6:3:d4::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a0117ecf-2495-4e18-3b60-08d588111247 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2778; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2778; 3:KoHquu/+BdNprx4nfxuSkS7t2OKmADIMe6R/0oUT9w7erXnieWPVA9DW2aobckLIl6WV5profa16eBLBEIJ6kAnqIqlnVO04FduFMLTR5OPMGOs0zOT9j28mbl0MnQRtw92fD8wXP1q/2Qaf/OeWs07mEVUzyxK4eg89TNyRMQiu760j/8+m7kXnIo79JBZkvAAEbnl6dGsZEbsnMeC6hR57o+GGceff2tei5RN91gPlYItP/E0Sv/kqMakXJ2ki; 25:CkRrjCMgzYtL0KxYSjleO4UFvfKuK0bohknIrC7SbFqA1CFhoLvcsfCxHvmVhj+Ji1TWARW5qSwUkO1rA3Ad7zctB6KrB+1OJkToqRjl3WCJ5snefVATAt646/lQiMV6sopwDMTsWLmX893wHyq3VSOjQFnRbj+EskJFYq1EhgtxDzY6W7AkAuFIKtbwAmcw/8ainHUPeECOqv1jXg/qZK1vIWlxDYAmtP1QSMlr7NAn4cXvkOW2Id9aHXrtmFxWkmqp8J0hXkMcY1fMOsMVQJ1RRvlY0ElB2KD+kzeyKzQ/kOLTs8aNAa1u1T1tKmdiV+fdAG1pxOR44+etMy5EMA==; 31:Vyl69425ec73L974HIDshVaN3QyLT4fsYH6sblSWK9nne5H1eUQ8cgPMzSlMe+U4yd1bawJLFAuN+aOkdFXvQR9R+hOI/YgxEl4I0wwNovLoguZJlYK4kfERBnPSjSKD+QQ+DUu+Q34vgojismC+P+DB2It4pRo+4HxLEzpfsioms+0L2JjslfLyaMomPA41+pe49FLjDXzYP6P5L4b/xuQC2lyQ+Bt7Xy8D8+oKNDQ= X-MS-TrafficTypeDiagnostic: HE1PR0402MB2778: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2778; 20:GPH6Ukz/xKAaEa/94jBvglBK5aHVcDnsk+2Tc+nxYA7vVJ+bW4FV8U1ApvdICEi7ke61Cn7m8JeCeCzIWc54biyqYCt78+Cysqtqy9O80X1MpCaOr7/8DGEnwBu5PzsKjsEhW+A2lhJ+7md+a22lUmoTQU9mvU0/P4litdvDt1Syqv26LxjfNXB+PpLqN+CC60K1pDW5OSvDMlHq9Hc8fYPfheUER0TexfUk0Bh9oLxI/cDAhGLjpfIlhu25bwJInNC3SCbXG2MIUBhaEBg6nvfKY3/GpImW+nXGyWnbXbhuZGBbFSU1tQC6hCPRTnP2xjlJdjJWOFTNN0VQEG1NdQqeMAKshQOIcJLoEy1+IwIBJY+1qntwnFoQYJ9U8WBPgTfZCXFHKZyyk+Y3d61p6PIewvKm+vE//CYA6+0RYhjc+35hOKSprcJTeT+PK56Rpqowlg1okVjxLdD6D41N3XnWd6pA6hru+20x6darQjN01S6mqowF3CPrpKgs5cqf; 4:sN2a2rn85O8K0E2wuEg+2Gybt/JxdZsz6RUnjR+FCjjluAxOVqvK0wI3dPMs6K0U/72s4D7ZCEuG8QDlAmRyVaqLvfDvlX69UjA3Nh4BCg8LojEYDffSJMajHxMIKobEgr2HNAqUpv1euTqjn7n1M9l/n7nyKO0xfPo2ENmamSTyG5uZb/Guj7OrX9R4ljDpeDGJa5mR258Ly+WPTYZ4PjVkWi7pcodBE8TdSmF4VAP32SbdVUsoIlY2Fq3d+H1AyM+hm/Ix6Sgv4S4jg8Niu1n67wpXahyqEY+S9N1nPAZxa+7UK3e+PgsObFSOFSpdV3Li1CImr1ubM23tERhFoe7i42AYhWKP3p2kR/7C63c= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231220)(944501244)(52105095)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0402MB2778; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2778; X-Forefront-PRVS: 06098A2863 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(346002)(376002)(39380400002)(396003)(39860400002)(199004)(189003)(53434003)(316002)(2950100002)(8676002)(64126003)(81166006)(81156014)(6116002)(386003)(65826007)(6666003)(6916009)(16576012)(561944003)(97736004)(305945005)(7736002)(5009440100003)(229853002)(3846002)(478600001)(26005)(58126008)(77096007)(76176011)(23676004)(2486003)(16526019)(52146003)(52116002)(8936002)(230700001)(53546011)(59450400001)(66066001)(67846002)(68736007)(6246003)(36756003)(2906002)(86362001)(105586002)(5660300001)(50466002)(65806001)(31686004)(25786009)(53936002)(65956001)(6486002)(47776003)(106356001)(3260700006)(31696002)(117156002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2778; H:[192.168.43.68]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA0MDJNQjI3Nzg7MjM6RXMzcHFnQUxLaHM1TXB0Z0MzM3JiNFZq?= =?utf-8?B?dTZQZE9zaE9EOXU0OTF6dGtpdGU4SHNnamtFVjFCSXE1QXJlY1RoL0NndVZC?= =?utf-8?B?b2V6dDUvYTVtUnk3Z1B6dmVNKzVNY3A0ekJBRGdVZnY4dVZra0tGZWdod1hu?= =?utf-8?B?ZFBOcUZhbDBRUE96WlZIL1NTQ2tSTjFvTWlTY0JXRndEQXQ5YkpoWG4rM05U?= =?utf-8?B?UTBvWkVrVU9HeFJPQ21jL05yb1JIaXhxNFpvTi9PWGdHT04yYmdzNlV4WDdr?= =?utf-8?B?NjdVVm5KbWFCczdpK2N6c3JkWVEvQVNQRHd3VjBNUUpIKzRsQmlKSFRpVTN4?= =?utf-8?B?QTZnZ0lsOFdTcDh6QU9zTjRsWjlyQW01RHRrSExzMGliT1dnZWJTNklGdjE0?= =?utf-8?B?ZlJxY2grUWlFZ0pMWFJZaWh6Njg5a1BVY092bzM2aDR0ZGNzeE1iUkREeDJm?= =?utf-8?B?QUlCTm4rdFY3U1dLYjlqcnFoV3JPZkdlN2I2SndTS3F4ekhxZjUzeksvRUFo?= =?utf-8?B?aHA3VklaYjRtREFIZVlIaHJlVEtEV1hKamVjTXN6Y1dDMnlHZXNtVHlkNlc4?= =?utf-8?B?bGNkSEZrQlNxZjZHV1ZrYlZrbXhvV2laL2ExRzU2WExIOW5yeHBsK1VDRkw3?= =?utf-8?B?WDE3c1k5ZmpNUk8yOEVydlhWRi9xVkcxYlRnRFNVZmpENmRlaTQ1UUVwMUlk?= =?utf-8?B?WVJkMnVJa2NYalRjNXFIa2l1eTB3aXFtNmFodGM0a2puTTlwUHg0VmFxNVZ6?= =?utf-8?B?eHBKTEVzK252aG9POXk2QkNKWUFrVmM3dUVOQ0U5YkY5TjJqWFZLV0dpdVRQ?= =?utf-8?B?TEUwejliVWNYc3hMRVFQL1NrWjdtY2VtcDg4dGlNcHc1dFVSaE85cUc0dGVQ?= =?utf-8?B?alBiVXRrSSt1SXBFUFNwMWFYVkhHWEovRXB3MnNPVFg1MnR2U2NYSmlPQmVY?= =?utf-8?B?bzgvUWpEUzJlMW5PWk85SlNwVEJ0TFVHaXk4ZWVsNHhGT25vc0JGVHNuMEVt?= =?utf-8?B?ZlpRdElMTm0yNGVIZGdjM2Y0Ri9hVVVnN3Vtb1Nzc0prVW1yRTI1K3kzTGJ0?= =?utf-8?B?RlRGTUxlQlJWMWxXalZTY3dnWk1hV3J4ajJwK2cvZHNLOGpzN1ZSNnBrTUw4?= =?utf-8?B?RUFlTnBQRzFDaGk3c2VZS09MeEJ6SUdrN1gvclpZZ1RoTFVzbnR6cS9GK01U?= =?utf-8?B?OHRQSnVwbUMxSWtTWVViUHBQbmdpNFAvVm5YeFRaOTVNSGZqU29ISSt1dUZu?= =?utf-8?B?V2tjOUh4WER2aGRwb2d0c3ppZFZpNHdqMlF1TUVBQTZZV3Y0bUpETkFFbjFw?= =?utf-8?B?bzZESmp3Sm5nUm9ZTG10SkpHd3pDVnlYMzcwS241dG5oclhUVE9FZXR0dFJD?= =?utf-8?B?S0FXbTNTQ29wMFMraG16d3U1VGQyNFJaZ0poc1VxTUxLYzN3ZzVjWGszbjk1?= =?utf-8?B?QW9HeGl6NWxGbWFrWi8xdjIwdTU4ejdCWnVrNXhkQzVyallMajkvU3ZsRWFh?= =?utf-8?B?VFVCTjZXRSswVVRYRitQeXBwYUlMNHUwbHdmMkpKMDhidCtmZ2NsVmxRWlJT?= =?utf-8?B?R05aY3EzcDdQUVpJZHlDMS9MSzhIREI1cmxuODZlQ1RMVjh6cVBvRkJCazB5?= =?utf-8?B?ejAyd1lnL01QMitBbnVJZFdiQlcxT2RkLzFPQm9uRy9VOHBFRnBjYmlxdTlm?= =?utf-8?B?eXFoTFI1anhzdjhDNzA0Y2NNei9KdWM5YnhVcXVPNlFDeWVNV3FTb1FDTjVh?= =?utf-8?B?WUN4UmRYWmN0YzcxUVc1OWZLN1ZQazBmZHp2T09WV0k3Um12WW5IT0VmTFEx?= =?utf-8?B?aWVHbGNSV08vQ3Y2WDNvZzRMaDNGcDZMRTFsaVVpVVBpVXhGZWpOZEhrRUhV?= =?utf-8?B?QmFtcTZKNE56b0RHNXU3SWR1ejBHaSt3WDhXam5WNmM1eHBQeDU5bTc4V051?= =?utf-8?B?YlhvSTl6YVk5WXdjWGJ5Z2VlazZtWUNHQlhXSlpKb3YwQXhHZmo3UXQ5VXpK?= =?utf-8?B?RUpybWVkTVFFdzR2WXQyRS9kc0Q3NjZRdHpZekhRPT0=?= X-Microsoft-Antispam-Message-Info: RzGi5mGg9xY8UEp3ooZdS9X4n1EtwBQKe5vpZ0mj0R/At6em/98Pof9G4eK/GrX6xZVHMuFiv87+56OGLS1+oMqXSG1Lv8rmD9MA+UuRCLHz2/fWYf5xkbTN6t0EGQWG+X8usYSqyA6VqslN4yGnp26WijrPqBfPbYdckUHvpIa4XBT9wq9vEHRuiWVGaIVV X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2778; 6:v5TMGo9NE2k3LuTEQQVHmpuDtQT/5qb3osBUYPs3r9SV+7vCz6ZLTWERsKL8WcMl4MeDZ4+KOCQjPglfH6io+waE+iB5Sk5aH01o9hqv/huyd7l9YmKgW1eOWP8+5BVd0sZdp1cpErWuWsWFq0jf7DvZZCu8PlI+tPKT7/4P2TVGh7IXjlG4AQf2GPlWpKt0t81uoSMb7e20okIOFtSTqFXpAnnpCBKgJx/JsDFPAZP7DWGvx7hmweYH5Gch8d+qr18kHBn8l7V8USAbHQ6x7UIPoxZLo0JUn0pqyha6ldMSt+5w0sWCB4LTNd0Y6pmMmtORUE0lPNhtGkG9yIYvVyTQxGDXjHCnOKuUfzL4JAg=; 5:3iMHW6Dbytz1swnVSeVrFl8Lj2orCXvfip7ZG/RnhOEHdrB62l7avZ8ivIAKVmOaZivwtQk4vtRoUyqtCGc5EwylkUH8K4hP5zBj8sid+GCbfFvOzdSrwOUZxH/cK9QSg8wO5OBXEXOXzaSrLFtCGcihITpT/3DTR7xRYlXNo/8=; 24:tJn/Az5OTrlUIdZYn8edPysdPh0wMrLQh3srxWdmAJcaF/n+4Q1rdUi/ksxTwU8Qw+SsWS4xajam5kTA3v1zjtnwJ203a9WKrVXPkHrXkQY=; 7:+wfKl2RnHmk3UNAfuaIytwKWhdOhq/5pbyJDSrywIeZk/ywi2T2XRdalkXg1zN6p0VSC4BdypmsA0LYPK5c0zzc+4GYZG0EjW1xD8Rv8nhYKKyVQlCjoXxvHzAphJoQm+r3H216Z0ODANwzVQiNIuoEYHLI3nrG0iSlvZw3Vuf/mYMxuIbblUMCVfCwajoT3hE+Avr7nWYQ06s/rQy/IJEy+pfZLBqI7ey+Ary8ML9OCfh3kd+7kX36woToMKiQm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2018 12:02:03.0116 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0117ecf-2495-4e18-3b60-08d588111247 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2778 Subject: Re: [dpdk-dev] [PATCH 3/7] net/dpaa2: change into dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 12:02:07 -0000 On 3/12/2018 4:34 PM, Ferruh Yigit wrote: > On 3/12/2018 9:25 AM, Shreyansh Jain wrote: >> Signed-off-by: Shreyansh Jain > > <...> > >> @@ -188,11 +188,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y >> # Compile burst-oriented NXP DPAA2 PMD driver >> # >> CONFIG_RTE_LIBRTE_DPAA2_PMD=n >> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n >> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n >> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=n >> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=n >> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=n > > Just to double check, are you sure to remove data path logging config options > too (RX, TX, TX_FREE)? Yes, I have removed all conditional compilations. Some more context below. > > <...> > >> @@ -557,6 +536,27 @@ for details. >> Done >> testpmd> >> >> +Enabling logs >> +------------- >> + >> +For enabling logging for DPAA2 PMD, following log-level prefix can be used: >> + >> + .. code-block:: console >> + >> + --log-level=bus.fslmc, -- ... >> + >> +Using ``bus.fslmc`` as log matching criteria, all FSLMC bus logs can be enabled >> +which are lower than logging ``level``. >> + >> + Or >> + >> + .. code-block:: console >> + >> + --log-level=pmd.dpaa2, -- ... > > Reminder, this will be also effected from naming change (pmd.net.dpaa2) Ah, I think I completely forgot about that naming convention proposal. > > <...> > >> @@ -2045,3 +2046,12 @@ static struct rte_dpaa2_driver rte_dpaa2_pmd = { >> }; >> >> RTE_PMD_REGISTER_DPAA2(net_dpaa2, rte_dpaa2_pmd); >> + >> +RTE_INIT(dpaa2_pmd_init_log); >> +static void >> +dpaa2_pmd_init_log(void) >> +{ >> + dpaa2_logtype_pmd = rte_log_register("pmd.dpaa2"); > > After commit [1] naming changed to "pmd.net.dpaa2" > > [1] > Commit: 7db274b9ada2 ("doc: describe dynamic logging format") I will replace the net/eventdev/crypto registration strings > > <...> > >> +/* DP Logs, toggled out at compile time if level lower than current level */ >> +#define DPAA2_PMD_DP_LOG(level, fmt, args...) \ >> + RTE_LOG_DP(level, PMD, fmt, ## args) >> + >> +#define DPAA2_PMD_DP_DEBUG(fmt, args...) \ >> + DPAA2_PMD_DP_LOG(DEBUG, fmt, ## args) >> +#define DPAA2_PMD_DP_INFO(fmt, args...) \ >> + DPAA2_PMD_DP_LOG(INFO, fmt, ## args) >> +#define DPAA2_PMD_DP_WARN(fmt, args...) \ >> + DPAA2_PMD_DP_LOG(WARNING, fmt, ## args) > > Just a reminder about using RTE_LOG_DP without config wrapper to disable them, > not all code will be removed in compilation time, only ones with log_level > > RTE_LOG_DP_LEVEL, so with default config DPAA2_PMD_DP_WARN() ones will not be > removed. > This can be OK or not based on your usage but this may effect your datapath. I understand your point. Only some selected locations have WARN in dpaa2 - and those cases are non-ideal datapath. Nevertheless, thanks for highlighting. While creating a v2 for above registration string, I will re-consider this as well. > > <...> > Thanks for review.