From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1815FA056D; Tue, 3 Mar 2020 04:00:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22E691BFF3; Tue, 3 Mar 2020 04:00:03 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 423981BFF3; Tue, 3 Mar 2020 04:00:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 19:00:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,509,1574150400"; d="scan'208";a="386499840" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 02 Mar 2020 18:59:59 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Mar 2020 18:59:59 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 3 Mar 2020 10:59:57 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.1713.004; Tue, 3 Mar 2020 10:59:57 +0800 From: "Zhang, Xiao" To: "Ye, Xiaolong" CC: "Yigit, Ferruh" , "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] net/i40e: add promiscuous configure unsupported check Thread-Index: AQHV7edIhkmV9oC/skK099klVLtFL6g0gn+AgAGcoxD//4zBgIAAhvQQ Date: Tue, 3 Mar 2020 02:59:57 +0000 Message-ID: <0140d68aec194144b5d06637de7dee07@intel.com> References: <1582860124-48237-1-git-send-email-xiao.zhang@intel.com> <20200303025323.GE25927@intel.com> In-Reply-To: <20200303025323.GE25927@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Tuesday, March 3, 2020 10:53 AM > To: Zhang, Xiao > Cc: Yigit, Ferruh ; dev@dpdk.org; Xing, Beilei > ; Zhang, Qi Z ; stable@dpdk.= org > Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure unsupported c= heck >=20 > On 03/03, Zhang, Xiao wrote: > >Hi Ferruh, > > > >> -----Original Message----- > >> From: Yigit, Ferruh > >> Sent: Monday, March 2, 2020 5:09 PM > >> To: Zhang, Xiao ; dev@dpdk.org > >> Cc: Xing, Beilei ; Zhang, Qi Z > >> ; stable@dpdk.org > >> Subject: Re: [dpdk-dev] net/i40e: add promiscuous configure > >> unsupported check > >> > >> On 2/28/2020 3:22 AM, Xiao Zhang wrote: > >> > Return ENOTSUP error code when configuring i40evf promiscuous mode > >> > to fix port start hang issue on platforms which are unsupported to > >> > configure promiscuous mode. > >> > >> Hi Xiao, > >> > >> What is the cause of the hang, was the application keep trying > >> because of the "- EAGAIN" error? > > > >When starting port, rte_eth_dev_start will call rte_eth_dev_config_resto= re in > which promisc configure will be called to enable/disable promiscuous mode= . > >Since "-EAGAIN" was returned if platforms not supported to configure pro= misc > mode, it would return error and stop port starting. >=20 > So the real issue caused by this is "Fail to start port", not "hang", rig= ht? > I can change the description in the commit log directly. Yes, it's "Fail to start port". Thanks Xiaolong helping correct the commit = log. >=20 > Thanks, > Xiaolong