From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 43D8A7CD2; Thu, 13 Sep 2018 15:01:01 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E00D3082B71; Thu, 13 Sep 2018 13:01:00 +0000 (UTC) Received: from [10.36.112.13] (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12704104255A; Thu, 13 Sep 2018 13:00:57 +0000 (UTC) To: Anatoly Burakov , dev@dpdk.org Cc: tiwei.bie@intel.com, ray.kinsella@intel.com, zhihong.wang@intel.com, kuralamudhan.ramakrishnan@intel.com, stable@dpdk.org References: <3ab2d0a7cf61d800e1b4bc8571d79e5a113e0dd7.1536073997.git.anatoly.burakov@intel.com> From: Maxime Coquelin Message-ID: <0149c18a-d1dc-b52d-bb23-092b17a9c8c9@redhat.com> Date: Thu, 13 Sep 2018 15:00:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3ab2d0a7cf61d800e1b4bc8571d79e5a113e0dd7.1536073997.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 13 Sep 2018 13:01:00 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 1/9] fbarray: fix detach in noshconf mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 13:01:01 -0000 On 09/04/2018 05:15 PM, Anatoly Burakov wrote: > In noshconf mode, no shared files are created, but we're still trying > to unlink them, resulting in detach/destroy failure even though it > should have succeeded. Fix it by exiting early in noshconf mode. > > Fixes: 3ee2cde248a7 ("fbarray: support --no-shconf mode") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/common/eal_common_fbarray.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Maxime Coquelin