Re: [PATCH v5 13/15] net/xsc: add basic stats ops

["WanRenyong" <wanry@yunsilicon.com>]

[-- Attachment #1: Type: text/plain, Size: 2978 bytes --]

On 2025/1/17 1:58, Stephen Hemminger wrote:
>  
On Tue, 07 Jan 2025 10:50:09 +0800
> "WanRenyong" <wanry@yunsilicon.com><wanry@yunsilicon.com> wrote:
> 
> 
>  
 
Implement xsc ethdev basic statatics ops.
> 
> 
> Signed-off-by: WanRenyong <wanry@yunsilicon.com><wanry@yunsilicon.com>
> ---
>  doc/guides/nics/features/xsc.ini |  1 +
>  drivers/net/xsc/xsc_ethdev.c     | 75 ++++++++++++++++++++++++++++++++
>  2 files changed, 76 insertions(+)
> 
> 
> diff --git a/doc/guides/nics/features/xsc.ini b/doc/guides/nics/features/xsc.ini
> index 772c6418c4..eb88517104 100644
> --- a/doc/guides/nics/features/xsc.ini
> +++ b/doc/guides/nics/features/xsc.ini
> @@ -11,6 +11,7 @@ L3 checksum offload  = Y
>  L4 checksum offload  = Y
>  Inner L3 checksum    = Y
>  Inner L4 checksum    = Y
> +Basic stats          = Y
>  Linux                = Y
>  ARMv8                = Y
>  x86-64               = Y
>  
 
The driver is also doing per-queue stats.
> Mind of I just add that here as well.
> 
> 
> The definition of what that means was updated to be:
> 
> 
> Stats per queue
> ---------------
> 
> 
> Supports per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors.
> Statistics only supplied for first ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` (16) queues.
> 
> 
>  
 Yes, thanks for your reminder, I will add it next time.
>  
 
 
diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c
> index 9cfb07b023..000e27222d 100644
> --- a/drivers/net/xsc/xsc_ethdev.c
> +++ b/drivers/net/xsc/xsc_ethdev.c
> @@ -444,6 +444,79 @@ xsc_ethdev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
>          return 0;
>  }
>  
+static int
> +xsc_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
> +{
> +        struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev);
> +        uint32_t rxqs_n = priv->num_rq;
> +        uint32_t txqs_n = priv->num_sq;
> +        uint32_t i, idx;
> +        struct xsc_rxq_data *rxq;
> +        struct xsc_txq_data *txq;
> +
> +        for (i = 0; i < rxqs_n; ++i) {
> +                rxq = xsc_rxq_get(priv, i);
> +                if (unlikely(rxq == NULL))
> +                        continue;
> +
> +                idx = rxq->idx;
> +                if (idx < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> +                        stats->q_ipackets[idx] += rxq->stats.rx_pkts;
> +                        stats->q_ibytes[idx] += rxq->stats.rx_bytes;
> +                        stats->q_errors[idx] += (rxq->stats.rx_errors +
> +                                                 rxq->stats.rx_nombuf);
>  
 
Paren not needed here, but ok.
>  
 Agree with you, I will remove it next time.
>  
 


-- 
Thanks,
WanRenyong

[-- Attachment #2: Type: text/html, Size: 10692 bytes --]