From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2B2B41396 for ; Fri, 9 Jun 2017 10:56:17 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2017 01:56:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,317,1493708400"; d="scan'208";a="96248059" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 09 Jun 2017 01:56:15 -0700 To: Gaetan Rivet , dev@dpdk.org References: From: Ferruh Yigit Message-ID: <015f5ab0-1936-44f3-a60e-f4ff9f377262@intel.com> Date: Fri, 9 Jun 2017 09:56:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 08/12] kni: disabled by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 08:56:18 -0000 On 6/8/2017 12:59 AM, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > config/common_linuxapp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index b3cf41b..cc85cc6 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -38,7 +38,7 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y > CONFIG_RTE_EAL_IGB_UIO=y > CONFIG_RTE_EAL_VFIO=y > CONFIG_RTE_KNI_KMOD=y > -CONFIG_RTE_LIBRTE_KNI=y > +CONFIG_RTE_LIBRTE_KNI=n > CONFIG_RTE_LIBRTE_PMD_KNI=y > CONFIG_RTE_LIBRTE_VHOST=y > CONFIG_RTE_LIBRTE_PMD_VHOST=y > Hi Gaetan, We shouldn't just disable components that doesn't compile. And what happens when it is enabled, not compiled at all? So you are literally breaking the existing support with your patch? Thanks, ferruh