From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B280A00C5; Mon, 14 Feb 2022 14:36:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35D4340DDA; Mon, 14 Feb 2022 14:36:52 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id C98BE4067E for ; Mon, 14 Feb 2022 14:36:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644845810; x=1676381810; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=tVPyN4hqeN3Vre3/Czejbp4ZwfyLlcuAWOi4xPOIe5U=; b=N54dA4vIKdjxyDjoFhEjlb3xtLHbc27wFMYFykckTHFq9js00Yuo0V5u PVYIXHVD/qyOIqO/i6BBH4bfYJJOWir74wB5vDywMALr+MKfeU4gDHfKt VMgWKm/FYkUxjOBgTq5RUCYM+ZxInSpkx5sve7isLWWQ+46YMwXzrne4r 5PJ3sNugbOSfHHpFpBF6uBX9BaJARUluEXVRpnQYSkwBE75dqpxajIiE0 Jy1ZUJCe/S07/u9GYgqMPY0DrOsyKEnR93jwbJrVneWQqVGCRaab+EVpi Y3SIjtg7BJqx+Go6RLVz3lrNWE1suqcFJIhAMs7au8wyQcMedFpCU/QXv g==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="230726355" X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="230726355" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 05:36:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="485464487" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 14 Feb 2022 05:36:49 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 05:36:49 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 05:36:48 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 05:36:48 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 05:36:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQTriBn936Pipc2Ci2sl5hQ1q7lKYlkUb0S9BTN9qp+uEroHdU0T/+LbVUSc08i8rAv1KOoIHHxOOA4iBggJ91RU6BRzXMqBM5NpX1yMZGIBPGbydmlHd7CbdKy7AC4OO6SD0O93ILBnojX34CEu7Z+QhaaO8QhmnHVmCw/ws24JAhKDDNjibFYSfPuZk05RW9GtlA7Bka931Ygzanek9PwxbsBndv3+6UaOUL4ZUEQJOfKdtUZ6BbZNJzrtUAEUVgHZotWYh3E3yvE+TGh0Mrrsg2HaLcFyyyYXyWz50JaP7Maq7vNafytxbzA/ZuovLxgnMRhi9UV8xMkaCEAwBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tyKF+MBacaThLcvATnJvOVwUIrgzvsYbyY2ki+1runc=; b=H1IIzyLLt2S/gS1WBdtZ1GaE1sP6lWtRLZEg3mnQZ8zPHm86wDB7zU9Wxg4NCpn89UVPLZMgDGS3h7HrHgEFdsqZbXnN48MbXzEGsNl+4zov8/4yGJalglqV5CU3Hr4vfH7sUsWg512LU4dO7cjIwJ5ygwPCsSI6VCfuzgahe2QEwqdNNTfqS6U69WTHy63Cpe439Cg/ijtPOLMV0K5gKNYq1MkPYe7TBGpfsHYqL5AFy6rdcguZ12tUI2AaCrkfXask3nuZK3sE0uGBITuOBGHmgdrRlbeKNsp9h0LmqTIK084+5BosBNPbmeLSp7Fw4ATpSubC6qpgK827DeiRHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB1965.namprd11.prod.outlook.com (2603:10b6:300:110::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Mon, 14 Feb 2022 13:36:47 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022 13:36:47 +0000 Message-ID: <01628a95-64e4-e416-413d-5b4623b38a85@intel.com> Date: Mon, 14 Feb 2022 13:36:42 +0000 Subject: Re: [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching Content-Language: en-US To: , References: <20220214112541.29782-1-spinler@cesnet.cz> <20220214112541.29782-5-spinler@cesnet.cz> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220214112541.29782-5-spinler@cesnet.cz> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0384.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f124145-65c4-4147-f9b4-08d9efbf0c4d X-MS-TrafficTypeDiagnostic: MWHPR11MB1965:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:530; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2TlaRHZQu4XxXI8BOrf3HuPVREoAFl/g4z0hL4sSqOUxrWVRQdaGilFFKhTvEl6YNbihaQOMFSxB9TF6iIE/XKhNKRABMkYhs7o2lKqhueaJ+fuRoFzmJd/ruvs0UPYYLQHP1JvNrQsF6oGq9s2AYjD3b50k86yQjVgRdFilBeBh3ep0vFbSvxWmKmIefBhguv2khlcgY3diFPQyj+Rnbv+Zbm4iAdWjAMF9h43yJwpY9FhWRFGlDJgtxb6R9OuICx/nZgog3T/4KmRjUmIZNG8baQblL7VPO0Fx4wU6ZWt1x+kx85WVktUQVJpw7vDX6G4aLtdIJS0WlSiO0Gkm5H4xWn01JxL+Yg/dRr+tR9BwdGBu8jKJ5x980q58UKHWbzrRA5sZ8/Wp08Q4DylJDuU3vBtOP/MjE7oWF7akUCD5p8bRhRsTnAFey9n44cv3rzPq6GpBJoLEr4owR2R82fredC0fpvpLZozgh7h+C/9k89hHN5ZNN7jmt1QxnTUlgLRIE5QVLSgKhd6nPC3tO6RdQkRPV0xGoO5/rxdKk/MBRByNg1xCmzcoJwQGVqRqAgKwNFugqXj89+IlMmXRzahieiM5gwjXW8tnFWW9sjcJcAJAmE0EsE69RMTEmjHp/JnhtBKw4+XFmiKN9zLe6vC/8qym8ry5iy4C0pD7DkbBhJSDzIson+Q8066chC/smfFgdR5Dwis+rwU4SJXBaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(38100700002)(4744005)(44832011)(53546011)(6666004)(8936002)(66946007)(66556008)(6486002)(36756003)(8676002)(66476007)(508600001)(6506007)(186003)(2616005)(31686004)(26005)(31696002)(86362001)(83380400001)(5660300002)(2906002)(316002)(6512007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emtNV2ZON0Y5THlzYU53SXU3clFBL2IzdDA2TEdKUHJ0QU5DV3dubGN1UkZm?= =?utf-8?B?c3ExL2wxM3BscHZLZUptRXVaellnVkhyUGJqNjcyM0s5ZGxWYXdUMG5GUDJ0?= =?utf-8?B?TWg0cWpNU0EySXlERGd3ZytwTHZUeHpicWhaN24zbnRzRnMvdGY5eFh6NFRV?= =?utf-8?B?MlpwSzVuR29YQUJ4ZTVRWDduNXFneHRYeDZpL0t3UGJOSlcvVmVpYTR6SDZU?= =?utf-8?B?SGk1S1M3dElsNnJ0c3FKV0prckxMTkp4ejJKQ3BEbkgxeHVpdnpxQ2JqM0M3?= =?utf-8?B?YWZuME1PNHBOa2FRUDJZWXZwelJXd0Y5cXhpYzl2WDFrajlHcjZJcEdUbmM2?= =?utf-8?B?NWhlNGFJYjl1NzVYVjd6R0xZK00yM2ZRQmdXNWRVN1hlLzlHdExlNC9mM3ZH?= =?utf-8?B?VmJEaVo0NmhOVVlvZ1EyeEFsZHVHeG8xaFhxTEs1bDhIMnAzUC93RTFJMFN0?= =?utf-8?B?MUVlZi9YajJFY3JoM1JSayt6S0NRUTlQKy9XRTRuWGlQSlhqZUFBTnFjZWxB?= =?utf-8?B?c3J1aTJxZHdhS2oxT3NPbVh2a056YXp4a0NNZ0YwSWpaTXI4a0pYWmJxQmUw?= =?utf-8?B?dFAzZTkyelZCUmF2bXNhc3FwZytFNHJiNG4yby9UYjJ2ZEloMEh5b2VBelor?= =?utf-8?B?ajR4SmNkZFg0bFBOTzNwV250MlFiazE5M2o2TGpTaEJqQ0ZzWXpBZ1lLUE1v?= =?utf-8?B?eDFsNWtQVkNRL1FTcGpEakMvMGUzY0xaMzJMNlhtN3Y3RGFwMnNwcTJZNGYy?= =?utf-8?B?ODNXT3ZjQ1hiNmw5dlpsK21xV0cyTmhOaDg0ZG5DbXpKc3MvOTBQQ2gza1Q1?= =?utf-8?B?VGtteEYrV1BxbkJXNllPa0Z2aWtxTTdSeUwzWGNEeVNUbGw4MTJZS3RKeVpj?= =?utf-8?B?dnFMeU9mMXdCMjlRRzZPUlJrZzkramhwWTl0RU1Ia2g4NGlQaUZPM09yQk1l?= =?utf-8?B?K0cwSFEzSEJoRkw5c1pnckZGM3RNdGxoVGFJaUdrWVpuVCtFeG5oMWxiT2p3?= =?utf-8?B?TS9XdXk0SWRnMlo5RHF5Y0txZ1lpSGJzdUJQa1A4ODRzTU1vWnJnY1BKWjJr?= =?utf-8?B?L1JtRGhMN0tzREY3Nno2M284TkovZVBrdlQ4WlZIalNSL3hUMWg5RnBWYUdo?= =?utf-8?B?cDU4TEVmdjBEMjJCUGl3eDZobUFETkRHQ3Yva2dTRTJyNVlQN1ZoOTRCNldt?= =?utf-8?B?TmFEVTRpNXJ3TEFkQ213dkZkVFFseUVXYjZ5blI2TTBuNnFTQSt2cThjVXZC?= =?utf-8?B?OWJIUmlGeGtGTVJqNDNPYXBrdklQTHBwTEJOdDFYK1RwWk5kek5oOTBERnR6?= =?utf-8?B?NW45TEhQckV6Yjl2c2Jyd2NHNDhVSE5Cc1p0bFlaQkZucmpxZnRMM2VkdEVj?= =?utf-8?B?NVVRa240R1dDbllDYkJLSU4vekJCTmIwMEIvRWhKemxlRm9iRzl1aERXQmZ5?= =?utf-8?B?eVdoam4xaFp1Ky9TcDVJSWhlZmZ2WkRubkQwcUJ4aVdYS1g3WHJOTVZ2aU4z?= =?utf-8?B?SlFDZ2lwY0VLaStTRnNoVGhuZnZ0cHc2NkRPMHNzNjVFK2dPNkRDY0xaMTE4?= =?utf-8?B?Z251ck9ncng3dGtxenp0dytDeTFkUTkrbVlIWVByNlpPbHBTOHR0ODhHRktJ?= =?utf-8?B?SFp4QklyaHNOcldWUW1PY0hXTkE5eTY0Q0Y3QkdhR1FuNmlSSTNVcUhSK2Z5?= =?utf-8?B?aXV4NWJJT0lCL1Y5ODYvb2FyY1dCZS8wdjViaEkwSldseWNzdmQyRTlkckJJ?= =?utf-8?B?UVY0RGMwL21nSnp1aHp0YnBpaFB3KzBzNmRHS1FGcndLRXpKbENLLzJpRmZQ?= =?utf-8?B?aUltVTJsU2s4Q1NRTUt6WjZXd2hvT1I0ZnQ2RkR2WWp3eHhCSWpoZTNrMkxm?= =?utf-8?B?VWlyVDl2V2NqUUVpZUJhR1RqR0hEZWpxcDNiRXFzZ3pMMjJoZmFxd2hKUVhC?= =?utf-8?B?ZVFTNmd2ZklGb1lWblhmMmU5TS9hRU54eExxNVE5ckx6a2JEOGtXVHIyQ0pC?= =?utf-8?B?R1F6ZDNFdkJuYVk5bEZGRXJrTll3U0g3TmliL1pibUUvZUtoc2Q2b1pPQndC?= =?utf-8?B?OFdRdXdCZUVXOEdEUjdVc3M5MjgxbjFaeVdha3hDcWxpclYxQVRaVGE3YXZ4?= =?utf-8?B?aTVjNll3c01Ddm5rdkFreFVsbE1GQ01kTmhhVDBybWhTc0tGUWlDNlZnenZC?= =?utf-8?Q?I2ZOAaIPtguP2bevXBrCcDM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9f124145-65c4-4147-f9b4-08d9efbf0c4d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:36:47.6520 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o4gMqFIDC1fNbp0QBCg///CQYdmK7ofgRZO3Fg9VkrtV6murihSqcIJDF3Uu8Ho7NCRrMsDtBkXq3Z6XJRu5dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1965 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote: > From: Martin Spinler > > In the firmware, the promisc mode overrides the multicast mode. > So when the promisc mode is turned off, driver must check if the > multicast mode was active before and conditionally reactivate it. > Can you please add fixes & stable tags. > Signed-off-by: Martin Spinler > --- > drivers/net/nfb/nfb.h | 4 ---- > drivers/net/nfb/nfb_ethdev.c | 1 - > drivers/net/nfb/nfb_rxmode.c | 20 ++++++++------------ > 3 files changed, 8 insertions(+), 17 deletions(-) > <...>