From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36824A0C46; Fri, 18 Jun 2021 15:41:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08423410EE; Fri, 18 Jun 2021 15:40:50 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 26F184111D for ; Fri, 18 Jun 2021 15:40:47 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D4D837F4F3; Fri, 18 Jun 2021 16:40:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D4D837F4F3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1624023646; bh=HD89lZ/FT5eaW2ZxoE8pawOPM1QlqdXekb324Y96AaU=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=yA6szPuR9JT7LzZrGXEWQ4d6ieLOX3tkH6+p1xeEGerbKkWxPZJCcXp5uUHnSLiCV +RBvP3PWoyR/ZOdTGJ3bgee+ZyR0BCVDoRN4D2w0t+/bUhFBEAEaVscojTVyjFHcl2 9I87v4+ssU6+n2V2khucTFPiVPqbwpVLMtYGQRS4= To: David Marchand Cc: dev References: <20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru> <20210604142414.283611-1-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <016ae040-579b-3ef3-c011-a873250b4c12@oktetlabs.ru> Date: Fri, 18 Jun 2021 16:40:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 00/20] net/sfc: support flow API COUNT action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/17/21 11:37 AM, David Marchand wrote: > Hello Andrew, > > On Fri, Jun 4, 2021 at 4:24 PM Andrew Rybchenko > wrote: >> >> Update base driver and support COUNT action in transfer flow rules. >> >> v2: >> - add release notes >> - add missing documentaion >> - fix spelling >> - handle query in stopped gracefully > > I see build issues in the CI. > Can you have a look? > > gcc -Idrivers/libtmp_rte_net_sfc.a.p -Idrivers -I../drivers > -Idrivers/net/sfc -I../drivers/net/sfc -Ilib/ethdev -I../lib/ethdev > -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include > -Ilib/eal/linux/include -I../lib/eal/linux/include > -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common > -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs > -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry > -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf > -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter > -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci > -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev > -I../drivers/bus/vdev -Idrivers/common/sfc_efx > -I../drivers/common/sfc_efx -Idrivers/common/sfc_efx/base > -I../drivers/common/sfc_efx/base -fdiagnostics-color=always -pipe > -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include > rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat > -Wformat-nonliteral -Wformat-security -Wmissing-declarations > -Wmissing-prototypes -Wnested-externs -Wold-style-definition > -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef > -Wwrite-strings -Wno-packed-not-aligned > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation > -Wno-strict-aliasing -Wdisabled-optimization -Waggregate-return > -Wbad-function-cast -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.sfc -MD -MQ > drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_flow.c.o -MF > drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_flow.c.o.d -o > drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_flow.c.o -c > ../drivers/net/sfc/sfc_flow.c > ../drivers/net/sfc/sfc_flow.c: In function ‘sfc_flow_query’: > ../drivers/net/sfc/sfc_flow.c:2815:19: error: ‘SFC_ETHDEV_STARTED’ > undeclared (first use in this function); did you mean > ‘SFC_ADAPTER_STARTED’? > if (sa->state != SFC_ETHDEV_STARTED) { > ^~~~~~~~~~~~~~~~~~ > SFC_ADAPTER_STARTED > ../drivers/net/sfc/sfc_flow.c:2815:19: note: each undeclared > identifier is reported only once for each function it appears in > > $ git grep SFC_ETHDEV_STARTED > drivers/net/sfc/sfc_flow.c: if (sa->state != SFC_ETHDEV_STARTED) { Thanks David, my bad. Quick fixup without build check before sending. I'll fix it in v3 and send it shortly.