From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 985F21B4CE; Tue, 16 Apr 2019 16:29:59 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 102C1C00735B; Tue, 16 Apr 2019 14:29:55 +0000 (UTC) Received: from [10.36.117.214] (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4D9D5D9CA; Tue, 16 Apr 2019 14:29:53 +0000 (UTC) To: Bruce Richardson , dev@dpdk.org Cc: Ferruh Yigit , Reshma Pattan , "stable@dpdk.org" References: <20190116124836.40132-1-bruce.richardson@intel.com> <20190117173032.42076-1-bruce.richardson@intel.com> From: Kevin Traynor Message-ID: <0170cda4-fe5b-a8f1-d3b5-64d6504ea43a@redhat.com> Date: Tue, 16 Apr 2019 15:29:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190117173032.42076-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 16 Apr 2019 14:29:55 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3] eal: support strlcat function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 14:30:00 -0000 On 17/01/2019 17:30, Bruce Richardson wrote: > Add the strlcat function to DPDK to exist alongside the strlcpy one. > While strncat is generally safe for use for concatenation, the API for the > strlcat function is perhaps a little nicer to use, and supports truncation > detection. > > See commit 5364de644a4b ("eal: support strlcpy function") for more > details on the function selection logic, since we only should be using the > DPDK-provided version when no system-provided version is present. > > Signed-off-by: Bruce Richardson > Reviewed-by: Ferruh Yigit Hi - I'd like to backport this to 18.11 stable branch. Not having it is starting to cause build failures with backports. Let me know if any objection. thanks, Kevin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2EE67A00E6 for ; Tue, 16 Apr 2019 16:30:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B94531B4D3; Tue, 16 Apr 2019 16:30:01 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 985F21B4CE; Tue, 16 Apr 2019 16:29:59 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 102C1C00735B; Tue, 16 Apr 2019 14:29:55 +0000 (UTC) Received: from [10.36.117.214] (ovpn-117-214.ams2.redhat.com [10.36.117.214]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4D9D5D9CA; Tue, 16 Apr 2019 14:29:53 +0000 (UTC) To: Bruce Richardson , dev@dpdk.org Cc: Ferruh Yigit , Reshma Pattan , "stable@dpdk.org" References: <20190116124836.40132-1-bruce.richardson@intel.com> <20190117173032.42076-1-bruce.richardson@intel.com> From: Kevin Traynor Message-ID: <0170cda4-fe5b-a8f1-d3b5-64d6504ea43a@redhat.com> Date: Tue, 16 Apr 2019 15:29:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190117173032.42076-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 16 Apr 2019 14:29:55 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3] eal: support strlcat function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416142952.kkgQsKFeBZDMl4SdXGCygtmnqmBsWmosTiQdVX4A3n8@z> On 17/01/2019 17:30, Bruce Richardson wrote: > Add the strlcat function to DPDK to exist alongside the strlcpy one. > While strncat is generally safe for use for concatenation, the API for the > strlcat function is perhaps a little nicer to use, and supports truncation > detection. > > See commit 5364de644a4b ("eal: support strlcpy function") for more > details on the function selection logic, since we only should be using the > DPDK-provided version when no system-provided version is present. > > Signed-off-by: Bruce Richardson > Reviewed-by: Ferruh Yigit Hi - I'd like to backport this to 18.11 stable branch. Not having it is starting to cause build failures with backports. Let me know if any objection. thanks, Kevin.