From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D099A0C43; Fri, 1 Oct 2021 00:08:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FA584067E; Fri, 1 Oct 2021 00:08:13 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 2C0044067A for ; Fri, 1 Oct 2021 00:08:10 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="310842822" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208,217";a="310842822" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 15:08:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208,217";a="709247097" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 30 Sep 2021 15:08:09 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 15:08:08 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 15:08:06 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 15:08:06 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 15:08:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fjby9UjQPxL7OCalMyJ1+uCC8fSerpBS8/CkxBSlj6NB+6ERDa0Iy5hToAg8F+H8f7DnLcT9WR7VQ7UJ94SLPq126bkXm8irEYU4QjJE6NDEf90SxnnV7i8Brj7lwfPgVDZT2PNCR3CYxxmvgdJk/6ONSH5Yvk9ieyguM+oYurKq3fBTHORP8qx4KHnHx/rFWnItcfANXEPi710U9xufh57jqj36b+nkVkNgGmZWaQOUe7V9Ciu4BS8s+tfCyg6BdQja1ExkwgPOaxwL1KXSTfMWHeESPWwQNFbNAjL8yWDph9dY5hYITUTql71OvEZkUmbmMq+g2SsIdO/qtbgNvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wT5vdx8ivkNLiz2hn7ZaipTZrNhW7tiAyaqxGqMKqo0=; b=itIPO9xzpfpQ5gg3Iwd4TAlju7nIZSW+d12oXdVWXW3gokcc/Dc8C+QmqQrK2na+JCYXWgwjI3ACR75aOugs3QvunDOWLI2fCXzhQzoij7MWDCd+nFZukB6EpwLnW/cMfXvqFXf4cV4u2A0k+2WmJ9yAsu8WS8hEInbhy6p8A3NbFKldXhGszOfEOToqZKHK0DGLi0ZbCKhzXqHKuzQdhRYPjppGDFzWsltvyPEkVlSFZQtcLjCpUmabGQxAVkFY14G/PzzTLkpkkKGFVwy2MjVRjbjcf3A/GyzDDy7ubjWZfKi5fahMiwYziks6gLeB80pxeQiVLrmF+F1h9lXYsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wT5vdx8ivkNLiz2hn7ZaipTZrNhW7tiAyaqxGqMKqo0=; b=VN6qB3MGlvaDk9FGK5a06NPD68KpxKr/P91UQjaer2f5aP7MLEOucvZ3jFwTgW4f6PCJJIABJPg1DRgTeDuygdQQvqvKOnngi2CSOabFT5n2CLGieUBdJKXvRj/FdcjOMCQvpo39giuJulkNYsog49VZXVZVSmHBFUFBdj0ngeU= Authentication-Results: mayadata.io; dkim=none (message not signed) header.d=none;mayadata.io; dmarc=none action=none header.from=intel.com; Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) by SN6PR11MB3102.namprd11.prod.outlook.com (2603:10b6:805:d1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Thu, 30 Sep 2021 22:08:01 +0000 Received: from SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e]) by SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e%7]) with mapi id 15.20.4566.014; Thu, 30 Sep 2021 22:08:01 +0000 To: Dmitry Kozlyuk , CC: Dmitry Malloy , Narcisa Ana Maria Vasile , Pallavi Kadam , Tyler Retzlaff , Nick Connolly References: <20210501171837.13282-1-dmitry.kozliuk@gmail.com> <20210526210147.1287-1-dmitry.kozliuk@gmail.com> <20210526210147.1287-5-dmitry.kozliuk@gmail.com> From: "Menon, Ranjit" Message-ID: <017c2682-4fd6-5fa3-08c3-3ad85d020560@intel.com> Date: Thu, 30 Sep 2021 15:07:58 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <20210526210147.1287-5-dmitry.kozliuk@gmail.com> Content-Language: en-US X-ClientProxiedBy: MWHPR19CA0096.namprd19.prod.outlook.com (2603:10b6:320:1f::34) To SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) MIME-Version: 1.0 Received: from [192.168.254.28] (50.39.109.205) by MWHPR19CA0096.namprd19.prod.outlook.com (2603:10b6:320:1f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13 via Frontend Transport; Thu, 30 Sep 2021 22:08:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99b76426-79ba-48fa-67d2-08d9845ec47f X-MS-TrafficTypeDiagnostic: SN6PR11MB3102: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0NNvLqRp+yp8hmjFAgoBD1JxttoowPjQpoE+xRpj1+cLHlVFUaLVwh3ZZNqw7YGbcSFfzfu10/072HV1ZFJZicQTzBSd5V+PkY+dcaw1tTSbromYsL5UWCM7uU8vgnm0yeVPcZ9da8aRqztmwoDtLY27PstRBiGbyaHchwmC78Maqt8lTaI3dVJItyd+zq9+6H1MYfuptF8inxakD8h4kV6x3O6DMi8lGUUuzxwELhVqcPAOkErijKPsW9iQQoPrDM5Qa2tKdT9CHxv8jUmN+9MA/lMwA3jMqPxHQwFQ5TuEaZ7yZ6JnytfmLeocGXxoddDDKsUjn7paoQ0HsU0khSBJ94RF6ZG7p8Fz6oEhkbJDl9nhTDawW0Kw3oeKdy8MMDkSoMpYSToCm5zlXbVy6kX/S8ZX3CueVTO7OoIUEQooB12altTQNereMsiRoruxOaBioAX7MKflXJjRwc+pdlv4mdU6trkIJcB39Fbrw2bVP0XxwBIpcOAf5O4nZmcrerN/zUJb2DQFA03xr5yxRey/62J+cqlNFYBf9EAS4C0Kd0DO0Nfcun8oHcpHzhZKwV77LG1VCu0DJvf5NmY95ux6zUxW0OvUEpXZajjRxzT1rj/irtYV10jI6Rrdl3i9ua9RHhp6FAqq2ITnryNks8BV8wQcx1SsemBw+PSekx994FjNYurjj19fGDAJVItlxjGk9gWqRb7l52BgWQDGXCf3kWtmha9LVTgClSbqD6+aLwecage19UGZYk/uLVmt3yLmEKRs4hdrv638VdblR0N+nPQOXT8vxVj+6yJHjAFyEoU2DVAl8yL+ki16tn1imdM/zpvO7ULLWF6cZPxVqQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(186003)(66946007)(66556008)(6486002)(5660300002)(31696002)(86362001)(31686004)(66476007)(966005)(2616005)(956004)(166002)(8936002)(2906002)(8676002)(38100700002)(33964004)(83380400001)(53546011)(508600001)(4326008)(54906003)(16576012)(316002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VERTcGN2MldJRmZEczE0c2UrRDBVRnVkWnFrWVhEVERSbnYwWXA2aVI0b2RR?= =?utf-8?B?bzlSM1Noa216UThWUzFJS1JqQ1JVK2RlTmZwdU5YMnJzZ0lDbnYvZGFyci9a?= =?utf-8?B?M3VMUHdsTHZadC96ZExTdTNTTWgzSlBYWDhkWEYxSWdGT2ovVWxCaU9xdWE5?= =?utf-8?B?bzVpNWJLMmN2OUZpTUs4cnpsQ3Vad1U0OXptK0pTV21XQ3c2R3lpblAvZFhi?= =?utf-8?B?cmxvUkVLQlRWcGRYTmt6VmJPdkxneVoxTThBb2pRaEdob0ZEbVJ2dU05TXJ3?= =?utf-8?B?azhUWC8wa2JiWnJGZWhneGdncGNXb2lKWXFtNXl6cDdBS0wxZS9sS0krRWVp?= =?utf-8?B?WXowQUsrZWw4dFJydEgxVlF6d3UyN1FWMG5pb2FjNEVTSEllR3NzWmU1Q0lI?= =?utf-8?B?bU05UGZLMFowNEVXeTN2alY2Qm42ZVgwcVFDcUR6REdxb1loZmptZVNkcHJV?= =?utf-8?B?OGZBRmRuYk0vK2xOMzZJY1BJR3ROOWhiQWxMRWt5TSswR0FsN3dZS3Z5WHBW?= =?utf-8?B?YXVUSGtBaGl1YjhpdWFSV25KU0R0NUZ6RW1RenpWU3pBUlhxTCttS2E1bU1H?= =?utf-8?B?cnNUaHJjbkdHeFZ6aEpyUjVqeEhBeW5Rc2praUdNMGQxVDZrYnQ4b3hJb2hh?= =?utf-8?B?Umc4VzdBc0RzY2NtNVozd2g3b3JVbDFOSG9XY2NJeEtKYUl0TlM0QVJFYklX?= =?utf-8?B?Slg0cXlOL1FEZEhDaHV0OTEyQkpWTVZxMGIvLzB0RU1zbVROZnY1aTl4U2Ns?= =?utf-8?B?OEpkSW9SMGt1WURkanprZXllQmxRQ2pXaDNpcFMyYUNEcndTTWJEZUUvWGVO?= =?utf-8?B?UnBRL2dGRHZ2NWptRzhhMU4yK3c0U1NqRDFIQ2tUYSt1QU4vT0V6Q04vVFU4?= =?utf-8?B?RGZpaVUxUkNVYU5JTVU0VnhFajh2T2hqQ0E1bnFXSy8zZmlNWTl2bVdEOGRF?= =?utf-8?B?Z2xBRTh6bXBKdS8zbGg5aVFxMGdLVjhOaHhFVHpzNWxlYTZ1dzh1T292dVJO?= =?utf-8?B?RVd5YnBvYjA0d3RLU0lvT2V2TWY4d2tEaWhuSDZHZk14SzZsYlhXV0lLN0g3?= =?utf-8?B?MzJvcVVkV05SZkxKM0Q0bHJqU25nY0p2S3RXNkJRNzVYQkdDWGxtK0tITVJG?= =?utf-8?B?UW1jYXpEem9seUVOMmtHRm5zTHRKdjFvd2wvNnQzbktlMUlZWWZOclFHaFdu?= =?utf-8?B?aTFsMkRPYlo1K1NNdUo0TDRrMU84S0U1bjE5QW5Qa1Vpd1d0cUw3VEYzVzAr?= =?utf-8?B?YUV0bXZqancxRkZQK3R1QlJ0cWx3ZmZjcHYvbkdYNU5JQXpJeHFUZkwzZE1x?= =?utf-8?B?SGYwK1VWMFI3QUR2d29DZ09BelZxV0xaSWdZQWZFMXVzVGpDRlZGR1lXeGJ0?= =?utf-8?B?NmlRczEzdGl1S1F0T1Vpd0dnUW9PQzNVend4ZWpWVGNJS0pNTHMrdkp3Q0U3?= =?utf-8?B?UDBlTklXYnlDR1pWNmRVMHlveFAvbFM2YkZ5QXlNQmdZcDZSYnZweDNmWDM2?= =?utf-8?B?bTVsdjBjV0trUFd1dmVka0VnbDBHVU9LVHFnS1paV3FJblBUY0tFajZGTXZv?= =?utf-8?B?RFB3dlh3bHVXRjhrTlV6N1VwczNldG8zVXhtY0w2ajhZZ0k3bHNyNUJmd3Ay?= =?utf-8?B?OEs5UmdTUHRoQWducVNPaDdNTHBYdFFkQUtNY2hON1ZHYStyRkRjaWduWnVV?= =?utf-8?B?bHVVWWxkR2htR2U4S0NhbXZNeUZjWUN1K1R0eDUxQmgyMHVYQk9tVWZtUWkx?= =?utf-8?Q?oPMSYo7/vxukCRy6nKxK3XM5h9X7UtFuNU2kvI3?= X-MS-Exchange-CrossTenant-Network-Message-Id: 99b76426-79ba-48fa-67d2-08d9845ec47f X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 22:08:01.0929 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7NdTvrUk/Q1fz6VcNNO631P/2FhSP+U3SNmZPGi+ZhMMo9u7/gfp9QJp0wYnTEZ75mD19U430ZVLX0wOcDXkzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3102 X-OriginatorOrg: intel.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, On 5/26/2021 2:01 PM, Dmitry Kozlyuk wrote: > WPP tracing [1] allows kernel drivers to print logs that can be viewed > without attaching a debugger to the running system. Traces are colelcted > only when enabled. Instrument virt2phys with traces: > * ERROR: failures that prevent the driver from working. > * WARNING: incorrect calls to the driver. > * INFO: starting or completing operations with memory. > > [1]: https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/wpp-software-tracing > > Signed-off-by: Dmitry Kozlyuk > --- > diff --git a/windows/virt2phys/virt2phys.vcxproj b/windows/virt2phys/virt2phys.vcxproj > index b462493..c9f884a 100644 > --- a/windows/virt2phys/virt2phys.vcxproj > +++ b/windows/virt2phys/virt2phys.vcxproj > @@ -41,6 +41,7 @@ > > > > + > > > > @@ -169,9 +170,9 @@ > > > > - false > + true > true > - trace.h > + virt2phys_trace.h This change is also required for the 'Release|x64' configuration, otherwise 'Release' builds fail. Also, it appears the newer version of the compiler (combined with the new version of WDK/SDK), requires that the driver signing process mandate a File Digest Algorithm (using the /fd option). It is a warning today, but they claim it could become a requirement in the future. To fix this, we can include the following in the project file:   SHA256 Or set the above, using project 'Properties'->Driver Signing->File Digest Algorithm = 256. (This will need to be fixed in the netuio driver project also) thanks, ranjit m.