DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/mana: disable driver by default
@ 2022-10-13 11:47 Ferruh Yigit
  2022-10-13 16:30 ` Long Li
  2023-01-19 14:49 ` Ferruh Yigit
  0 siblings, 2 replies; 10+ messages in thread
From: Ferruh Yigit @ 2022-10-13 11:47 UTC (permalink / raw)
  To: Thomas Monjalon, Long Li; +Cc: dev, Stephen Hemminger

Driver is disabled by default because its dependencies are not
upstreamed yet, code is available for development and investigation.

When all dependencies are upstreamed, driver can be enabled back.

Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")

Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Cc: Long Li <longli@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
---
 MAINTAINERS                            | 2 +-
 doc/guides/nics/index.rst              | 1 -
 doc/guides/rel_notes/release_22_11.rst | 2 ++
 drivers/net/meson.build                | 1 -
 4 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2bd4a55f1b0a..fe6c0a60b628 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -828,7 +828,7 @@ F: buildtools/options-ibverbs-static.sh
 F: doc/guides/nics/mlx5.rst
 F: doc/guides/nics/features/mlx5.ini
 
-Microsoft mana
+Microsoft mana - EXPERIMENTAL
 M: Long Li <longli@microsoft.com>
 F: drivers/net/mana/
 F: doc/guides/nics/mana.rst
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index 32c754496827..f80906a97d1b 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -41,7 +41,6 @@ Network Interface Controller Drivers
     intel_vf
     kni
     liquidio
-    mana
     memif
     mlx4
     mlx5
diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
index 2da8bc9661af..79bc36815659 100644
--- a/doc/guides/rel_notes/release_22_11.rst
+++ b/doc/guides/rel_notes/release_22_11.rst
@@ -142,6 +142,8 @@ New Features
 
 * **Added Microsoft mana driver.**
 
+  Disabled by default because of missing dependency.
+
 * **Updated Netronome nfp driver.**
 
   Added the needed data structures and logics to support flow API offload:
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 35bfa78dee66..37919eaf8b02 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -34,7 +34,6 @@ drivers = [
         'ixgbe',
         'kni',
         'liquidio',
-        'mana',
         'memif',
         'mlx4',
         'mlx5',
-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH] net/mana: disable driver by default
  2022-10-13 11:47 [PATCH] net/mana: disable driver by default Ferruh Yigit
@ 2022-10-13 16:30 ` Long Li
  2022-10-26 21:53   ` Thomas Monjalon
  2023-01-19 14:49 ` Ferruh Yigit
  1 sibling, 1 reply; 10+ messages in thread
From: Long Li @ 2022-10-13 16:30 UTC (permalink / raw)
  To: Ferruh Yigit, thomas; +Cc: dev, Stephen Hemminger

> Subject: [PATCH] net/mana: disable driver by default
> 
> Driver is disabled by default because its dependencies are not upstreamed
> yet, code is available for development and investigation.
> 
> When all dependencies are upstreamed, driver can be enabled back.
> 
> Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>

Acked-by: Long Li <longli@microsoft.com>

> ---
> Cc: Long Li <longli@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  MAINTAINERS                            | 2 +-
>  doc/guides/nics/index.rst              | 1 -
>  doc/guides/rel_notes/release_22_11.rst | 2 ++
>  drivers/net/meson.build                | 1 -
>  4 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2bd4a55f1b0a..fe6c0a60b628 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -828,7 +828,7 @@ F: buildtools/options-ibverbs-static.sh
>  F: doc/guides/nics/mlx5.rst
>  F: doc/guides/nics/features/mlx5.ini
> 
> -Microsoft mana
> +Microsoft mana - EXPERIMENTAL
>  M: Long Li <longli@microsoft.com>
>  F: drivers/net/mana/
>  F: doc/guides/nics/mana.rst
> diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst index
> 32c754496827..f80906a97d1b 100644
> --- a/doc/guides/nics/index.rst
> +++ b/doc/guides/nics/index.rst
> @@ -41,7 +41,6 @@ Network Interface Controller Drivers
>      intel_vf
>      kni
>      liquidio
> -    mana
>      memif
>      mlx4
>      mlx5
> diff --git a/doc/guides/rel_notes/release_22_11.rst
> b/doc/guides/rel_notes/release_22_11.rst
> index 2da8bc9661af..79bc36815659 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -142,6 +142,8 @@ New Features
> 
>  * **Added Microsoft mana driver.**
> 
> +  Disabled by default because of missing dependency.
> +
>  * **Updated Netronome nfp driver.**
> 
>    Added the needed data structures and logics to support flow API offload:
> diff --git a/drivers/net/meson.build b/drivers/net/meson.build index
> 35bfa78dee66..37919eaf8b02 100644
> --- a/drivers/net/meson.build
> +++ b/drivers/net/meson.build
> @@ -34,7 +34,6 @@ drivers = [
>          'ixgbe',
>          'kni',
>          'liquidio',
> -        'mana',
>          'memif',
>          'mlx4',
>          'mlx5',
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] net/mana: disable driver by default
  2022-10-13 16:30 ` Long Li
@ 2022-10-26 21:53   ` Thomas Monjalon
  2022-10-26 22:57     ` Ferruh Yigit
  0 siblings, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2022-10-26 21:53 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, Stephen Hemminger, Long Li

13/10/2022 18:30, Long Li:
> > Subject: [PATCH] net/mana: disable driver by default
> > 
> > Driver is disabled by default because its dependencies are not upstreamed
> > yet, code is available for development and investigation.
> > 
> > When all dependencies are upstreamed, driver can be enabled back.
> > 
> > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> 
> Acked-by: Long Li <longli@microsoft.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] net/mana: disable driver by default
  2022-10-26 21:53   ` Thomas Monjalon
@ 2022-10-26 22:57     ` Ferruh Yigit
  2022-10-27  6:13       ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Ferruh Yigit @ 2022-10-26 22:57 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Stephen Hemminger, Long Li

On 10/26/2022 10:53 PM, Thomas Monjalon wrote:
> 13/10/2022 18:30, Long Li:
>>> Subject: [PATCH] net/mana: disable driver by default
>>>
>>> Driver is disabled by default because its dependencies are not upstreamed
>>> yet, code is available for development and investigation.
>>>
>>> When all dependencies are upstreamed, driver can be enabled back.
>>>
>>> Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>
>> Acked-by: Long Li <longli@microsoft.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> 

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] net/mana: disable driver by default
  2022-10-26 22:57     ` Ferruh Yigit
@ 2022-10-27  6:13       ` Thomas Monjalon
  2022-10-27  9:04         ` Ferruh Yigit
  0 siblings, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2022-10-27  6:13 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, Stephen Hemminger, Long Li

27/10/2022 00:57, Ferruh Yigit:
> On 10/26/2022 10:53 PM, Thomas Monjalon wrote:
> > 13/10/2022 18:30, Long Li:
> >>> Subject: [PATCH] net/mana: disable driver by default
> >>>
> >>> Driver is disabled by default because its dependencies are not upstreamed
> >>> yet, code is available for development and investigation.
> >>>
> >>> When all dependencies are upstreamed, driver can be enabled back.
> >>>
> >>> Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
> >>>
> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> >>
> >> Acked-by: Long Li <longli@microsoft.com>
> > 
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > 
> > 
> 
> Applied to dpdk-next-net/main, thanks.

Looks like we cannot dereference the doc:
doc/guides/nics/mana.rst:document isn't included in any toctree



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] net/mana: disable driver by default
  2022-10-27  6:13       ` Thomas Monjalon
@ 2022-10-27  9:04         ` Ferruh Yigit
  0 siblings, 0 replies; 10+ messages in thread
From: Ferruh Yigit @ 2022-10-27  9:04 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Stephen Hemminger, Long Li

On 10/27/2022 7:13 AM, Thomas Monjalon wrote:
> 27/10/2022 00:57, Ferruh Yigit:
>> On 10/26/2022 10:53 PM, Thomas Monjalon wrote:
>>> 13/10/2022 18:30, Long Li:
>>>>> Subject: [PATCH] net/mana: disable driver by default
>>>>>
>>>>> Driver is disabled by default because its dependencies are not upstreamed
>>>>> yet, code is available for development and investigation.
>>>>>
>>>>> When all dependencies are upstreamed, driver can be enabled back.
>>>>>
>>>>> Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
>>>>>
>>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>>>
>>>> Acked-by: Long Li <longli@microsoft.com>
>>>
>>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>>>
>>>
>>
>> Applied to dpdk-next-net/main, thanks.
> 
> Looks like we cannot dereference the doc:
> doc/guides/nics/mana.rst:document isn't included in any toctree
> 
>

ack

Will fix in next-net, and add mana.rst back to index to remove the warning.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] net/mana: disable driver by default
  2022-10-13 11:47 [PATCH] net/mana: disable driver by default Ferruh Yigit
  2022-10-13 16:30 ` Long Li
@ 2023-01-19 14:49 ` Ferruh Yigit
  2023-01-19 15:56   ` Thomas Monjalon
  1 sibling, 1 reply; 10+ messages in thread
From: Ferruh Yigit @ 2023-01-19 14:49 UTC (permalink / raw)
  To: Thomas Monjalon, Long Li; +Cc: dev, Stephen Hemminger

On 10/13/2022 12:47 PM, Ferruh Yigit wrote:
> Driver is disabled by default because its dependencies are not
> upstreamed yet, code is available for development and investigation.
> 
> When all dependencies are upstreamed, driver can be enabled back.
> 
> Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
> Cc: Long Li <longli@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>


Hi Long,

I can see mana code is merged to rdma-core, and v44 has it. Are there
any more dependencies pending upstream for the driver?

If all dependencies met, can you please send a patch to revert this
patch, and to update documentation related to the correct version of
dependencies?


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] net/mana: disable driver by default
  2023-01-19 14:49 ` Ferruh Yigit
@ 2023-01-19 15:56   ` Thomas Monjalon
  2023-01-19 16:32     ` Long Li
  0 siblings, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2023-01-19 15:56 UTC (permalink / raw)
  To: Long Li, Ferruh Yigit; +Cc: dev, Stephen Hemminger

19/01/2023 15:49, Ferruh Yigit:
> On 10/13/2022 12:47 PM, Ferruh Yigit wrote:
> > Driver is disabled by default because its dependencies are not
> > upstreamed yet, code is available for development and investigation.
> > 
> > When all dependencies are upstreamed, driver can be enabled back.
> > 
> > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > ---
> > Cc: Long Li <longli@microsoft.com>
> > Cc: Stephen Hemminger <sthemmin@microsoft.com>
> 
> 
> Hi Long,
> 
> I can see mana code is merged to rdma-core, and v44 has it. Are there
> any more dependencies pending upstream for the driver?

What is the status of the kernel dependency?

> If all dependencies met, can you please send a patch to revert this
> patch, and to update documentation related to the correct version of
> dependencies?




^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH] net/mana: disable driver by default
  2023-01-19 15:56   ` Thomas Monjalon
@ 2023-01-19 16:32     ` Long Li
  2023-01-19 18:05       ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Long Li @ 2023-01-19 16:32 UTC (permalink / raw)
  To: Thomas Monjalon, Ferruh Yigit; +Cc: dev, Stephen Hemminger

> Subject: Re: [PATCH] net/mana: disable driver by default
> 
> 19/01/2023 15:49, Ferruh Yigit:
> > On 10/13/2022 12:47 PM, Ferruh Yigit wrote:
> > > Driver is disabled by default because its dependencies are not
> > > upstreamed yet, code is available for development and investigation.
> > >
> > > When all dependencies are upstreamed, driver can be enabled back.
> > >
> > > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build
> > > environment")
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > > ---
> > > Cc: Long Li <longli@microsoft.com>
> > > Cc: Stephen Hemminger <sthemmin@microsoft.com>
> >
> >
> > Hi Long,
> >
> > I can see mana code is merged to rdma-core, and v44 has it. Are there
> > any more dependencies pending upstream for the driver?
> 
> What is the status of the kernel dependency?

The kernel driver is merged in 6.2-rc3. I'm waiting for 6.2 to be released.

> 
> > If all dependencies met, can you please send a patch to revert this
> > patch, and to update documentation related to the correct version of
> > dependencies?
> 
> 

Is it okay to submit the patch now?

Thanks,
Long

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] net/mana: disable driver by default
  2023-01-19 16:32     ` Long Li
@ 2023-01-19 18:05       ` Thomas Monjalon
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2023-01-19 18:05 UTC (permalink / raw)
  To: Long Li; +Cc: Ferruh Yigit, dev, Stephen Hemminger

19/01/2023 17:32, Long Li:
> > Subject: Re: [PATCH] net/mana: disable driver by default
> > 
> > 19/01/2023 15:49, Ferruh Yigit:
> > > On 10/13/2022 12:47 PM, Ferruh Yigit wrote:
> > > > Driver is disabled by default because its dependencies are not
> > > > upstreamed yet, code is available for development and investigation.
> > > >
> > > > When all dependencies are upstreamed, driver can be enabled back.
> > > >
> > > > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build
> > > > environment")
> > > >
> > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > > > ---
> > > > Cc: Long Li <longli@microsoft.com>
> > > > Cc: Stephen Hemminger <sthemmin@microsoft.com>
> > >
> > >
> > > Hi Long,
> > >
> > > I can see mana code is merged to rdma-core, and v44 has it. Are there
> > > any more dependencies pending upstream for the driver?
> > 
> > What is the status of the kernel dependency?
> 
> The kernel driver is merged in 6.2-rc3. I'm waiting for 6.2 to be released.
> 
> > > If all dependencies met, can you please send a patch to revert this
> > > patch, and to update documentation related to the correct version of
> > > dependencies?
> 
> Is it okay to submit the patch now?

Yes you can.



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-01-19 18:05 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 11:47 [PATCH] net/mana: disable driver by default Ferruh Yigit
2022-10-13 16:30 ` Long Li
2022-10-26 21:53   ` Thomas Monjalon
2022-10-26 22:57     ` Ferruh Yigit
2022-10-27  6:13       ` Thomas Monjalon
2022-10-27  9:04         ` Ferruh Yigit
2023-01-19 14:49 ` Ferruh Yigit
2023-01-19 15:56   ` Thomas Monjalon
2023-01-19 16:32     ` Long Li
2023-01-19 18:05       ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).