From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8DCC92C55 for ; Fri, 21 Jul 2017 04:56:39 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jul 2017 19:56:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,387,1496127600"; d="scan'208";a="129997430" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 20 Jul 2017 19:56:37 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Jul 2017 19:56:22 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Jul 2017 19:56:22 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Fri, 21 Jul 2017 10:56:19 +0800 From: "Guo, Jia" To: "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix link down and negotiation issue Thread-Index: AQHTATR+BrEI7g1/zUyO/abw/2uVtaJdCNoAgACNq/A= Date: Fri, 21 Jul 2017 02:56:18 +0000 Message-ID: <01BA8470C017D6468C8290E4B9C5E1E83B245AED@shsmsx102.ccr.corp.intel.com> References: <1500540302-84503-1-git-send-email-jia.guo@intel.com> <9BB6961774997848B5B42BEC655768F810DCD3C2@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810DCD3C2@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjg3YzY5NGUtZWY3NC00MTgwLWFhNWYtMzZmYzYzNjA3NzAyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImYxbEh6OVpPVCtXK1wvNDdtZGxsMm1ENWtMWlhsMTUrTUtlcDhkVTNNSHdNPSJ9 dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix link down and negotiation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jul 2017 02:56:40 -0000 Yes, I have already use cpu_to_le32 to translator, but I agree first defend= it as uint32_t might be better to read . I will send v2 , thanks for revie= w. Best regards, Jeff Guo -----Original Message----- From: Wu, Jingjing=20 Sent: Friday, July 21, 2017 10:26 AM To: Guo, Jia ; Xing, Beilei Cc: dev@dpdk.org Subject: RE: [PATCH] net/i40e: fix link down and negotiation issue > -----Original Message----- > From: Guo, Jia > Sent: Thursday, July 20, 2017 4:45 PM > To: Xing, Beilei ; Wu, Jingjing=20 > > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH] net/i40e: fix link down and negotiation issue >=20 > Enable the functions set link down and set link up in i40e by check=20 > phy_type, and fix the issue of auto negotiation failed in XXV710 when=20 > bind kernel driver after unbind from dpdk driver by modify the speed=20 > setting distinguish from set link up and down. With this fix, if=20 > unbind dpdk to bind kernel driver, no need to set auto negotiation and if= confi up anymore, remove the part from doc. >=20 > Fixes: ca7e599d4506 ("net/i40e: fix link management") > Fixes: 2f1e22817420 ("i40e: skip link control as firmware workaround") > Fixes: 6e145fcc754b ("6e145fcc754b5e79167") What is this? Need to add title. How about to CC stable@dpdk.org? > enum i40e_status_code status; > struct i40e_aq_get_phy_abilities_resp phy_ab; > struct i40e_aq_set_phy_config phy_conf; > + enum i40e_aq_phy_type cnt; > + __le32 phy_type_mask =3D 0; Please define it as unit32_t, and use cpu_to_le32 when assigning,