From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4222C1B025 for ; Tue, 9 Jan 2018 12:39:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 03:39:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,335,1511856000"; d="scan'208";a="8284736" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 09 Jan 2018 03:39:40 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 03:39:39 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 19:39:38 +0800 From: "Guo, Jia" To: Thomas Monjalon CC: Mordechay Haimovsky , "dev@dpdk.org" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "gaetan.rivet@6wind.com" , "Ananyev, Konstantin" , "shreyansh.jain@nxp.com" , "Wu, Jingjing" , "Zhang, Helin" , "Van Haaren, Harry" Thread-Topic: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug Thread-Index: AQHTg64NCGld/5Q4vkCDiBeSUhVfHKNqNyqAgAEIWID//50NAIAABJUAgACTaUA= Date: Tue, 9 Jan 2018 11:39:37 +0000 Message-ID: <01BA8470C017D6468C8290E4B9C5E1E83B2D13F4@shsmsx102.ccr.corp.intel.com> References: <1509567405-27439-3-git-send-email-jia.guo@intel.com> <6b97ebc5-1ec5-a724-a620-96b23b126d01@intel.com> <2803089.mJXnisXhBj@xps> In-Reply-To: <2803089.mJXnisXhBj@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjdhY2RjYmQtNzUzOC00Y2JlLWFiZDYtZWNkMTc2OTdlYTgwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IktmMmtlTGxwOEVKa2VyeGwzbURNSXNkV0kwNUVcL2JMSHRvcFk0aFBONmVnPSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 11:39:42 -0000 So, how can separate the patch into more small patch, use stake or null imp= lement in function. I think we should consider if it is a economic way now,= if I could explain more detail in code for you all not very familiar the b= ackground? I have sent v8, please check, thanks all.=20 Best regards, Jeff Guo -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net]=20 Sent: Tuesday, January 9, 2018 6:48 PM To: Guo, Jia Cc: Mordechay Haimovsky ; dev@dpdk.org; stephen@network= plumber.org; Richardson, Bruce ; Yigit, Ferruh = ; gaetan.rivet@6wind.com; Ananyev, Konstantin ; shreyansh.jain@nxp.com; Wu, Jingjing ; Zhang, Helin ; Van Haaren, Harry Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug 09/01/2018 11:31, Mordechay Haimovsky: > From: Guo, Jia [mailto:jia.guo@intel.com] > > On 1/9/2018 8:39 AM, Thomas Monjalon wrote: > > > At last there is the kernel binding effort - this one will=20 > > > probably be ignored for 18.02, because it is another huge topic. > > > Without bothering with kernel binding, we can at least remove a=20 > > > device, get a notification, and eventually re-add it. It is a good fi= rst step. > > > Anyway your testpmd patch tests exactly this scenario (totally new=20 > > > devices are not seen). > >=20 > > i will separate it for you all to benefit for review. for kernel=20 > > binding, i just let it automatically compare with the first time=20 > > manually binding, and it is the part of he hot plug flow. so i=20 > > suggest to review more about that if it is not side effect and workable= , beg for keep on. >=20 > This will not work for Mellanox which uses several drivers and=20 > services in order to map the device and device queues to user space.=20 > For example, the mlx4 PMD (PMD for ConnectX-3 devices) requires that=20 > mlx4_core mlx4_en and mlx4_ib drivers to be loaded, and for RDM -core=20 > user-space libraries and daemons to be loaded. Yes automatic binding is a feature which requires more work. It cannot be ready for 18.02.