From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jia.guo@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7A6BB1B16D for <dev@dpdk.org>; Tue, 9 Jan 2018 13:08:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 04:08:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,335,1511856000"; d="scan'208";a="9000590" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 09 Jan 2018 04:08:55 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 04:08:55 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 04:08:55 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 20:08:53 +0800 From: "Guo, Jia" <jia.guo@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: Mordechay Haimovsky <motih@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com> Thread-Topic: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug Thread-Index: AQHTg64NCGld/5Q4vkCDiBeSUhVfHKNqNyqAgAEIWID//50NAIAABJUAgACTaUD//3x1gIAAi/vQ Date: Tue, 9 Jan 2018 12:08:52 +0000 Message-ID: <01BA8470C017D6468C8290E4B9C5E1E83B2D1493@shsmsx102.ccr.corp.intel.com> References: <1509567405-27439-3-git-send-email-jia.guo@intel.com> <2803089.mJXnisXhBj@xps> <01BA8470C017D6468C8290E4B9C5E1E83B2D13F4@shsmsx102.ccr.corp.intel.com> <3539603.0DoXzmkF5E@xps> In-Reply-To: <3539603.0DoXzmkF5E@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDcwM2QyNjgtNDRjNC00NDU2LWI4OTYtYzNhMGUxMDM1NmE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZocEJBRFk4b1o5NHo4UHBtcCtQYXFZdVN5anM5SnpyYUpXaVRJYitsaGc9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 09 Jan 2018 12:08:58 -0000 Your comments about split it totally make sense ,no doubt that, but my ques= tion is that if split api with the funcational , so the function part shoul= d be set null implement or stake. Any other good idea or tip for that.=20 Best regards, Jeff Guo -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net]=20 Sent: Tuesday, January 9, 2018 7:45 PM To: Guo, Jia <jia.guo@intel.com> Cc: Mordechay Haimovsky <motih@mellanox.com>; dev@dpdk.org; stephen@network= plumber.org; Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh = <ferruh.yigit@intel.com>; gaetan.rivet@6wind.com; Ananyev, Konstantin <kons= tantin.ananyev@intel.com>; shreyansh.jain@nxp.com; Wu, Jingjing <jingjing.w= u@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Van Haaren, Harry <harr= y.van.haaren@intel.com> Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug 09/01/2018 12:39, Guo, Jia: > So, how can separate the patch into more small patch, use stake or null i= mplement in function. I think we should consider if it is a economic way no= w, if I could explain more detail in code for you all not very familiar the= background? I have sent v8, please check, thanks all.=20 The v8 is not split enough. Please try to address all my comments.