From: "Guo, Jia" <jia.guo@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix input set for rss hash
Date: Sat, 9 May 2020 06:45:13 +0000 [thread overview]
Message-ID: <01BA8470C017D6468C8290E4B9C5E1E8405431C2@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061154812A32@SHSMSX103.ccr.corp.intel.com>
ok.
Best regards,
Jeff Guo
-----Original Message-----
From: Zhang, Qi Z <qi.z.zhang@intel.com>
Sent: Saturday, May 9, 2020 2:21 PM
To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>; dev@dpdk.org
Subject: RE: [PATCH] net/iavf: fix input set for rss hash
> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Friday, May 8, 2020 5:30 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Subject: [PATCH] net/iavf: fix input set for rss hash
>
> Since some specific rss hash type need to combine with the protocol
> hash type when configure a rss hash rule, so add the corresponding
> input set to support these case for iavf hash.
>
> Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
> drivers/net/iavf/iavf_hash.c | 96
> ++++++++++++++++++++++++++++++++++++
> 1 file changed, 96 insertions(+)
>
> diff --git a/drivers/net/iavf/iavf_hash.c
> b/drivers/net/iavf/iavf_hash.c index
> a1d0b8364..97370aa19 100644
> --- a/drivers/net/iavf/iavf_hash.c
> +++ b/drivers/net/iavf/iavf_hash.c
> @@ -594,11 +594,19 @@ struct iavf_hash_match_type
> iavf_hash_type_list[] = {
> /* IPV4 */
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L2_SRC_ONLY, &hdrs_hint_eth_src},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L2_DST_ONLY, &hdrs_hint_eth_dst},
> + {IAVF_PATTERN_HINT_IPV4, ETH_RSS_ETH | ETH_RSS_L2_SRC_ONLY,
> + &hdrs_hint_eth_src},
> + {IAVF_PATTERN_HINT_IPV4, ETH_RSS_ETH | ETH_RSS_L2_DST_ONLY,
> + &hdrs_hint_eth_dst},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_ETH, &hdrs_hint_eth},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_S_VLAN, &hdrs_hint_svlan},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_C_VLAN, &hdrs_hint_cvlan},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L3_SRC_ONLY, &hdrs_hint_ipv4_src},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L3_DST_ONLY, &hdrs_hint_ipv4_dst},
> + {IAVF_PATTERN_HINT_IPV4, ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY,
> + &hdrs_hint_ipv4_src},
> + {IAVF_PATTERN_HINT_IPV4, ETH_RSS_IPV4 | ETH_RSS_L3_DST_ONLY,
> + &hdrs_hint_ipv4_dst},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_ESP, &hdrs_hint_ipv4_esp},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_AH, &hdrs_hint_ipv4_ah},
> {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L2TPV3, &hdrs_hint_ipv4_l2tpv3}, @@
> -620,6 +628,23 @@ struct iavf_hash_match_type iavf_hash_type_list[] =
> {
> &hdrs_hint_ipv4_dst_gtpu_dwn},
> {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_L3_DST_ONLY,
> &hdrs_hint_ipv4_dst},
> + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 |
> ETH_RSS_L3_SRC_ONLY |
> + ETH_RSS_L4_SRC_ONLY, &hdrs_hint_ipv4_src_udp_src_port},
> + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 |
> ETH_RSS_L3_SRC_ONLY |
> + ETH_RSS_L4_DST_ONLY,
> &hdrs_hint_ipv4_src_udp_dst_port},
> + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 |
> ETH_RSS_L3_SRC_ONLY |
> + ETH_RSS_GTPU, &hdrs_hint_ipv4_src_gtpu_up},
> + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 |
> ETH_RSS_L3_SRC_ONLY,
> + &hdrs_hint_ipv4_src},
> + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 |
> ETH_RSS_L3_DST_ONLY |
> + ETH_RSS_L4_SRC_ONLY,
I think the protocol type should be ETH_RSS_NONFRAG_IPV4_UDP if level 4 modification is involved.
And similar change also need be applied to TCP/SCTP...
next prev parent reply other threads:[~2020-05-09 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 21:29 Jeff Guo
2020-05-09 6:20 ` Zhang, Qi Z
2020-05-09 6:45 ` Guo, Jia [this message]
2020-05-09 19:29 ` [dpdk-dev] [dpdk-dev v2] " Jeff Guo
2020-05-09 7:30 ` Zhang, Qi Z
2020-05-11 2:37 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01BA8470C017D6468C8290E4B9C5E1E8405431C2@shsmsx102.ccr.corp.intel.com \
--to=jia.guo@intel.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).