From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0623A046B; Sat, 9 May 2020 08:45:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32E091D942; Sat, 9 May 2020 08:45:21 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1D8951D939 for ; Sat, 9 May 2020 08:45:18 +0200 (CEST) IronPort-SDR: MzzSdN9Pjm3jghhypHZAvggvr/QIeFj1QVPdkG0GzB8gfJPjbwmFQSfpZySZK4kQhiHQKSPiDO pjr5QlAaH4Ew== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 23:45:18 -0700 IronPort-SDR: QhDD+yInD8gAopaq+6ccnaY4L7x14oAIFPQ2jQYdnmhMqPpxruOGuTg40sbs1uLP0kjI1KLbfU WTR2KWFEdoBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,370,1583222400"; d="scan'208";a="261222392" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 08 May 2020 23:45:17 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 23:45:17 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 23:45:17 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.38]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.91]) with mapi id 14.03.0439.000; Sat, 9 May 2020 14:45:14 +0800 From: "Guo, Jia" To: "Zhang, Qi Z" , "Xing, Beilei" , "Wu, Jingjing" CC: "Iremonger, Bernard" , "Ye, Xiaolong" , "dev@dpdk.org" Thread-Topic: [PATCH] net/iavf: fix input set for rss hash Thread-Index: AQHWJFIa1Xc5iAtbHkWd2fZSzNNNA6iexSYAgACMtGA= Date: Sat, 9 May 2020 06:45:13 +0000 Message-ID: <01BA8470C017D6468C8290E4B9C5E1E8405431C2@shsmsx102.ccr.corp.intel.com> References: <20200507212943.7858-1-jia.guo@intel.com> <039ED4275CED7440929022BC67E7061154812A32@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061154812A32@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix input set for rss hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ok. Best regards, Jeff Guo -----Original Message----- From: Zhang, Qi Z =20 Sent: Saturday, May 9, 2020 2:21 PM To: Guo, Jia ; Xing, Beilei ; Wu,= Jingjing Cc: Iremonger, Bernard ; Ye, Xiaolong ; dev@dpdk.org Subject: RE: [PATCH] net/iavf: fix input set for rss hash > -----Original Message----- > From: Guo, Jia > Sent: Friday, May 8, 2020 5:30 AM > To: Xing, Beilei ; Wu, Jingjing=20 > > Cc: Iremonger, Bernard ; Ye, Xiaolong=20 > ; Zhang, Qi Z ;=20 > dev@dpdk.org; Guo, Jia > Subject: [PATCH] net/iavf: fix input set for rss hash >=20 > Since some specific rss hash type need to combine with the protocol=20 > hash type when configure a rss hash rule, so add the corresponding=20 > input set to support these case for iavf hash. >=20 > Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF") > Signed-off-by: Jeff Guo > --- > drivers/net/iavf/iavf_hash.c | 96 > ++++++++++++++++++++++++++++++++++++ > 1 file changed, 96 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_hash.c=20 > b/drivers/net/iavf/iavf_hash.c index > a1d0b8364..97370aa19 100644 > --- a/drivers/net/iavf/iavf_hash.c > +++ b/drivers/net/iavf/iavf_hash.c > @@ -594,11 +594,19 @@ struct iavf_hash_match_type=20 > iavf_hash_type_list[] =3D { > /* IPV4 */ > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L2_SRC_ONLY, &hdrs_hint_eth_src}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L2_DST_ONLY, &hdrs_hint_eth_dst}, > + {IAVF_PATTERN_HINT_IPV4, ETH_RSS_ETH | ETH_RSS_L2_SRC_ONLY, > + &hdrs_hint_eth_src}, > + {IAVF_PATTERN_HINT_IPV4, ETH_RSS_ETH | ETH_RSS_L2_DST_ONLY, > + &hdrs_hint_eth_dst}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_ETH, &hdrs_hint_eth}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_S_VLAN, &hdrs_hint_svlan}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_C_VLAN, &hdrs_hint_cvlan}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L3_SRC_ONLY, &hdrs_hint_ipv4_src}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L3_DST_ONLY, &hdrs_hint_ipv4_dst}, > + {IAVF_PATTERN_HINT_IPV4, ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY, > + &hdrs_hint_ipv4_src}, > + {IAVF_PATTERN_HINT_IPV4, ETH_RSS_IPV4 | ETH_RSS_L3_DST_ONLY, > + &hdrs_hint_ipv4_dst}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_ESP, &hdrs_hint_ipv4_esp}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_AH, &hdrs_hint_ipv4_ah}, > {IAVF_PATTERN_HINT_IPV4, ETH_RSS_L2TPV3, &hdrs_hint_ipv4_l2tpv3}, @@=20 > -620,6 +628,23 @@ struct iavf_hash_match_type iavf_hash_type_list[] =3D=20 > { > &hdrs_hint_ipv4_dst_gtpu_dwn}, > {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_L3_DST_ONLY, > &hdrs_hint_ipv4_dst}, > + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 | > ETH_RSS_L3_SRC_ONLY | > + ETH_RSS_L4_SRC_ONLY, &hdrs_hint_ipv4_src_udp_src_port}, > + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 | > ETH_RSS_L3_SRC_ONLY | > + ETH_RSS_L4_DST_ONLY, > &hdrs_hint_ipv4_src_udp_dst_port}, > + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 | > ETH_RSS_L3_SRC_ONLY | > + ETH_RSS_GTPU, &hdrs_hint_ipv4_src_gtpu_up}, > + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 | > ETH_RSS_L3_SRC_ONLY, > + &hdrs_hint_ipv4_src}, > + {IAVF_PATTERN_HINT_IPV4_UDP, ETH_RSS_IPV4 | > ETH_RSS_L3_DST_ONLY | > + ETH_RSS_L4_SRC_ONLY, I think the protocol type should be ETH_RSS_NONFRAG_IPV4_UDP if level 4 mod= ification is involved. And similar change also need be applied to TCP/SCTP...=20