From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77CE945F3A; Wed, 25 Dec 2024 09:52:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41A82402F2; Wed, 25 Dec 2024 09:52:27 +0100 (CET) Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by mails.dpdk.org (Postfix) with ESMTP id BCD5C402EA for ; Wed, 25 Dec 2024 09:52:24 +0100 (CET) X-QQ-mid: Yeas2t1735116735t798t23401 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [36.24.116.64]) X-QQ-SSF: 0000000000000000000000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 16063785036216713055 To: "'Stephen Hemminger'" , Cc: "'zaiyuwang'" References: <20241008160209.68000-1-stephen@networkplumber.org> <20241008160209.68000-3-stephen@networkplumber.org> <20241204141903.2a2c3f2d@hermes.local> In-Reply-To: <20241204141903.2a2c3f2d@hermes.local> Subject: RE: [RFC 2/5] net/ngbe: fix query handling in xstats_get Date: Wed, 25 Dec 2024 16:52:14 +0800 Message-ID: <01b101db56aa$4b807360$e2815a20$@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQCLo9EvFT+q4cuMUxIvDnsNk0zWFQGlvsMfAdQLgwW1ej38MA== X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: ODcDgdcDagQKfakWEU21XPV8HJAtngSknn/IrOjY3lSb9Lj+PZjI7fiO BXR46yHYPxLMJS48HWSBC53rvDewfMpXODYdod4kbpzMoz5uqHZWD28kkER3KkblSO2Wikd c4tLTtEE79zIPglPrSVeaE+FssxZHuN7g4uzaxHM4C484yxfk+rsAw8zXFp+oIcyqCxSZ3d +xpj+oSHF5SSthALB/bI8pYOKc/jqKWNwJvED0wNSqc74e1qlK3wJCSabsMouoSUHQ7564V ueNtGIymjp2dJ2WMuS6+wmyY8CHHYzlrHzcdrEb8ITAZBYK3aRNXIAn8jweE+C+CXTCA4BI 16beSgUkvvNIWdhMDesfWBtAx9Sof8DtAToKC+q6U2bscBUbLz8DA6svSwdo8fdgq5FNrFp P/1FEeHbItXEMW9eBdO1yXicqN1/aWGn8LdjF0TGDdY4ox5xl3WzolRc846hJyoqPaAI3o2 eaBq7hhrHdqMfVvyxFY0LrFQGlCegzuClsxWAOTabloQyHczmv6s3GZ2cfL4gXSxREETUCM 67rpLmLgW+8cPtvp57NduiQRNysXR9F2S2FMpxacO490UOhDGQwI6cjMNdTtPiUe0DXcV02 XgZMK+nUjTBn/0WY54zogNRWOGJdCJJJ7Zmz1OQ+V2sS9Z1YE8nzo7UFeA57/7fXkHZ8qwQ ha7dw0zdkDmgYJWQLctgWhyWsjdpkOip5HhE00ZxOinvKIEDAYVYUPkrwnyPWCvEC6sI7Bu gHXaft29ng8z60HHv9R5w/N6QYmbDgBfwrbSV0TQtjZK0OkNZMBsk682RyOcFy3zNoC2+iE hIwyrun5a47DA9PpeJyy/TFthJg5F4aUyGce97o2DwVzq82RQYGjj9qI52lZBbPE/9fJE9E ufCX6+qg66GigaY1Z+DpbTyg6D4yP05Cd2sDX7SPgT3oDwYjdJOvCzf06twhOhOiYbex4JD WalkAnhPT03JShDi8ckrAVlcPpzcCUkpR+hY= X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= X-QQ-RECHKSPAM: 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Cc: Zaiyu Wang > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, December 5, 2024 6:19 AM > To: dev@dpdk.org > Cc: jiawenwu@trustnetic.com > Subject: Re: [RFC 2/5] net/ngbe: fix query handling in xstats_get > > On Tue, 8 Oct 2024 08:59:56 -0700 > Stephen Hemminger wrote: > > > The xstats_get function in this driver did not act the same > > as other drivers when queried. The correct check is to look > > at the requested number of stats and compare it to the available > > stats and if the request is too small, return the correct size. > > > > Bugzilla ID: 1560 > > Fixes: 8b433d04adc9 ("net/ngbe: support device xstats") > > Cc: jiawenwu@trustnetic.com > > > > Signed-off-by: Stephen Hemminger > > This needs to be tested on this hardware before merging. >