From: Kevin Traynor <ktraynor@redhat.com>
To: Xiao Zhang <xiao.zhang@intel.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] net/e1000: fix wrong mac type checking
Date: Tue, 10 Sep 2019 10:17:18 +0100 [thread overview]
Message-ID: <0200a7e0-559d-ea01-cc1b-a6df08918ec8@redhat.com> (raw)
In-Reply-To: <1568137255-10014-1-git-send-email-xiao.zhang@intel.com>
On 10/09/2019 18:40, Xiao Zhang wrote:
> The mac types of i219 are e1000_pch_spt and e1000_pch_cnp, correct the
> checking code of mac type when flushing i219 descriptor rings.
>
> Fixes: 1fc9701238ed ("net/e1000: fix i219 hang on reset/close")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
Reported-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> drivers/net/e1000/em_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
> index 20b5406..fd44924 100644
> --- a/drivers/net/e1000/em_ethdev.c
> +++ b/drivers/net/e1000/em_ethdev.c
> @@ -739,7 +739,7 @@ eth_em_stop(struct rte_eth_dev *dev)
> e1000_reset_hw(hw);
>
> /* Flush desc rings for i219 */
> - if (hw->mac.type >= e1000_pch_spt)
> + if (hw->mac.type == e1000_pch_spt || hw->mac.type == e1000_pch_cnp)
> em_flush_desc_rings(dev);
>
> if (hw->mac.type >= e1000_82544)
>
next prev parent reply other threads:[~2019-09-10 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 17:40 Xiao Zhang
2019-09-10 9:17 ` Kevin Traynor [this message]
2019-09-11 9:31 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0200a7e0-559d-ea01-cc1b-a6df08918ec8@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).