From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84284A0A0A; Wed, 20 Jan 2021 18:47:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F8DF140E1E; Wed, 20 Jan 2021 18:47:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 59E18140D8E for ; Wed, 20 Jan 2021 18:47:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611164850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eqxkyJ4gnvJaM2jEiGFUm4EwR2U9lZ0AwdowofSqmOo=; b=CIWFNokyKb90UsxMeBfvj2aIRVYE06+JR2cwrXEM+6GgXTfzYXSmCIsHdMgnU+Vs1HlNMz J9C/1eVC1MkkbWXyOLZwXVjO4DhPtpw4EckKn+eM/PWIiSc6VQqlgd99rpR+ULN6C/3EM2 1rO32rhD3WFfmVlwTfeL3x17H9EzS1E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-TT3G9iZHPwatgBiQu9a6jA-1; Wed, 20 Jan 2021 12:47:28 -0500 X-MC-Unique: TT3G9iZHPwatgBiQu9a6jA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3249C59; Wed, 20 Jan 2021 17:47:27 +0000 (UTC) Received: from [10.36.110.29] (unknown [10.36.110.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9A7B10021B3; Wed, 20 Jan 2021 17:47:19 +0000 (UTC) To: David Marchand , Ray Kinsella Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata , Thomas Monjalon References: <20210119212507.1043636-1-maxime.coquelin@redhat.com> <20210119212507.1043636-3-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <0200b65e-6efa-6ed1-2f3c-231975b23b64@redhat.com> Date: Wed, 20 Jan 2021 18:47:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 02/44] bus/vdev: add driver IOVA VA mode requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/20/21 4:32 PM, David Marchand wrote: > On Tue, Jan 19, 2021 at 10:25 PM Maxime Coquelin > wrote: >> >> This patch adds driver flag in vdev bus driver so that >> vdev drivers can require VA IOVA mode to be used, which >> for example the case of Virtio-user PMD. >> >> The patch implements the .get_iommu_class() callback, that >> is called before devices probing to determine the IOVA mode >> to be used. >> >> It also adds a check right before the device is probed to >> ensure compatible IOVa mode has been selected. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/bus/vdev/rte_bus_vdev.h | 4 ++++ >> drivers/bus/vdev/vdev.c | 31 +++++++++++++++++++++++++++++++ >> 2 files changed, 35 insertions(+) >> >> diff --git a/drivers/bus/vdev/rte_bus_vdev.h b/drivers/bus/vdev/rte_bus_vdev.h >> index f99a41f825..c8b41e649c 100644 >> --- a/drivers/bus/vdev/rte_bus_vdev.h >> +++ b/drivers/bus/vdev/rte_bus_vdev.h >> @@ -113,8 +113,12 @@ struct rte_vdev_driver { >> rte_vdev_remove_t *remove; /**< Virtual device remove function. */ >> rte_vdev_dma_map_t *dma_map; /**< Virtual device DMA map function. */ >> rte_vdev_dma_unmap_t *dma_unmap; /**< Virtual device DMA unmap function. */ >> + uint32_t drv_flags; /**< Flags RTE_VDEV_DRV_*. */ > > This will probably get broken in the future, but for now, can you > indent the comment in the same way as earlier lines? > > > The ABI check will complain about this change so we need an exception. > > rte_vdev_driver is exposed only through driver API. > We could flag the whole structure like we did for ethdev. > But there is also the alternative of just flagging the required > symbols so that we won't miss later the inclusion of this structure in > an API used by final users. > How about: > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 1dc84fa74b..435913d908 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -11,6 +11,8 @@ > ; Explicit ignore for driver-only ABI > [suppress_type] > name = eth_dev_ops > +[suppress_function] > + name_regexp = rte_vdev_(|un)register > > ; Ignore fields inserted in cacheline boundary of rte_cryptodev > [suppress_type] > > This is fine by me. >> }; >> >> +/** Device driver needs IOVA as VA and cannot work with IOVA as PA */ >> +#define RTE_VDEV_DRV_NEED_IOVA_AS_VA 0x0001 >> + >> /** >> * Register a virtual device driver. >> * >> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c >> index acfd78828f..56f15e8201 100644 >> --- a/drivers/bus/vdev/vdev.c >> +++ b/drivers/bus/vdev/vdev.c >> @@ -189,6 +189,7 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev) >> { >> const char *name; >> struct rte_vdev_driver *driver; >> + enum rte_iova_mode iova_mode; >> int ret; >> >> if (rte_dev_is_probed(&dev->device)) >> @@ -199,6 +200,14 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev) >> >> if (vdev_parse(name, &driver)) >> return -1; >> + >> + iova_mode = rte_eal_iova_mode(); >> + if ((driver->drv_flags & RTE_VDEV_DRV_NEED_IOVA_AS_VA) && (iova_mode == RTE_IOVA_PA)) { >> + VDEV_LOG(ERR, "%s requires VA IOVA mode but current mode is PA, not initializing", >> + name); >> + return -1; >> + } >> + >> ret = driver->probe(dev); >> if (ret == 0) >> dev->device.driver = &driver->driver; >> @@ -594,6 +603,27 @@ vdev_unplug(struct rte_device *dev) >> return rte_vdev_uninit(dev->name); >> } >> >> +static enum rte_iova_mode >> +vdev_get_iommu_class(void) >> +{ >> + const char *name; >> + struct rte_vdev_device *dev; >> + struct rte_vdev_driver *driver; >> + >> + TAILQ_FOREACH(dev, &vdev_device_list, next) { >> + name = rte_vdev_device_name(dev); >> + if (!name) >> + continue; > > Afaics, a device in vdev_device_list always has a name. Indeed, I will remove the check in next revision. Thanks, Maxime > >> + if (vdev_parse(name, &driver)) >> + continue; >> + >> + if (driver->drv_flags & RTE_VDEV_DRV_NEED_IOVA_AS_VA) >> + return RTE_IOVA_VA; >> + } >> + >> + return RTE_IOVA_DC; >> +} >> + >> static struct rte_bus rte_vdev_bus = { >> .scan = vdev_scan, >> .probe = vdev_probe, >> @@ -603,6 +633,7 @@ static struct rte_bus rte_vdev_bus = { >> .parse = vdev_parse, >> .dma_map = vdev_dma_map, >> .dma_unmap = vdev_dma_unmap, >> + .get_iommu_class = vdev_get_iommu_class, >> .dev_iterate = rte_vdev_dev_iterate, >> }; >> >> -- >> 2.29.2 >> > >