From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4FE7A0527; Wed, 15 Jul 2020 15:23:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE1331BEB1; Wed, 15 Jul 2020 15:23:49 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3321B1BE98 for ; Wed, 15 Jul 2020 15:23:48 +0200 (CEST) IronPort-SDR: a2qUveA69QDefJxlDfzlQcxCgHGF16uzEeDw2Nl1TWfdv/aWWulyX1fB5mg+WGnAZZc1L2E0Kb 3lN5v/WZqAGQ== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="148294094" X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="148294094" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 06:23:47 -0700 IronPort-SDR: xLstcm5lfsoQbakTjRuAMi/utdTkWSvOnIrR4FjjVYjhJQiK16qM/sbEt5wx1WNLO75TKXMiSL 5IlizNBcOpzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="324832003" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.226.44]) ([10.213.226.44]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jul 2020 06:23:44 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-21-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: <02151f1b-fab1-67ee-67fc-49708c3e8b77@intel.com> Date: Wed, 15 Jul 2020 14:23:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200701202359.17006-21-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 20/27] app/test: replace refernces to master/slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > Use initial and worker when referring to lcores > > Signed-off-by: Stephen Hemminger > --- You've changed the name of the test in test_eal_flags.c, but missed the update in meson.build to the new test name. Also, you missed updating app/test/test_lpm_perf.c. > diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c > index 981e212130bf..6b23363425c9 100644 > --- a/app/test/test_service_cores.c > +++ b/app/test/test_service_cores.c > @@ -30,7 +30,7 @@ static int > testsuite_setup(void) > { > slcore_id = rte_get_next_lcore(/* start core */ -1, > - /* skip master */ 1, > + /* skip initial */ 1, > /* wrap */ 0); > > return TEST_SUCCESS; > @@ -532,12 +532,12 @@ service_lcore_add_del(void) > TEST_ASSERT_EQUAL(1, rte_service_lcore_count(), > "Service core count not equal to one"); > uint32_t slcore_1 = rte_get_next_lcore(/* start core */ -1, > - /* skip master */ 1, > + /* skip initial */ 1, > /* wrap */ 0); > TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_1), > "Service core add did not return zero"); > uint32_t slcore_2 = rte_get_next_lcore(/* start core */ slcore_1, > - /* skip master */ 1, > + /* skip initial */ 1, > /* wrap */ 0); > TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_2), > "Service core add did not return zero"); > @@ -583,12 +583,12 @@ service_threaded_test(int mt_safe) > > /* add next 2 cores */ > uint32_t slcore_1 = rte_get_next_lcore(/* start core */ -1, > - /* skip master */ 1, > + /* skip initial */ 1, > /* wrap */ 0); > TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_1), > "mt safe lcore add fail"); > uint32_t slcore_2 = rte_get_next_lcore(/* start core */ slcore_1, > - /* skip master */ 1, > + /* skip initial */ 1, > /* wrap */ 0); > TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_2), > "mt safe lcore add fail"); There are two more instances @ lines 926 and 929. -- Thanks, Anatoly