From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C4E292FDD for ; Tue, 4 Apr 2017 19:20:51 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 04 Apr 2017 10:20:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,275,1486454400"; d="scan'208";a="841775984" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 04 Apr 2017 10:20:49 -0700 To: "Legacy, Allain" References: <20170404163654.86100-1-allain.legacy@windriver.com> <4712ffa9-b81c-bdef-ccc0-ae508d5b327d@intel.com> <70A7408C6E1BFB41B192A929744D8523969019F1@ALA-MBC.corp.ad.wrs.com> Cc: "dev@dpdk.org" From: Ferruh Yigit Message-ID: <0215e8d1-a6f8-6aac-03f0-e8723b7e5c26@intel.com> Date: Tue, 4 Apr 2017 18:20:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <70A7408C6E1BFB41B192A929744D8523969019F1@ALA-MBC.corp.ad.wrs.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 17:20:52 -0000 On 4/4/2017 6:17 PM, Legacy, Allain wrote: >> -----Original Message----- >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >> Sent: Tuesday, April 04, 2017 1:12 PM > <...> >> >> Right now compiler config files only have compiler and architecture configs, >> although it is OK to update them, to be consistent with what other PMDs did, >> what do you think: >> >> Keep AVP config enabled in "common_linuxapp" >> >> Disable AVP in following configs: >> defconfig_arm64-armv8a-linuxapp-gcc >> defconfig_arm-armv7a-linuxapp-gcc >> defconfig_ppc_64-power8-linuxapp-gcc > > If that is your preference I can update the patch but either way a compiler config file is going to be changed. > I did it the current way so that if a new architecture came along that they would not need to know to set AVP=n in their file. Indeed, this makes sense. > > Do you still want me to align to your suggestion? I still believe good to be consistent with current usage. They all can be fixed later, for example when a new architecture added, in one go. Thanks, ferruh